From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA574C636D3 for ; Tue, 7 Feb 2023 21:47:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D51785E0B; Tue, 7 Feb 2023 22:47:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="DGohmIeO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B84085E14; Tue, 7 Feb 2023 22:46:59 +0100 (CET) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E838085DE5 for ; Tue, 7 Feb 2023 22:46:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id w11so4667445qvs.7 for ; Tue, 07 Feb 2023 13:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3whSopdj1yZJIOh0yOHkLWfSwZ/e3EfV5MrWr+cgfzE=; b=DGohmIeO3Jb283YH7IntrHv/B1XqKuQaOkVQ9wbRswQQvWV31/nAhFrug6qFHkF9Uv NoJxW4YlYyOJMVb2SJ7L6coNa3wwCE/RaIAkAOFj/8TxuTddRD3mZrm+rooNifJN+WW2 e0QcGNhq8hpWzayIK2goskvoalKTxTGld8F3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3whSopdj1yZJIOh0yOHkLWfSwZ/e3EfV5MrWr+cgfzE=; b=QeujYvr9tLtM9RmuZ7+fbb5f7HZokHF5Dy5fRdLsGB+Qy22POTFGeVQawO+sRgBIL0 tAlFdgtuSq5XELWbf6FF+jmzjq/748W/Kkrai55zXzoTBVDVtUb6EG48GGdFG1olFxhC hTERZHuWoUgd4Hw2OwWEEwnvJAxTTu51qZpl9B/jIdYswD5r6+ZwzypWEZpTN+OHkI/O CIjxfZOcf9KdF4RuCDVWhS+c2qfp/wKONWvf299XGmTQ/wyX08jGctMoo0J4D0mLtqlt 6Nvy4Y5IHtXDim78rs9Fn0fk09lQbPehirGI02HErZnB2bKZj+bWMTlvGNmKmhDKYbXa odiQ== X-Gm-Message-State: AO0yUKXrG8rRoYSnD1x1IY3oo8wm5078QwOZT4YJjgY7G5AqgAn46Sdh rsyHV1SQWlx+H56Y+QeLJ7QLuw== X-Google-Smtp-Source: AK7set/kfF2O66IDSAViHT/MgdoTXProUmtZNo1p2CP/dMm5xlSLvcsiEb7WB8LDkqbMHzYdHdIX3w== X-Received: by 2002:ad4:5961:0:b0:56b:f7fd:1cb4 with SMTP id eq1-20020ad45961000000b0056bf7fd1cb4mr7860388qvb.18.1675806414720; Tue, 07 Feb 2023 13:46:54 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-90cc-7e59-435b-3104.res6.spectrum.com. [2603:6081:7b00:6400:90cc:7e59:435b:3104]) by smtp.gmail.com with ESMTPSA id c10-20020ac8660a000000b003995f6513b9sm9972832qtp.95.2023.02.07.13.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 13:46:54 -0800 (PST) Date: Tue, 7 Feb 2023 16:46:52 -0500 From: Tom Rini To: Simon Glass Cc: Michal Simek , u-boot@lists.denx.de, U-Boot Custodians Subject: Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema Message-ID: References: <20230201225428.2001161-1-sjg@chromium.org> <20230201225428.2001161-7-sjg@chromium.org> <5919786f-354d-7d7f-d2a7-19f0b7121a0c@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HDHWLokpsOZkoyCa" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --HDHWLokpsOZkoyCa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 07, 2023 at 02:43:49PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 7 Feb 2023 at 14:06, Tom Rini wrote: > > > > On Mon, Feb 06, 2023 at 10:12:27AM -0700, Simon Glass wrote: > > [snip] > > > On Mon, 6 Feb 2023 at 07:56, Michal Simek wrot= e: > > > > > > > > > > > > > > > > On 2/6/23 15:44, Tom Rini wrote: > > > > > On Mon, Feb 06, 2023 at 01:22:48PM +0100, Michal Simek wrote: > > > > >> Hi Simon, > > > > >> > > > > >> On 2/1/23 23:54, Simon Glass wrote: > > > > >>> Update various build and test components to use the new schema. > > > > >>> > > > > >>> Signed-off-by: Simon Glass > > > > >>> --- > > > > >>> > > > > >>> (no changes since v1) > > > > >>> > > > > >>> drivers/core/ofnode.c | 10 +++++----- > > > > >>> drivers/video/video-uclass.c | 4 ++-- > > > > >>> dts/Kconfig | 2 +- > > > > >>> include/dm/device.h | 2 +- > > > > >>> include/dm/ofnode.h | 10 +++++----- > > > > >>> scripts/Makefile.lib | 12 ++++++------ > > > > >>> test/dm/test-fdt.c | 2 +- > > > > >>> test/py/tests/test_ofplatdata.py | 8 ++++---- > > > > >>> tools/binman/binman.rst | 3 +-- > > > > >>> tools/dtoc/test_fdt.py | 8 ++++---- > > > > >>> 10 files changed, 30 insertions(+), 31 deletions(-) > > > > >>> > > > > >>> diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c > > > > >>> index 4d56b1a7675..5249a60639b 100644 > > > > >>> --- a/drivers/core/ofnode.c > > > > >>> +++ b/drivers/core/ofnode.c > > > > >>> @@ -1265,22 +1265,22 @@ bool ofnode_pre_reloc(ofnode node) > > > > >>> { > > > > >>> #if defined(CONFIG_SPL_BUILD) || defined(CONFIG_TPL_BUILD) > > > > >>> /* for SPL and TPL the remaining nodes after the fdtgrep 1s= t pass > > > > >>> - * had property dm-pre-reloc or u-boot,dm-spl/tpl. > > > > >>> + * had property bootph-all or bootph-pre-sram/bootph-pre-ra= m. > > > > >>> * They are removed in final dtb (fdtgrep 2nd pass) > > > > >>> */ > > > > >>> return true; > > > > >>> #else > > > > >>> - if (ofnode_read_bool(node, "u-boot,dm-pre-reloc")) > > > > >>> + if (ofnode_read_bool(node, "bootph-all")) > > > > >>> return true; > > > > >>> - if (ofnode_read_bool(node, "u-boot,dm-pre-proper")) > > > > >>> + if (ofnode_read_bool(node, "bootph-some-ram")) > > > > >>> return true; > > > > >>> /* > > > > >>> * In regular builds individual spl and tpl handling both > > > > >>> * count as handled pre-relocation for later second init. > > > > >>> */ > > > > >>> - if (ofnode_read_bool(node, "u-boot,dm-spl") || > > > > >>> - ofnode_read_bool(node, "u-boot,dm-tpl")) > > > > >>> + if (ofnode_read_bool(node, "bootph-pre-ram") || > > > > >>> + ofnode_read_bool(node, "bootph-pre-sram")) > > > > >>> return true; > > > > >> > > > > >> Please correct me if I am wrong but this change will likely brea= k all boards > > > > >> which didn't migrate to this at this stage. And because targetin= g early > > > > >> stages people will be without console. > > > > >> I think we should have transition period for 1-2 releases to giv= e people > > > > >> enough time to migrate. It means print big warning that they hav= e to migrate > > > > >> their DTS. > > > > > > > > > > What's the migration case here we're missing? Is it platforms that > > > > > maintain a dts externally, via tooling / etc, that populate those= nodes? > > > > > > > > Yes and I expect there will be a lot of DTs around with some change= s for > > > > specific products. > > > > > > > > Also for example QEMU is also generating DT based on it's configura= tion and > > > > provide it to U-Boot. > > > > https://gitlab.com/qemu-project/qemu/-/blob/master/hw/arm/xlnx-vers= al-virt.c#L91 > > > > When this patch is applied CI loop should fail for Versal. > > > > > > I am not sure how it helps us to drag this out. It is a breaking > > > change, but a drawn-out process is just going to create a lot of > > > confusion. People should be free to use the schema in Linux .dts files > > > from now on, but if it is not immediately supported in U-Boot then > > > they cannot. This is the most important point, after all. > > > > Now that we've had some of the external migration issues laid out, what > > would it look like to have some sort of backwards compatible hook here > > to fixup an older tree we've been passed? >=20 > We can't do it for SPL, since the processing happens at built time, > but for U-Boot proper we can do something like what Michal suggests, > although perhaps with a warning rather than an error. Likely the > warning would have to be displayed later (if/when U-Boot starts up) > since the console may be one of the problem nodes. Right, if it's a build time thing, we should be able to ... something. Maybe a detect and rename for now, detect and fail in a bit. But run-time, we can detect, fixup and warn later on? That seems like it might be reasonable. --=20 Tom --HDHWLokpsOZkoyCa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPixsgACgkQFHw5/5Y0 tyx+agwAh1pKDzHJKhkDZMigF0KgCKOYJ8fjaUn4hneeTLC/dXxLkerERuUJMVfo GoerLmpNxVzbaGYtmDsOVgIgNjrARjw8GHilDbZTPxNSCS8l2O5pDUeWobbSUpQy xDgOJmr5WzY4soqE3/AYcgoiAlsGuqWhwQ+44ZSbaOUM8mYei8aw7tHSSdlHt0L0 wh0UntBEQ7uRya0UvXL51uv4H+wizvkh+d4KnDGZCyns1MaJz0D7eDyedE/Ld3Gk tR3J0GRcAUlov6JOl6Mv+1k0UP7HSbltH+/n4j4oHykn0vbTsLp3WqHe2noJjChC RCfvVyRTFVeEF/RHGGNDA88d08UtvK4+zyg+dnkbTz9olERyc5eNNfCacYyNp1Mc CVLughXLUrHZfgmrv/6fCajvOH8o78ZzK5qdu7Kh7RL6vVVZL8165B2rHuRwYCPL mr1VuRw/zAf6zcC/HxHqez1D7dxeWoxISlIIFiXi6/NzMTNW1kX9X5EJl3+fFdL0 Vsh8yo5w =FCgn -----END PGP SIGNATURE----- --HDHWLokpsOZkoyCa--