u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Leo Liang <ycliang@andestech.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/3 v4] riscv: Remove OF_PRIOR_STAGE from RISC-V boards
Date: Tue, 12 Oct 2021 17:17:33 +0800	[thread overview]
Message-ID: <YWVSrYe0zdg4Qi6R@ubuntu02> (raw)
In-Reply-To: <20211011210016.135929-1-ilias.apalodimas@linaro.org>

Hi Ilias,
On Tue, Oct 12, 2021 at 12:00:13AM +0300, Ilias Apalodimas wrote:
> At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got
> introduced,  in order to support a DTB handed over by an earlier stage boo

typo: boot loader

> loader.  However we have another option in the Kconfig (OF_BOARD) which has
> identical semantics.
> 
> On RISC-V some of the boards pick up the DTB from a1 and copy it in their
> private gd_t.  Apart from that they copy it to prior_stage_fdt_address,  if
> the Kconfig option is selected, which is unnecessary.
> 
> So let's switch the config option for those boards to OF_BOARD and define
> the required board_fdt_blob_setup() for them.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Otherwise, LGTM.
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>

Best regards,
Leo

  parent reply	other threads:[~2021-10-12  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 21:00 Ilias Apalodimas
2021-10-11 21:00 ` [PATCH 2/3] board: arm: Remove OF_PRIOR_STAGE from the remaining Arm boards Ilias Apalodimas
2021-10-19 13:08   ` Tom Rini
2021-10-11 21:00 ` [PATCH 3/3] treewide: Remove OF_PRIOR_STAGE Ilias Apalodimas
2021-10-11 21:31   ` Simon Glass
2021-10-11 21:39     ` Ilias Apalodimas
2021-10-19 13:08   ` Tom Rini
2021-10-12  9:17 ` Leo Liang [this message]
2021-10-19 13:08 ` [PATCH 1/3 v4] riscv: Remove OF_PRIOR_STAGE from RISC-V boards Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWVSrYe0zdg4Qi6R@ubuntu02 \
    --to=ycliang@andestech.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=u-boot@lists.denx.de \
    --subject='Re: [PATCH 1/3 v4] riscv: Remove OF_PRIOR_STAGE from RISC-V boards' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).