From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C972DC433F5 for ; Tue, 12 Oct 2021 09:19:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4EDD61056 for ; Tue, 12 Oct 2021 09:19:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4EDD61056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 59B7E8347E; Tue, 12 Oct 2021 11:19:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 7BB3A82FE7; Tue, 12 Oct 2021 11:19:45 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4791A83436 for ; Tue, 12 Oct 2021 11:19:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 19C9JPEh024088; Tue, 12 Oct 2021 17:19:25 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from ubuntu02 (10.0.12.212) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 12 Oct 2021 17:19:24 +0800 Date: Tue, 12 Oct 2021 17:17:33 +0800 From: Leo Liang To: Ilias Apalodimas CC: Subject: Re: [PATCH 1/3 v4] riscv: Remove OF_PRIOR_STAGE from RISC-V boards Message-ID: References: <20211011210016.135929-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20211011210016.135929-1-ilias.apalodimas@linaro.org> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.212] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 19C9JPEh024088 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Ilias, On Tue, Oct 12, 2021 at 12:00:13AM +0300, Ilias Apalodimas wrote: > At some point back in 2018 prior_stage_fdt_address and OF_PRIOR_STAGE got > introduced, in order to support a DTB handed over by an earlier stage boo typo: boot loader > loader. However we have another option in the Kconfig (OF_BOARD) which has > identical semantics. > > On RISC-V some of the boards pick up the DTB from a1 and copy it in their > private gd_t. Apart from that they copy it to prior_stage_fdt_address, if > the Kconfig option is selected, which is unnecessary. > > So let's switch the config option for those boards to OF_BOARD and define > the required board_fdt_blob_setup() for them. > > Signed-off-by: Ilias Apalodimas > Reviewed-by: Simon Glass Otherwise, LGTM. Reviewed-by: Leo Yu-Chi Liang Best regards, Leo