From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11D5DC433F5 for ; Thu, 12 May 2022 14:43:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0247580885; Thu, 12 May 2022 16:43:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="gEMsv97z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3995680F7B; Thu, 12 May 2022 16:43:39 +0200 (CEST) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E873880541 for ; Thu, 12 May 2022 16:43:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x32c.google.com with SMTP id n6-20020a05600c3b8600b0039492b44ce7so3159511wms.5 for ; Thu, 12 May 2022 07:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YRuNrRl1Dnx1pZ7LkcV/77IfrgPp37d1Nn/wzFw1jh8=; b=gEMsv97zwJWsM3N5mnLAsKfDLYgPC1C0D3nVLrdDrJP906swccsIkYeQGhMwFu33PS 2TRVwz0hXFXIs+p2nPtT/iamcmF7UpBgg6Y8HZpi8ILUzgwe3TkP4k69tuAWlim/OF0q UWDjeehmzcoySJFzva/6k782DzGHpJbLIiya0H5sUGCULJKeNSeIQc9zDAtkOLqpaGAH OB75EVw0BD5jRGEwlKAGif0RZnZslVmUbqmWEhfrhuvSSMx1+IoF+3E2ALsyXIL9gz84 dU9aFq4f3RJsgu3/7R0eBp7Sl11a8NJXvkjm/0iU1VUoABH0ELwXN/CqQGZQr348zDe+ VoIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YRuNrRl1Dnx1pZ7LkcV/77IfrgPp37d1Nn/wzFw1jh8=; b=jx7bTi78jzYBYst9RZezB1YnM+mSkojxoCX1BCfnqyzJqTpLhg8q8JXG5BOCJjI3Zf 2NcwCXLMi/UqA0fLZ/ztgdiVdgaMlVMknVWD4y7kPWkslL2bpz8KVWsnkhKE6RrFFjY/ qvXjL5d8NMhyRDnaYAMgR+pkX3DsOhho8Hro1w8IzuvkVMRCkyh+jjH7XQGT6UdxbFPM f0Dfe7PUZg+OQtC2aPYht8g12qvvJ6xTu4c5jdZcZAozknee1/g7gIl4aFCbs5Cu70Iv KlMeEVcU/vrFyWErO52e5BBSb2yCI6INpHnc/6Cg+J61YEWiQUiDexc5c3qXbag8TGtz XKzQ== X-Gm-Message-State: AOAM531FR+HdyKJ4GFKXVplowbGN2phTI96kn8/gD5CuoxWHhncW1cMI PyoV9WazqniIBIZQSaKcBBQoGg== X-Google-Smtp-Source: ABdhPJyRzfFKBSwh4X3LO0KUXLa1t5xS7pXwD0w0wbY7n3/kHhI8PRsnQfb2YreQWxIIvlLrVgp75g== X-Received: by 2002:a05:600c:34d4:b0:394:91a8:104b with SMTP id d20-20020a05600c34d400b0039491a8104bmr10461277wmq.134.1652366615530; Thu, 12 May 2022 07:43:35 -0700 (PDT) Received: from hera (athedsl-4461585.home.otenet.gr. [94.71.4.1]) by smtp.gmail.com with ESMTPSA id i10-20020a05600c354a00b003942a244f37sm3293712wmq.16.2022.05.12.07.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 07:43:34 -0700 (PDT) Date: Thu, 12 May 2022 17:43:31 +0300 From: Ilias Apalodimas To: Abdellatif El Khlifi Cc: Tom Rini , u-boot@lists.denx.de, sudeep.holla@arm.com, achin.gupta@arm.com, robh@kernel.org, sjg@chromium.org, vishnu.banavath@arm.com, xueliang.zhong@arm.com, nd@arm.com Subject: Re: [PATCH v2 0/6] introduce Arm FF-A support Message-ID: References: <20220413172943.rvvxrsl5ukxy7xkg@bogus> <20220415122803.16666-1-abdellatif.elkhlifi@arm.com> <20220415154325.GY14282@bill-the-cat> <20220509105514.GA4201@e121910.cambridge.arm.com> <20220512140438.GA817@e121910.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512140438.GA817@e121910.cambridge.arm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Thu, May 12, 2022 at 03:04:38PM +0100, Abdellatif El Khlifi wrote: > On Mon, May 09, 2022 at 11:55:14AM +0100, Abdellatif El Khlifi wrote: > > On Fri, Apr 15, 2022 at 11:43:25AM -0400, Tom Rini wrote: > > > On Fri, Apr 15, 2022 at 01:27:57PM +0100, abdellatif.elkhlifi@arm.com wrote: > > > > > > > From: Abdellatif El Khlifi > > > > > > > > This patchset adds support for Arm FF-A (Arm Firmware Framework for Armv8-A v1.0). > > > > > > > > FF-A support is generic by design and can be used by any Arm platform. > > > > > > > > The features added are as follows: > > > > > > > > 1/ FF-A bus driver > > > > 2/ armffa command > > > > 3/ FF-A Sandbox driver > > > > 4/ FF-A Sandbox test cases > > > > 5/ FF-A MM communication > > > > > > > > The suggested design considers FF-A as a discoverable bus. > > > > The Secure World is considered as one entity to communicate with using the FF-A bus. > > > > FF-A communication is handled by one device and one instance (the bus). > > > > This FF-A driver takes care of all the interactions between Normal world > > > > and Secure World. > > > > > > > > The Secure World firmware runs under TrustZone HW (such as Optee). The same approach was followed in the > > > > FF-A driver in Linux kernel (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/arm_ffa/bus.c?h=v5.15#n211)) > > > > > > > > Cc: Tom Rini > > > > Cc: Rob Herring > > > > Cc: Ilias Apalodimas > > > > Cc: Achin Gupta > > > > Cc: Simon Glass > > > > Cc: Vishnu Banavath > > > > > > I don't see a changelog compared with v1. Are any of the comments there > > > addressed? Thanks. > > > > > > -- > > > Tom > > > > Thanks Tom. I'll add a changelog for future versions. > > > > The current Changelog: > > > > Changelog: > > =============== > > v2 (15 Apr 2022) > > * Make FF-A bus discoverable (remove device tree support, bind and probe FF-A device using device_bind and device_probe) > > > > v1 (29 Mar 2022) > > * FF-A bus driver with device tree support > > * armffa command > > * FF-A Sandbox driver > > * FF-A Sandbox test cases > > * FF-A MM communication > > > > Hello guys, gentle ping, any feedback about the implementation of FF-A as a discoverable > bus ? Apologies for the late reply, I was on vacation. I'll try having a closer look on patch #1-5 in the upcoming days. Can you take a look at my comments on patch #6 and reply? Thanks /Ilias