From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36C33C433FE for ; Thu, 6 Oct 2022 10:41:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D13C84C17; Thu, 6 Oct 2022 12:41:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cSLcYB1A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A7828492C; Thu, 6 Oct 2022 12:41:40 +0200 (CEST) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D18378492C for ; Thu, 6 Oct 2022 12:41:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x634.google.com with SMTP id qn17so3728634ejb.0 for ; Thu, 06 Oct 2022 03:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=5A5WkTqDnMb3NJh+S2FvU69IuPMu92zlKEk50ZEowDY=; b=cSLcYB1A/f6DTzxVeOMkL32iKfASWpCoJ+faRQLtz2VQ7o03KH1Sbe/BaCmLsZz3NX +tlrgonas7MzoD8wwG0tDYbKHV4ASSnQyTZod561DNSGpLxJmYpxJDyPImE+1fiBeCGW mmlFyXEFOoMPhKw7ZuJQ6+ZMPLdy+VUrp9qFngC/umGiN00L4L1J4LPQmH3OZ9eoRrNF 3wPKwTjeXvMSm2Ebi6nYtVjyF/AEh4TfHqZbvREm0SIGMIEhcza7dmbtT4tAV03OMJmd VEzVhnmGf4kkrphTEzg6GsVPy7JUhNFyWvRGpzdohmUieD8O2AvW4CVvspk2KMhAKmpv RrTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=5A5WkTqDnMb3NJh+S2FvU69IuPMu92zlKEk50ZEowDY=; b=mOMTotzGczUoiiH7P/f8DqgKN4kBLrOpGy52cY/+MAPyAHsnDBty6Tb2px6d5Q9eXZ nBsR+wwNi7e85QvyLiZbGXlqEw4WYCRZvDc2V4yMBg0/CNMeC/5BWYAJcEjM5S1mQOG0 GNyHu+lV53XUovQS/J+OyeDjAxk3UcJsv4je0JSPWTRw+ZOa/Atp3n1Eo91PcP7JKQ6k vm4NVVJPgDBw5/bKj3faCD4UGru0dq+RrcpaGq8scQkBW0u6cfjWUj6foJDpGoX92QCz frjJ4lvP1o+DSh9ji7MkjUCGKSwg8c0b8GawBV7B6srCj6WZcIbwG9KuwzMgOJgLaBDI rI4Q== X-Gm-Message-State: ACrzQf12dUlUYzMI0wveLOhGdelI7phE6pR5GbHvE3JpYBPHC4jnPiSG FFwx1zT+ZxmTSpGsZ53v9wVlyg== X-Google-Smtp-Source: AMsMyM7QU2d31eITDF8IyAvUK2VxxpNaSUljsBReVfRLgdJE7DoAinlatCG+HCxrMPqF7orHqQADWQ== X-Received: by 2002:a17:907:9816:b0:787:4350:3a19 with SMTP id ji22-20020a170907981600b0078743503a19mr3251542ejc.627.1665052897436; Thu, 06 Oct 2022 03:41:37 -0700 (PDT) Received: from hades (ppp046103015185.access.hol.gr. [46.103.15.185]) by smtp.gmail.com with ESMTPSA id e4-20020a056402148400b00458824aee80sm5618774edv.38.2022.10.06.03.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 03:41:36 -0700 (PDT) Date: Thu, 6 Oct 2022 13:41:34 +0300 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, AKASHI Takahiro Subject: Re: [RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple Message-ID: References: <20221005152603.3085754-1-ilias.apalodimas@linaro.org> <20221005152603.3085754-2-ilias.apalodimas@linaro.org> <4f29d908-6ce5-3a68-5d2e-dbb08c7dd3a2@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f29d908-6ce5-3a68-5d2e-dbb08c7dd3a2@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich [...] > > - return EFI_EXIT(EFI_INVALID_PARAMETER); > > + return EFI_INVALID_PARAMETER; > > Please, use a efi_search_obj(handle) to determine if the handle is valid. > > if (!efi_search_obj(handle)) > return EFI_INVALID_PARAMETER; We should only check against NULL here, since we need to add a new handle if it doesn't exist. In Uninstall that would make sense, but we already check that in efi_uninstall_protocol(). [...] Thanks /Ilias