From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE252C433EF for ; Thu, 23 Sep 2021 01:45:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B43DA60FC1 for ; Thu, 23 Sep 2021 01:45:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B43DA60FC1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 54CB483301; Thu, 23 Sep 2021 03:45:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632361536; bh=6bouGyyia5as4uWP9m/g5GKw2pT04j1JGWdaI6E+K5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HUXYKeKApVMUYJQFwn6nclN52F+FbEMtvd+h/z4XSpu/aEQq44/xZSsHLcJw5I6O4 B7ZjjhdLNGdJZO6qKGo65+aL96w8iUaYjrQunSYzt970GVJFKqNwKeIjO4B96/QPad CvmFPZxK9R2XfYj/GvGQ4LcMzhFtsioJFTTmxufWjHs9Mgdq4tmqWl4V7FbtLrRL7c 8l60mcAYk/2Y0h6C8TRNUxWO/35U58QUZ2dAJUKXR+rkk/23+hKAA62AX4azPrjGdV ZNKLSG0SSqZfxsHPhvwu/98Q4KdiDC6JWGgR/iHsU6R9+OjVsh+rq3b31BlgxKrzDQ l9+eRpRpipRvg== Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 8248D83301; Thu, 23 Sep 2021 03:45:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632361532; bh=6bouGyyia5as4uWP9m/g5GKw2pT04j1JGWdaI6E+K5w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=BFLQ+3Mhij8QQk2hDQVjmbzt2ReGf3TvKu/9ayVzIBcZ4c1wZ3Tg5HvKy5vSlki8E Irhnm8TlMpNMSTgSpR3jFSluDPYL2mTm86DpHZkeVPHRsEY8jhl0g5K1X7A/S/Tvx4 O8rQ9W0hbg++9eGL/BKyKrTB7hz7grq//LRpUtfNQJ0S1i2oYx/2igFgw8mrw+/3O2 PHEcXBcQhfzGxdwrAboFtWCDMK0cs+AZ0cZVsvZwYukzKTsUQAgnJQw0QYGPSLAYRh 1HjmIaYDDIkleCSBLLhoBVkk955DMHF5SkjpGq9ve03vFQmZXL/pkybaV+EfuLkK3W g+V/m2Plxkw6Q== Subject: Re: [PATCH v4 0/2] mtd: spi: nor: force mtd name to "nor%d" To: Tom Rini Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Patrick Delaunay , u-boot@lists.denx.de, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Jagan Teki , Christophe KERELLO , Miquel Raynal , Priyanka Jain , Patrice Chotard , Heiko Schocher , Simon Glass , Vignesh R , U-Boot STM32 References: <20210922162909.1857566-1-patrick.delaunay@foss.st.com> <20210922192925.723abcba@thinkpad> <20210922210536.6c9c2f9e@thinkpad> <56df80f7-aa1d-3cff-5b29-16fdafcf7bcf@denx.de> <20210922194615.GD31748@bill-the-cat> <59ce8fa7-64f2-07c9-ee2b-4b59335b3907@denx.de> <20210922200053.GE31748@bill-the-cat> From: Marek Vasut Message-ID: Date: Thu, 23 Sep 2021 03:32:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210922200053.GE31748@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/22/21 10:00 PM, Tom Rini wrote: > On Wed, Sep 22, 2021 at 09:56:26PM +0200, Marek Vasut wrote: >> On 9/22/21 9:46 PM, Tom Rini wrote: >>> On Wed, Sep 22, 2021 at 09:24:24PM +0200, Marek Vasut wrote: >>> >>>> I am talking about using nor%d in MTDIDS in U-Boot UBI code to look up from >>>> which device to attach UBI in U-Boot. >>> >>> OK, so are we not able to pass in the correct name now? Or just worried >>> about old environment and new U-Boot? >> >> Say you have the following in board config: >> >> CONFIG_MTDIDS_DEFAULT="nor0=ff705000.spi.0" >> CONFIG_MTDPARTS_DEFAULT="mtdparts=ff705000.spi.0:-(fs);" >> >> Then run "=> ubi part fs", which will fail to find nor0, because now that >> nor0 is called something else. That is what this series tries to fix. > > Yes, and what is nor0 now, and what happens if you use it? Now it is "mt25ql02g", for all mt25ql02g on the board, so ... I cannot even select the one SPI NOR I want to use, since they are not even enumerated in any way, they are all the same. You might want to look at get_mtd_device_nm() in drivers/mtd/mtdcore.c .