From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B7D4C43217 for ; Mon, 7 Nov 2022 14:17:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E129C848C2; Mon, 7 Nov 2022 15:17:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="LEi/1IVp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A8AA184198; Mon, 7 Nov 2022 15:17:36 +0100 (CET) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A309580384 for ; Mon, 7 Nov 2022 15:17:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jerome.forissier@linaro.org Received: by mail-wr1-x432.google.com with SMTP id v1so16392178wrt.11 for ; Mon, 07 Nov 2022 06:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SPQnRaxSSHhSyQyXw4sGQIKVF0qiqIUwWXyUgfpCN+M=; b=LEi/1IVpyT3Mwglv7Og8Rd0+K7XETwQSrdLbPZVv7u5jjurGmHM5HkqxLXl4S4poen SgFiqWCKoVqp7kxfjMO2uZ4T3d1mD0bGxOoTvDbUsB0ks80EfDQF85fH74oeRtWCESuh 8+oeRgMIjVNqNOJO9PSXFjPAOBFk5EMw+3ioXeAJZLunNKYou/LInVGF/pz7DFR1Ggm9 Ql5FM87bc5BgKyAanaZ7VFUtXM9E7S76pmvDzLlYv3gagtiEmMk/G0bU6yVWUbK/0K9U /OG1Bg4cVxdw/kHEGcv1D8J3FFFTwNMsJCq2ccx3Hxj85rvzSf6ewUBdiQm00ltVdimz BbAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SPQnRaxSSHhSyQyXw4sGQIKVF0qiqIUwWXyUgfpCN+M=; b=ADbPZcLSDcIuYiHePlLIbU8W/4hs1qfcWwGP9NlSE3uultI1XmALC3pstb8KYuXqW1 ow7k3JxeiQj2xdHBRzUoezqNJm5Un5GM4Z+1twmc3um/BFw6k6jh+Xl+JbfNtqJeqZt3 zBZv/ez2lDctwosesEnoCCVYJOircjF+P4krbi9m7A6mzA7jC9Nz03dBEig7PYj8Qlan 6I9F01uk3rKjaQu2i+N4R+yE5YKZd+a1yyFxX5A9AMTcstnGdUa74K2blFlLdBqvgdzo G4aAbzsluf8OOdUKreHsguyO6tZhO1bhpeF0fc5S2aV0pGpjeOcKhElDSBAk1KurR53j dt3Q== X-Gm-Message-State: ACrzQf21Q0JkH0YdMi9e8lgTnIQ1w9XfZcIpG5NHFYX/pi0e4MPY/kke 1LX1zgRTBnAww1/WMWFdTbMIVA== X-Google-Smtp-Source: AMsMyM6l8Xih9buc1P+lCPCaO8FRj3aLUJL9EWTjk95p7YPKRSTgzFn9EaNwoDM1deE1mikcHj+n5A== X-Received: by 2002:adf:f609:0:b0:236:680b:8c65 with SMTP id t9-20020adff609000000b00236680b8c65mr33277311wrp.615.1667830653193; Mon, 07 Nov 2022 06:17:33 -0800 (PST) Received: from [192.168.0.45] (91-175-45-238.subs.proxad.net. [91.175.45.238]) by smtp.gmail.com with ESMTPSA id n19-20020a05600c4f9300b003c5571c27a1sm11105986wmq.32.2022.11.07.06.17.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 06:17:32 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 15:17:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 4/7] rockchip: Support building the all output files in binman To: Simon Glass , U-Boot Mailing List Cc: Roger Quadros , Alper Nebi Yasak , Peter Geis , Philippe Reynes , Ivan Mikhaylov , Tom Rini , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Philipp Tomsich References: <20221106224011.606743-1-sjg@chromium.org> <20221106224011.606743-5-sjg@chromium.org> Content-Language: en-US From: Jerome Forissier In-Reply-To: <20221106224011.606743-5-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/6/22 23:40, Simon Glass wrote: > Add the required binman images to replace the Makefile rules which are > currently used. This includes subsuming: > > - tpl/u-boot-tpl-rockchip.bin if TPL is enabled > - idbloader.img if either or both of SPL and TPL are enabled > - u-boot.itb if SPL_FIT is enabled > - u-boot-rockchip.bin if SPL is used, either using u-boot.itb when > SPL_FIT is enabled or u-boot.img when it isn't > > Note that the intermediate files are dropped with binman, since it > producing everything in one pass. This means that > tpl/u-boot-tpl-rockchip.bin is not created, for example. > > Note that for some 32-bit rk3288 boards, rockchip-optee.dtsi is included. > > Signed-off-by: Simon Glass > --- > > (no changes since v3) > > Changes in v3: > - Add an offset to the FIT description > > Changes in v2: > - Rename op-tee to tee-os > - Drop use of .itb2 > > arch/arm/dts/rockchip-u-boot.dtsi | 73 ++++++++++++++++++++++++++++--- > 1 file changed, 68 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi > index 584f21eb5bf..084f72b0bd4 100644 > --- a/arch/arm/dts/rockchip-u-boot.dtsi > +++ b/arch/arm/dts/rockchip-u-boot.dtsi > @@ -30,14 +30,77 @@ > }; > }; > > -#ifdef CONFIG_ARM64 > - blob { > +#if defined(CONFIG_SPL_FIT) && defined(CONFIG_ARM64) > + fit: fit { > + description = "FIT image for U-Boot with bl31 (TF-A)"; > + #address-cells = <1>; > + fit,fdt-list = "of-list"; > filename = "u-boot.itb"; > + fit,external-offset = ; > + offset = ; > + images { > + u-boot { > + description = "U-Boot (64-bit)"; > + type = "standalone"; > + os = "U-Boot"; > + arch = "arm64"; > + compression = "none"; > + load = ; > + u-boot-nodtb { > + }; > + }; > + > + @atf-SEQ { > + fit,operation = "split-elf"; > + description = "ARM Trusted Firmware"; > + type = "firmware"; > + arch = "arm64"; > + os = "arm-trusted-firmware"; > + compression = "none"; > + fit,load; > + fit,entry; > + fit,data; > + > + atf-bl31 { > + }; > + }; > + @tee-SEQ { > + fit,operation = "split-elf"; Does this imply that the TEE image shall be supplied as an ELF file? That won't work with OP-TEE, see commit 348310233dac ("mach-rockchip: make_fit_atf.py: support OP-TEE tee.bin v1 format"). > + description = "TEE"; > + type = "tee"; > + arch = "arm64"; > + os = "tee"; > + compression = "none"; > + fit,load; > + fit,entry; > + fit,data; > + > + tee-os { > + }; > + }; Thanks, -- Jerome