From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7DAC4320A for ; Thu, 12 Aug 2021 22:21:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 183B3610A5 for ; Thu, 12 Aug 2021 22:21:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 183B3610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 702FC82DC3; Fri, 13 Aug 2021 00:21:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="n/RbYvbw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 089A182DD4; Fri, 13 Aug 2021 00:21:01 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FDE582DAD for ; Fri, 13 Aug 2021 00:20:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20210812222050epoutp01da0a51f1a8eb4d91f51b584a9b8065bc~arzNqFVPh3229332293epoutp01c for ; Thu, 12 Aug 2021 22:20:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20210812222050epoutp01da0a51f1a8eb4d91f51b584a9b8065bc~arzNqFVPh3229332293epoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1628806850; bh=f3sz5rUrvounqYY23Zgh9c48kQGZNJf1vMKMADUhj0c=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=n/RbYvbw5eM+2jxmhYywP8SJpPQpjoDIWtR+YvmdOdtASrrRSCIl7NfzV668n5Vl3 0G0LpsIIn9utRSxY81kCf9FNiKDyDaYptUZCUbuHE2uQ1KCJ5f6MRj8zWfvxAbQdKt SeIhVddKu1uRmAWTnuqE2hxpPjJVnSvmUG9iFJbo= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20210812222050epcas1p23611cc22ff51ac608bd469bfdf13b880~arzNPbtAd1930119301epcas1p24; Thu, 12 Aug 2021 22:20:50 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.40.157]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Gm1Nb4R9cz4x9Pw; Thu, 12 Aug 2021 22:20:47 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 51.60.21710.FBE95116; Fri, 13 Aug 2021 07:20:47 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20210812222046epcas1p3635782c6d084746b447facab1d46b285~arzJr-sdS0943509435epcas1p3p; Thu, 12 Aug 2021 22:20:46 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210812222046epsmtrp16e1e15b3cdd38f1da2699eb07f889f78~arzJrXnNZ2120621206epsmtrp1M; Thu, 12 Aug 2021 22:20:46 +0000 (GMT) X-AuditID: b6c32a37-059ff700000154ce-a5-61159ebf398e Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id ED.71.32548.EBE95116; Fri, 13 Aug 2021 07:20:46 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20210812222046epsmtip22e7e3692c992e57a3fedd9cd15ced505~arzJfsjhC2388923889epsmtip2V; Thu, 12 Aug 2021 22:20:46 +0000 (GMT) Subject: Re: [PATCH 21/23] power: Refactor Makefile rules To: Simon Glass , U-Boot Mailing List Cc: Tom Rini From: Jaehoon Chung Message-ID: Date: Fri, 13 Aug 2021 07:21:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210808182031.3747270-22-sjg@chromium.org> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJKsWRmVeSWpSXmKPExsWy7bCmvu7+eaKJBufPy1p827KN0WLqpM3s Fm/3drI7MHvMbrjI4vHqwCp2j7N3djAGMEdl22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY 6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVJSKEvMKQUKBSQWFyvp29kU5ZeWpCpk5BeX2CqlFqTk FFgW6BUn5haX5qXrJefnWhkaGBiZAhUmZGcsPvWfveCyTsX9VbeZGhgPqXQxcnJICJhI3P95 k62LkYtDSGAHo8S3my8YIZxPjBLLb31jhXA+M0psm9UJlOEAa5k23RsivotRYtmUHmYI5z2j xLEjW5lA5goLWErsP/aSFcQWEQiQ+Lf+HgtIM7OAosTKe8ogYTYBHYnt346DlfMK2Enc+LGR DcRmEVCVWHqwjxnEFhWIlDi/ewELRI2gxMmZT8DGcAKN/zqDGyTMLCAucevJfCYIW15i+9s5 YOdICDxil2jqu8IK8aaLxP2Lp9ggbGGJV8e3sEPYUhIv+9ug7GqJXc1noJo7GCVubWtigkgY S+xfOpkJ4n5NifW79CHCihI7f89lhFjMJ/Huaw8rJHx4JTrahCBKVCQuvX7JBLPq7pP/UOd4 SKx78pF1AqPiLCSfzULyziwk78xCWLyAkWUVo1hqQXFuemqxYYExclxvYgSnQS3zHYzT3n7Q O8TIxMF4iFGCg1lJhHennFCiEG9KYmVValF+fFFpTmrxIUZTYFhPZJYSTc4HJuK8knhDUyNj Y2MLE0MzU0NDJXHeb7FfE4QE0hNLUrNTUwtSi2D6mDg4pRqYjFSvlHi/07VesIQ3+HNkTOGp /qUS8yxlmD+br3M7Wnbi8Y0299dX52/q25rZU3vt79Xnh7XcF075mNuhL8P0/fXj83fCs6+/ 01xs7K/dvvJbLn9F866ZpY65j0zi1/6cIi73fYahFKfhrkMtvGXHy3zXLtvSvHk2x2uey/vn aV67z3I7L/OZWsRCiUiTG1sSeS0vHb+/6EZNVnHQPHO+9raJr6u2a345WmxZnpg/0dl9a1aR hfLENpO9npkyc7oXZSUvvJE84cG6n0vvTNrTve2mWvl35xtMi/d8eV461ehN2f6wJaon0pVi leUmPZqe/bvngNElxwvRTyXypB98P/FVJ/LahiMhbu0aS+udGZVYijMSDbWYi4oTAYUA0PMM BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsWy7bCSvO6+eaKJBieu8Vp827KN0WLqpM3s Fm/3drI7MHvMbrjI4vHqwCp2j7N3djAGMEdx2aSk5mSWpRbp2yVwZSw+9Z+94LJOxf1Vt5ka GA+pdDFycEgImEhMm+7dxcjFISSwg1GiuX0uSxcjJ1BcSuLz06lsEDXCEocPF0PUvGWU2PJm L1iNsIClxP5jL1lBbBEBP4mW2UsZQeqZBRQlVt5ThqjfxShx899ndpAaNgEdie3fjjOB2LwC dhI3fmxkA7FZBFQllh7sYwaxRQUiJT4veMUKUSMocXLmExaQmZxAu77O4AYJMwuoS/yZd4kZ whaXuPVkPhOELS+x/e0c5gmMQrOQdM9C0jILScssJC0LGFlWMUqmFhTnpucWGxYY5aWW6xUn 5haX5qXrJefnbmIEh72W1g7GPas+6B1iZOJgPMQowcGsJMK7U04oUYg3JbGyKrUoP76oNCe1 +BCjNAeLkjjvha6T8UIC6YklqdmpqQWpRTBZJg5OqQamhBNypYHXN26MUbdm/sFxO7280Xza 99ojrY2lSe0Gaq4vRTe/04ryWGG2XND6aHTOcqunAqcNdTc9MxA0/HDctL1Rc8edCY7LP9h3 HmpbsKnv6STH0yE/nW4dZXSTLs3bErP+/cGqsMUhIhuvTCxPW2YUmcX16bWqjF3gzuiCusCf viZ+h1tubptsxvlM0///X6G5/+u5Dz9nMHnbr6F72ZRlrVbH06xNTOWGqw+vq/0o3dpqstjk OdO3aSwbsu7lTcpkfXJForLg0uYtkazz7zpr/9VP/iy1Xjd0gZfg3z0fmHhPiXesXlAUz/Pu juXm6E0/OZc8Oq1wZ9eyR943jj6ZxsN5Uez1ghVvqs7tV2Ipzkg01GIuKk4EAGr47cvqAgAA X-CMS-MailID: 20210812222046epcas1p3635782c6d084746b447facab1d46b285 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210808182445epcas1p340789e20dc10a8b069afcda3dba9918d References: <20210808182031.3747270-1-sjg@chromium.org> <20210808182031.3747270-22-sjg@chromium.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 8/9/21 3:20 AM, Simon Glass wrote: > Move the power/ rules into drivers/power to avoid clutter in the Makefile > and drivers/Makefile files. > > We must select SPL_POWER if SPL_POWER_DOMAIN is used, since the two are > currently independent and boards do not necessarily enable SPL_POWER. > > Add a TPL_POWER as well, as that is used by one board. > > Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung Best Regars, Jaehoon Chung > --- > > Makefile | 7 ------- > common/spl/Kconfig | 13 +++++++++++++ > configs/chromebook_coral_defconfig | 2 ++ > drivers/Makefile | 5 +---- > drivers/power/Makefile | 8 ++++++++ > drivers/power/acpi_pmc/Makefile | 2 +- > 6 files changed, 25 insertions(+), 12 deletions(-) > > diff --git a/Makefile b/Makefile > index cc51265f1fc..c744ff8ee4e 100644 > --- a/Makefile > +++ b/Makefile > @@ -815,13 +815,6 @@ libs-y += disk/ > libs-y += drivers/ > libs-y += drivers/net/ > libs-y += drivers/net/phy/ > -libs-y += drivers/power/ \ > - drivers/power/domain/ \ > - drivers/power/fuel_gauge/ \ > - drivers/power/mfd/ \ > - drivers/power/pmic/ \ > - drivers/power/battery/ \ > - drivers/power/regulator/ > libs-$(CONFIG_FMAN_ENET) += drivers/net/fm/ > libs-$(CONFIG_SYS_FSL_DDR) += drivers/ddr/fsl/ > libs-$(CONFIG_SYS_FSL_MMDC) += drivers/ddr/fsl/ > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index 1ce74d07618..59672d2fdd3 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -1042,6 +1042,7 @@ config SPL_POWER > > config SPL_POWER_DOMAIN > bool "Support power domain drivers" > + select SPL_POWER > help > Enable support for power domain control in SPL. Many SoCs allow > power to be applied to or removed from portions of the SoC (power > @@ -1431,6 +1432,18 @@ config TPL_NEEDS_SEPARATE_STACK > Enable, if the TPL stage should not inherit its initial > stack-pointer from the settings for the SPL stage. > > +config TPL_POWER > + bool "Support power drivers" > + help > + Enable support for power control in TPL. This includes support > + for PMICs (Power-management Integrated Circuits) and some of the > + features provided by PMICs. In particular, voltage regulators can > + be used to enable/disable power and vary its voltage. That can be > + useful in TPL to turn on boot peripherals and adjust CPU voltage > + so that the clock speed can be increased. This enables the drivers > + in drivers/power, drivers/power/pmic and drivers/power/regulator > + as part of an TPL build. > + > config TPL_TEXT_BASE > hex "Base address for the .text section of the TPL stage" > depends on TPL_NEEDS_SEPARATE_TEXT_BASE > diff --git a/configs/chromebook_coral_defconfig b/configs/chromebook_coral_defconfig > index eb0884f1f5d..321ad7de5b7 100644 > --- a/configs/chromebook_coral_defconfig > +++ b/configs/chromebook_coral_defconfig > @@ -44,7 +44,9 @@ CONFIG_SPL_SEPARATE_BSS=y > CONFIG_SPL_CPU=y > CONFIG_SPL_DM_SPI_FLASH=y > CONFIG_SPL_PCI=y > +CONFIG_SPL_POWER=y > # CONFIG_SPL_SPI_FLASH_TINY is not set > +CONFIG_TPL_POWER=y > CONFIG_HUSH_PARSER=y > CONFIG_CMD_CPU=y > CONFIG_CMD_PMC=y > diff --git a/drivers/Makefile b/drivers/Makefile > index d63cc48f5f4..c256cd97210 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -22,6 +22,7 @@ obj-$(CONFIG_$(SPL_TPL_)PCH) += pch/ > obj-$(CONFIG_$(SPL_TPL_)PCI) += pci/ > obj-$(CONFIG_$(SPL_TPL_)PHY) += phy/ > obj-$(CONFIG_$(SPL_TPL_)PINCTRL) += pinctrl/ > +obj-$(CONFIG_$(SPL_TPL_)POWER) += power/ > obj-$(CONFIG_$(SPL_TPL_)RAM) += ram/ > obj-$(CONFIG_$(SPL_TPL_)RTC) += rtc/ > obj-$(CONFIG_$(SPL_TPL_)SERIAL) += serial/ > @@ -32,7 +33,6 @@ obj-$(CONFIG_$(SPL_)DM_MAILBOX) += mailbox/ > obj-$(CONFIG_$(SPL_)REMOTEPROC) += remoteproc/ > obj-$(CONFIG_$(SPL_)SYSINFO) += sysinfo/ > obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/ > -obj-$(CONFIG_$(SPL_TPL_)ACPI_PMC) += power/acpi_pmc/ > obj-$(CONFIG_XEN) += xen/ > obj-$(CONFIG_$(SPL_)FPGA) += fpga/ > > @@ -46,9 +46,6 @@ obj-$(CONFIG_ARMADA_38X) += ddr/marvell/a38x/ > obj-$(CONFIG_ARMADA_XP) += ddr/marvell/axp/ > obj-$(CONFIG_$(SPL_)ALTERA_SDRAM) += ddr/altera/ > obj-$(CONFIG_ARCH_IMX8M) += ddr/imx/imx8m/ > -obj-$(CONFIG_SPL_POWER) += power/ power/pmic/ > -obj-$(CONFIG_SPL_POWER) += power/regulator/ > -obj-$(CONFIG_SPL_POWER_DOMAIN) += power/domain/ > obj-$(CONFIG_SPL_DM_RESET) += reset/ > obj-$(CONFIG_SPL_ETH) += net/ > obj-$(CONFIG_SPL_ETH) += net/phy/ > diff --git a/drivers/power/Makefile b/drivers/power/Makefile > index 09fe2a958d0..5c6d6bc3ec9 100644 > --- a/drivers/power/Makefile > +++ b/drivers/power/Makefile > @@ -3,6 +3,14 @@ > # Copyright (c) 2009 Wind River Systems, Inc. > # Tom Rix > > +obj-$(CONFIG_$(SPL_TPL_)ACPI_PMC) += acpi_pmc/ > +obj-y += battery/ > +obj-$(CONFIG_$(SPL_TPL_)POWER_DOMAIN) += domain/ > +obj-y += fuel_gauge/ > +obj-y += mfd/ > +obj-y += pmic/ > +obj-y += regulator/ > + > obj-$(CONFIG_AXP152_POWER) += axp152.o > obj-$(CONFIG_AXP209_POWER) += axp209.o > obj-$(CONFIG_AXP221_POWER) += axp221.o > diff --git a/drivers/power/acpi_pmc/Makefile b/drivers/power/acpi_pmc/Makefile > index 115788f109a..0db52a65824 100644 > --- a/drivers/power/acpi_pmc/Makefile > +++ b/drivers/power/acpi_pmc/Makefile > @@ -2,5 +2,5 @@ > # > # Copyright 2019 Google LLC > > -obj-$(CONFIG_$(SPL_TPL_)ACPI_PMC) += acpi-pmc-uclass.o > +obj-y += acpi-pmc-uclass.o > obj-$(CONFIG_$(SPL_TPL_)ACPI_PMC_SANDBOX) += sandbox.o pmc_emul.o >