From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8661C433EF for ; Mon, 20 Sep 2021 07:06:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E90D661074 for ; Mon, 20 Sep 2021 07:06:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E90D661074 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=lexina.in Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C5BD80EC5; Mon, 20 Sep 2021 09:06:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=lexina.in Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=lexina.in header.i=@lexina.in header.b="nktRgIDo"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A94B80ECC; Mon, 20 Sep 2021 09:06:22 +0200 (CEST) Received: from mx.msync.work (mx.msync.work [95.217.65.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B7FBB80C68 for ; Mon, 20 Sep 2021 09:06:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=lexina.in Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=adeep@lexina.in Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 85DD610D031; Mon, 20 Sep 2021 07:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lexina.in; s=dkim; t=1632121578; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references: disposition-notification-to; bh=AzM7UpvUH30vhPUDWFJP2Map8jVbggPHKffJ8J73/+E=; b=nktRgIDolXzf037nc+H7VO8HB72/KbKeg9i1kGDggkaQD06PYEccXfWozT1IAsoCrflTDU Ooddwr5j1gKsqWKuqcfb/tHaFYJLZsMxmfcgHV0d6Fc3s/4tojTv25fyhfikcQNqI58BiD 0ui+EQJlaz0mlo5PQFRBUd2GQL2R+OKp0YlzjyB/qBkMfk+S+yBSIaGsJNOvTLKcvdwTBG E/90oQUQ2TnbFCTQC6WT7K20x/bsWD9eahn54uLFv+5CfbumuDZ9UE1KsPpVHAr6dOraSV 5p9qOmSMHxUfHmlI1UXmkLYk9V/jfqGjO1BfX2gsplHCQ0F9sXLcFZFtJX+SAA== Subject: Re: [PATCH v2 2/3] ARM: amlogic: add JetHub D1/H1 device support To: u-boot-amlogic@groups.io, narmstrong@baylibre.com Cc: u-boot@lists.denx.de References: <20210919155216.4000369-1-adeep@lexina.in> <20210919155216.4000369-3-adeep@lexina.in> <4ef4798b-33a3-76f9-f4a7-83ec7e4b893a@baylibre.com> From: Vyacheslav Message-ID: Date: Mon, 20 Sep 2021 10:06:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <4ef4798b-33a3-76f9-f4a7-83ec7e4b893a@baylibre.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean 20.09.2021 09:43, Neil Armstrong wrote: > Hi, > > On 19/09/2021 17:52, Vyacheslav Bocharov wrote: >> Add support for new home automation devices. > > While applying I had a few warnings: > >> + if (!env_get("serial")) { >> + len = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial, > > ERROR: trailing whitespace > #777: FILE: board/amlogic/jethub-j80/jethub-j80.c:48: > +^I^Ilen = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial, $ > > CHECK: Alignment should match open parenthesis > #778: FILE: board/amlogic/jethub-j80/jethub-j80.c:49: > + len = meson_sm_read_efuse(EFUSE_SN_OFFSET, serial, > + EFUSE_SN_SIZE); > > CHECK: Alignment should match open parenthesis > #785: FILE: board/amlogic/jethub-j80/jethub-j80.c:56: > + len = meson_sm_read_efuse(EFUSE_USID_OFFSET, usid, > + EFUSE_USID_SIZE); I'll double-check everything and resend a new version of the patches. > > This file isn't part of any MAINTAINERS file, either add it to the s400 one or the j80 one. I'll add it to jethub-j80/MAINTAINERS. Thanks!