From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF59BC433EF for ; Sun, 21 Nov 2021 19:15:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F75983433; Sun, 21 Nov 2021 20:15:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cICrodQH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 337D6833D9; Sun, 21 Nov 2021 20:14:58 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D2D4E83457 for ; Sun, 21 Nov 2021 20:14:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id jo22so10941952qvb.13 for ; Sun, 21 Nov 2021 11:14:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/yAVxTXUYU92m97qcdUqlcgqLZz5VWFRe2ICAnLRLNU=; b=cICrodQHn7dxLhYI2NrqDMVAOW51j6jnZKzzE8mr2Lnb7vz8ZuWqiL49JjL18SeeZD 8EA4AhoSlkd1cv8lDvFZJoTmRciag1b4B2Ct7jNgFkFCW1rTFNi58pQmVkKz45o4XdW5 WyzHsJmZBYq7++pQSmz7GJs7eKL9bqN4q5QWT8W2tFoMd0RIkuzoVqMiIBoPFYg7Vlh1 F6mE7mq67m6FP6ewq3BiGr/nODDeNDhgYHsZtcoIJudtjsJovSnrUg+wsmZ47LDdehTv DK6SkzTvXgdfnmXq/Pv4v8Kw7AGk5cnqKgSBpO+UA9/clpIEFgEci3jYjyjHB0eHvjH9 zX/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/yAVxTXUYU92m97qcdUqlcgqLZz5VWFRe2ICAnLRLNU=; b=IafRIiDPIF+cO8qfunLovReqntzVYaJO5ux3sE1PBy7HmgHlBz+MgLbKMGbwqJJoIb 7vk4pOMKbnVeBcvTvWrYv2rAyl2Q08WbbTP3cvndlcr11deOLtmSUqntgD1kzhprqvUM OevLbsKzkAZK4obIpXk8cbTNc985d7NapZBE+SnAWxZwtdhi1mRzeah4rwNGXQDP9KOO aCrq8hxbROITUJl9JBkuxLcW6bl38oFFHlKOquAzEl9y6LLIYw7uoy7+12xeFopvr/Ae 57xzFIYDepMGK1clmrnzxbxkrh4gUkgitucsatKdboIpUPUXCFjbezj+SrxVF9SXVwaC RbRQ== X-Gm-Message-State: AOAM5334yBdq5yWxkrzHQTNVgqX+ezNw52y/XMuEcfT0J0VBjUb2vGF2 bzPplzAj6GSj3gb76rBNHXoK2KU9Xx0= X-Google-Smtp-Source: ABdhPJyd/eNmRidqLXKkzYPuSpDwSKfs5QHmLbdEB6caE4ApYKsf6EpXOTDEJHpFUYj3Ogvfl4ppWw== X-Received: by 2002:a05:6214:caf:: with SMTP id s15mr91354195qvs.33.1637522091626; Sun, 21 Nov 2021 11:14:51 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.googlemail.com with ESMTPSA id t9sm3342492qkp.110.2021.11.21.11.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Nov 2021 11:14:51 -0800 (PST) Subject: Re: [PATCH 1/2] clk: cosmetic: reorder include files To: Patrick Delaunay , u-boot@lists.denx.de Cc: Lukasz Majewski , U-Boot STM32 References: <20211119151203.1.I011e780560149e15eea06471822a1fedfac58766@changeid> From: Sean Anderson Message-ID: Date: Sun, 21 Nov 2021 14:14:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20211119151203.1.I011e780560149e15eea06471822a1fedfac58766@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/19/21 9:12 AM, Patrick Delaunay wrote: > Reorder include files in the U-Boot expected order: > > the common.h header should always be first, > followed by other headers in order, > then headers with directories, > then local files. > > It is a preliminary step for next patch. > > Signed-off-by: Patrick Delaunay > --- > > drivers/clk/clk-composite.c | 6 +++--- > drivers/clk/clk-fixed-factor.c | 9 +++++---- > drivers/clk/clk-gate.c | 9 +++++---- > drivers/clk/clk-mux.c | 5 +++-- > drivers/clk/clk-uclass.c | 2 +- > drivers/clk/clk.c | 2 +- > 6 files changed, 18 insertions(+), 15 deletions(-) > > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c > index bb5351ebc0..12288e10b3 100644 > --- a/drivers/clk/clk-composite.c > +++ b/drivers/clk/clk-composite.c > @@ -5,13 +5,13 @@ > */ > > #include > -#include > -#include > +#include > #include > +#include > +#include > #include > #include > #include > -#include > #include > > #include "clk.h" > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c > index 8d9823bdab..9fcf30fd2e 100644 > --- a/drivers/clk/clk-fixed-factor.c > +++ b/drivers/clk/clk-fixed-factor.c > @@ -6,16 +6,17 @@ > * Copyright (C) 2011 Sascha Hauer, Pengutronix > */ > #include > -#include > +#include > #include > +#include > +#include > #include > #include > #include > -#include > -#include > -#include "clk.h" > #include > > +#include "clk.h" > + > #define UBOOT_DM_CLK_IMX_FIXED_FACTOR "ccf_clk_fixed_factor" > > static ulong clk_factor_recalc_rate(struct clk *clk) > diff --git a/drivers/clk/clk-gate.c b/drivers/clk/clk-gate.c > index 006d3b6629..708499d95a 100644 > --- a/drivers/clk/clk-gate.c > +++ b/drivers/clk/clk-gate.c > @@ -8,17 +8,18 @@ > */ > > #include > -#include > -#include > +#include > #include > +#include > +#include > #include > #include > #include > #include > -#include > -#include "clk.h" > #include > > +#include "clk.h" > + > #define UBOOT_DM_CLK_GATE "clk_gate" > > /** > diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c > index f1becd20d8..fd746f2de3 100644 > --- a/drivers/clk/clk-mux.c > +++ b/drivers/clk/clk-mux.c > @@ -24,14 +24,15 @@ > #include > #include > #include > +#include > +#include > #include > #include > #include > #include > -#include > -#include > #include > #include > + > #include "clk.h" > > #define UBOOT_DM_CLK_CCF_MUX "ccf_clk_mux" > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c > index 493018b33e..f2d2642754 100644 > --- a/drivers/clk/clk-uclass.c > +++ b/drivers/clk/clk-uclass.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -23,7 +24,6 @@ > #include > #include > #include > -#include > > static inline const struct clk_ops *clk_dev_ops(struct udevice *dev) > { > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 1efb7fe9f3..d1a9787071 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -5,13 +5,13 @@ > */ > > #include > +#include > #include > #include > #include > #include > #include > #include > -#include > > int clk_register(struct clk *clk, const char *drv_name, > const char *name, const char *parent_name) > Reviewed-by: Sean Anderson