From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76BB4C00140 for ; Fri, 12 Aug 2022 10:35:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 943728481C; Fri, 12 Aug 2022 12:35:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=cherrycloud.onmicrosoft.com header.i=@cherrycloud.onmicrosoft.com header.b="iKuf8ntB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BB4A84835; Fri, 12 Aug 2022 12:35:44 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2072.outbound.protection.outlook.com [40.107.20.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B19E684801 for ; Fri, 12 Aug 2022 12:35:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=theobroma-systems.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=quentin.schulz@theobroma-systems.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kr2IT1e+tHnGNxY0UMDukIM11j3USc+s2hflaf3sQUWg+Bgny5oEE85YYxtqR74uj52DoWvYRHn6DFrL+tuvuiqapl5Bl6stq/iEM4Xi3dn8OZ0mLl5ymIhm5AGuWqiFneGC8JR1yxiC3cMrVL8p2UU0/ZgEm52UQtEvWclBcxDzLV8UJqTf90hWSvhFAPgfPHVuASKACEiMSL5vFyj0S+vfTqCQBj1e5dxpYvZyV3wFKu52OU/WjiMsRslFgn9aKVz211mtOStHA1+y8zqekkThJf2w3W4gVs1IWmH93yfPuvnW+/E+B+J45JbgMIJ+ER2N5qEXLgJrEP+JhM9xUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QdlIwkdMp31YWj0N3djNWT09LSauBJAyRJ+3Byh1vNo=; b=jzR8cZ8UDTZ5kLlpX5eXd3w2mSf73hK8b1vKJmIcT76z7HYng+Kyx0r36Em/ZMcJDt7j1zGYSqRPti2LVLkTabr+8yq/8ZlQmn+WNoxtpS1PHieHft9ZGb+UHQWk+f/NLHnLn3+R2fVSst1elE3GdlI2oeoSaVgCAaKJbtxQhgWWWQnh+nE6A/b1FB27wWd8TFvpvHNqZRHDy3TtYtePBpAwF1ASlAEvg5+wMGCAtU8t7JK3xSrmZRK3uOznLkrCXL/BkvLRnNCSeZdQfjaG070W5eSRVkOQv82ZwldvtmsWIrJjXeuExaawzVFUFpiSBJv1Pk1O70zCQYmOJ66+7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=theobroma-systems.com; dmarc=pass action=none header.from=theobroma-systems.com; dkim=pass header.d=theobroma-systems.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherrycloud.onmicrosoft.com; s=selector2-cherrycloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QdlIwkdMp31YWj0N3djNWT09LSauBJAyRJ+3Byh1vNo=; b=iKuf8ntBrUTWhqlss6yFmEtPnJDQJxXEuL3dG35Pc3kkxR9iZbo5IXapxlPSDF10DGUCHA5d7XtAeGeFIZqRpJqmy1FHyITJiuoD933p8kUAnES+DX1x9V6gN7pdpeJJuyp8dWRaGgin+kaTnCjNOC8CRB4dDGYXa8qvlnt03P8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=theobroma-systems.com; Received: from PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) by AM0PR04MB6849.eurprd04.prod.outlook.com (2603:10a6:208:181::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.25; Fri, 12 Aug 2022 10:35:40 +0000 Received: from PA4PR04MB9367.eurprd04.prod.outlook.com ([fe80::81a8:1bbf:5e16:9b4e]) by PA4PR04MB9367.eurprd04.prod.outlook.com ([fe80::81a8:1bbf:5e16:9b4e%4]) with mapi id 15.20.5525.010; Fri, 12 Aug 2022 10:35:40 +0000 Message-ID: Date: Fri, 12 Aug 2022 12:35:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/2] rockchip: rk3399: sync spl_boot_devices_tbl and boot_devices node paths Content-Language: en-US To: Xavier Drudis Ferran , Quentin Schulz Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, alpernebiyasak@gmail.com, email2tema@gmail.com, u-boot@lists.denx.de References: <20220715151552.953654-1-foss+uboot@0leil.net> <20220715151552.953654-2-foss+uboot@0leil.net> <20220718211221.GJ1686@begut> From: Quentin Schulz In-Reply-To: <20220718211221.GJ1686@begut> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0401CA0015.eurprd04.prod.outlook.com (2603:10a6:800:4a::25) To PA4PR04MB9367.eurprd04.prod.outlook.com (2603:10a6:102:2aa::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4cadac40-583e-4085-3544-08da7c4e6702 X-MS-TrafficTypeDiagnostic: AM0PR04MB6849:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ar1hY69PbQ1mfUiSPaJZfgxzj6WVzl5wELfGOFpfpvnLT7rRKER2HJU/HDVG7Ua+QShykGcM7jJh0yXYrQEZ9hS9x59nMdTrOWSOko+9L4dY+JEEcjMzvkL98p9CHGF6aFyDeZOQr4WML3/vOzaHq4gBIdFj/8hX4j2gM6A3QxWFSBW2egE+cXImcky7907iNLW4pU+UP0F1MptCHZpvUlrKzAVqJ3TYsDaLgtr/8x6WEtCNc7jO6f2osxrxkFqsZ0bUxqS9Mmbl94OMZOt9Qx+nmaKmmyZT1RaoUobMDyutXvUdpBJBQkGlpQjVEszARJNoCoWZCZldYBoJfY6Xh6SEB3Fdtfipyr5dIn9KSaN+jguUoZrPevNDClkwFBI4LfbQLJiSqBL5LS3v8xvW+FDf+sFEH2PwRNM+GJNkXvudLv//Z7ZL2+YNQtjr6JNTBhatfNovtFyTW8dRVEa78bvL9kHmN4hgsuWTT1hun3xEn4IdV9xi6hhfjXsTSAckv6UYUMmOMaL3uEQ0w2gLJ3FN24BfCVBM1mlIt3KJWVkLa0UnXLuloTkcGgrwg1x0D3D0+/tP3MltH2mJDgjGqaYbOtKj7Gik53msnMcuIp6GsWPCDlDNwLamsP8molfJG63aLyRp2MM5NnGEv5wie8oxY4gAoHs76M0rhsJOOfaji/rw7wD4jZlfpf64yX7+hBMJtDz7mLkuch8G/LxFzhw/msLceudB1pbTozeByEWLNof02fSqZ6/ILPEjvvkB0X39H2VmyVHo27nbEIP7Ih+6kN2/KkI90h0+KkRBAA39RO2UPhuyueR0x49AcAVgaFLC4v3tAqfAk97Bhiixxg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR04MB9367.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(346002)(376002)(39850400004)(136003)(110136005)(6506007)(36756003)(2906002)(66476007)(66946007)(66556008)(8676002)(4326008)(5660300002)(6512007)(2616005)(8936002)(31686004)(44832011)(186003)(41300700001)(53546011)(31696002)(86362001)(83380400001)(6486002)(478600001)(316002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vm84R2JMWXdFTnV2OGZUZEtaQTBja0VJWXA5WDQ1OHVQMFYrdE1xaURVczBk?= =?utf-8?B?SUZLTmNnR2JVeE1rSzJDd0U3K1lWaWp4SFlpL1pjb2E0b0RjTnhCMXFQTTRF?= =?utf-8?B?bGtTQXgxSEdJaTZrZ3VYWXMzWS94bUxadGVjNGgyQ2krNDFURUVaWFFUczUr?= =?utf-8?B?cGNTUFVZZkdDL3U0ck1ldks1WTNhVXRJSXg3Wlh1OGpKb0lrNUJic1FLc2kw?= =?utf-8?B?ODRTbG1rV2JSaWVWbWNFTWlPS0twVUxyUWc1dTJVcC9vWlYvZGRGdDQwSVFJ?= =?utf-8?B?djJYSzdpT3VkSWRqc3JQWWZ3VDNZY2pKVFVFZThablAyakl1S3FDcUF5Vzd1?= =?utf-8?B?N3h6K3pEK2dUQTZDVVNET09VNFhiOC96RUJ1QitUcUwzR09rbXBlaktmYzNW?= =?utf-8?B?anhBdlJlcHpsOHJHZitXaFprY3BjSTJ3VUU5dklvYUlFRFdTMkwySmZ3NklY?= =?utf-8?B?WEZpbEtQM3laODBNSVpUOTE5dzRzOHFZSTNkd2J1TlhVNlArYlE2YXJraUsw?= =?utf-8?B?aFdobFNLZXBIZFBTTGtwbGlpM3dTMW1CMGZOMlBRbUVKUDRIRC8vWjA1Z25T?= =?utf-8?B?eUxGWi8wM241ZDh5bVhFZFk5QU5yUmRKdGNaODJ2OXFNRHN3RVNZUEoxYW5x?= =?utf-8?B?K0FxMzBoSFdnZmIrZm42bmd6QU1INHhWSFdCQkNFNDU5bmhjZDJHNFk1Sld3?= =?utf-8?B?UmIrQjFBYytLS3B3VXR5Q0NFV1hSVXU0VVpJM3ZaZGdVNFF3eE1IK3FZN2sx?= =?utf-8?B?a0FFRGVwVVEvang4ZWRPVGwwVE91eFBsOWNTZ0lwcVVUdmRPOFNVd3VPYXFq?= =?utf-8?B?Tk5sKzFrV1VCM3Q3QVFmSDBrSmwzSFcvR1drQy9YOFZVc01BOG5XTWF3WlNU?= =?utf-8?B?WjJ1UG5TQ3JjOXRJLzUzY2d4enQvTFJIdmhlNEEwdHZxWEhnQXBCczJ4aitW?= =?utf-8?B?UXhFYkVPbTVmc1M1V1ZEeGFCTGs0QlFJZ0tDS1dEN3puR2pkdk9uQ1pwZkJ3?= =?utf-8?B?K3krWjBIZ1BUdEFuTDErKzNxeERWVDcwRGJqcjM1czFObTE4MUlYUHhNRTBr?= =?utf-8?B?dm14cmxqN0FxWmppNlpTU3B0eVJrdmkwajY1djRjR1lCcjRpUTBpVXFuYVE4?= =?utf-8?B?cEl4Nm93TVlaMnRDTU9LTnNHdUVJdEdXTkxCUkRWbGQxa2FHOU1paHcrTlNI?= =?utf-8?B?emlEaXBodU15Mk9zRngyQ0Z1V1Z0THdIdXp1TE5DeGFWQk16NTk2TUhISmFq?= =?utf-8?B?eCswSmc5dFZQV0pLSkdUVEpVdnA2QTN2NmNYa1lPSXNFL01vOWFMU2Z0NWxZ?= =?utf-8?B?R0lyZEZsTXJlekppK2Z6U2hDT0xwYmdxWTMxTy9tU0orL3VZVHdLOFFMWTA4?= =?utf-8?B?QUVsWTNlQzBRQmZyNlRTU2QrNDlrQ0pPZ2VrY2RacXFGd040djVtSFZPakJ2?= =?utf-8?B?NXBxclJWQk5wZ2lFZFNrWlB4VmZBWkJXUXUwRVVEWU5oVDIvNnFYQU92Tm0v?= =?utf-8?B?cGpVR0pXcGQ2Q05yT3ZGYUNsanl3NzlaRzJTMllrU0lFV1pEOTAwdENQYTc2?= =?utf-8?B?eXhNRnZkV3ZkdHJiSGUrN0p2VFBDNm92UlNVUTVtN3N4SGhqblg5bDNGOEhh?= =?utf-8?B?WkU1Vkt2emV0Tm4yTmVEdHE1b2ZhM1NodDFXakx5T3JSTzV6T3ZrOUpBY0ZF?= =?utf-8?B?WFBoSFhOT1luN3dwWUZhNjAzYUppQzlnc1dWeFg4RVZQYWtnUkxUS1crU1NG?= =?utf-8?B?TWFXTWhnR05kekhicUlXRGwySFNpeXNSeWtKTzZJOTA4MTZrSFNJektMVEE4?= =?utf-8?B?RHdaZGw5ZTdaSHhxYkZvTGxiRm1uR2U3MDVCam9wR3hyL0t1YkpiR0ZSMzdG?= =?utf-8?B?eGphNE56V055empXamVuVkcrL0FIMDZIeThDRyt3QlRYUU1FZjg1WThZZUNI?= =?utf-8?B?aE16czBIb1JNZEdERHJqd1h1M0w2bGNKdG9BYlhTdmxYQ0x2UmFNMy9GTkdv?= =?utf-8?B?Y3BYM1BZTUxUMFFmUVV4RkxZVW9Pb3JGQVpObGhQK1UvUzMxTWxEVFFhaGtv?= =?utf-8?B?YUIwTFUzMTZSU2FsL2RLblcwd0doTnR4M3NSamc0dlQ0NktwUzRDdlhGclpp?= =?utf-8?B?Zlhta3RJSmlYVlk5US9scWhFaTA3ZDBERmErY0J4bE5QbHNVYzVaN2pJQkJl?= =?utf-8?Q?9qHHtOmj2OcF6tXBKT4Y/TG8dMS+rC3Nd9LWFNeTLyYD?= X-OriginatorOrg: theobroma-systems.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cadac40-583e-4085-3544-08da7c4e6702 X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9367.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 10:35:40.5243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p5flXVG2VV1bM98Jb50oxeNBhhOinyBKPlrbEsBBFu9bLv19CjpW9ezZJVVBRiWAuZ831UB0p87IWPe7CA2Cox9GLrs1AHZu/hLqcQaca7w8bqCIAnuGCa+5ZRBaZJ6P X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6849 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi all, Gentle ping on the series. Cheers, Quentin On 7/18/22 23:12, Xavier Drudis Ferran wrote: > El Fri, Jul 15, 2022 at 05:15:52PM +0200, Quentin Schulz deia: >> From: Quentin Schulz >> >> While technically not a bug, let's have some consistency in paths >> returned by u-boot,spl-boot-order look-up and the one saved in >> u-boot,spl-boot-device by syncing spl_boot_devices_tbl and boot_devices >> node paths. >> >> Cc: Quentin Schulz >> Signed-off-by: Quentin Schulz >> --- > > > Tested on a Rock-Pi-4B and didn't see any regression. > Tested-by: Xavier Drudis Ferran > Reviewed-by: Xavier Drudis Ferran > > >> arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c >> index f280cb1dbf..7147dc09f5 100644 >> --- a/arch/arm/mach-rockchip/rk3399/rk3399.c >> +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c >> @@ -182,7 +182,7 @@ const char *spl_decode_boot_device(u32 boot_device) >> } spl_boot_devices_tbl[] = { >> { BOOT_DEVICE_MMC2, "/mmc@fe320000" }, >> { BOOT_DEVICE_MMC1, "/mmc@fe330000" }, >> - { BOOT_DEVICE_SPI, "/spi@ff1d0000" }, >> + { BOOT_DEVICE_SPI, "/spi@ff1d0000/flash@0" }, >> }; >> >> for (i = 0; i < ARRAY_SIZE(spl_boot_devices_tbl); ++i) >> -- >> 2.36.1 >>