Re: [PATCH v4 04/11] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr

From: Kever Yang <kever.yang@rock-chips.com>
To: Johan Jonker <jbx6244@gmail.com>,
	dario.binacchi@amarulasolutions.com,
	michael@amarulasolutions.com, sjg@chromium.org
Cc: philipp.tomsich@vrull.eu, u-boot@lists.denx.de,
	yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v4 04/11] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr
Date: Wed, 22 Feb 2023 16:00:21 +0800	[thread overview]
Message-ID: <bb4383e2-957a-6b4b-f6bb-f2953471b166@rock-chips.com> (raw)
In-Reply-To: <1635adbc-f6bf-e2cd-e353-dd236d2947cd@gmail.com>


On 2023/2/18 23:27, Johan Jonker wrote:
> The fdt_addr_t and phys_addr_t size have been decoupled.
> A 32bit CPU can expext 64-bit data from the device tree parser,
> so use dev_read_addr_ptr in the rockchip-saradc.c file.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/adc/rockchip-saradc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
> index 760f8fe6..de9298a2 100644
> --- a/drivers/adc/rockchip-saradc.c
> +++ b/drivers/adc/rockchip-saradc.c
> @@ -145,8 +145,8 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
>   	struct rockchip_saradc_data *data;
>
>   	data = (struct rockchip_saradc_data *)dev_get_driver_data(dev);
> -	priv->regs = (struct rockchip_saradc_regs *)dev_read_addr(dev);
> -	if (priv->regs == (struct rockchip_saradc_regs *)FDT_ADDR_T_NONE) {
> +	priv->regs = (struct rockchip_saradc_regs *)dev_read_addr_ptr(dev);
> +	if (!priv->regs) {
>   		pr_err("Dev: %s - can't get address!", dev->name);
>   		return -ENODATA;
>   	}
> --
> 2.20.1
>