From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8B6C4338F for ; Thu, 12 Aug 2021 22:19:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E5F66104F for ; Thu, 12 Aug 2021 22:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E5F66104F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDDE582D13; Fri, 13 Aug 2021 00:19:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="TjoKmdxd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1DFFD82DAD; Fri, 13 Aug 2021 00:19:25 +0200 (CEST) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9668D8296F for ; Fri, 13 Aug 2021 00:19:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20210812221914epoutp039d1e54bb61da3c89d4b5f6bd5e3d20e9~arx0EgO4s2010720107epoutp03- for ; Thu, 12 Aug 2021 22:19:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20210812221914epoutp039d1e54bb61da3c89d4b5f6bd5e3d20e9~arx0EgO4s2010720107epoutp03- DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1628806754; bh=/kdHTcZWUWKNrGuR8SGKwWdbnp4VSyMk/FrG4ujPGZk=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=TjoKmdxdRAkK/qRenT5mulnaJK+tdyjoq2yel00QOij7PR8z/zH4bjuv/XEQRbT/e 6gW25P7WEbKeIz4YbVziOoaX58RHQ+mQ+lLqHQIeFGDvBf8TJkZrxajCfgR2EwO+04 3rqPvnmpOvy9she0i5XitgPxzHrGDroL2rx3Xuqc= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20210812221914epcas1p2a96081e7660d673bc642e6968c84712f~arxz1BLmX1082310823epcas1p25; Thu, 12 Aug 2021 22:19:14 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.153]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4Gm1Ll12nFz4x9Px; Thu, 12 Aug 2021 22:19:11 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id 86.08.13454.E5E95116; Fri, 13 Aug 2021 07:19:11 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20210812221910epcas1p41c5bea201540a598fe6c09028e0b3c8b~arxwigZFs1764717647epcas1p4G; Thu, 12 Aug 2021 22:19:10 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210812221910epsmtrp1010835529c71dcc2944af650e4e5739a~arxwh5T7h1998619986epsmtrp1A; Thu, 12 Aug 2021 22:19:10 +0000 (GMT) X-AuditID: b6c32a39-185ff7000002348e-e0-61159e5e2957 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id A9.61.32548.E5E95116; Fri, 13 Aug 2021 07:19:10 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20210812221910epsmtip2e786990e85706882b65a271645f83f54~arxwXCq0i2388923889epsmtip2z; Thu, 12 Aug 2021 22:19:10 +0000 (GMT) Subject: Re: [PATCH 17/23] power: Tidy up #undef of CONFIG_DM_PMIC To: Simon Glass , U-Boot Mailing List Cc: Tom Rini From: Jaehoon Chung Message-ID: Date: Fri, 13 Aug 2021 07:19:57 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210808182031.3747270-18-sjg@chromium.org> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNKsWRmVeSWpSXmKPExsWy7bCmvm78PNFEg5bLTBbftmxjtJg6aTO7 xdu9newOzB6zGy6yeLw6sIrd4+ydHYwBzFHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaG uoaWFuZKCnmJuam2Si4+AbpumTlAm5QUyhJzSoFCAYnFxUr6djZF+aUlqQoZ+cUltkqpBSk5 BZYFesWJucWleel6yfm5VoYGBkamQIUJ2RmHny9iLPhoU3Fx9S+mBsafRl2MnBwSAiYSm788 Z+9i5OIQEtjBKNFyCMb5xCjRfLSBCcL5zChxaulcdpiWS4+fsUAkdjFKvN35EqrqPaPEl4dr GEGqhAWcJA5eWMwMYosIBEj8W38PqIODg1lAUWLlPWWQMJuAjsT2b8eZQGxeATuJxdsngi1g EVCVWPvhGiuILSoQKXF+9wIWiBpBiZMzn4DZnAKWEqt33QZbxSwgLnHryXwmCFteYvvbOcwg 90gIPGKX6Jh7jw3iaheJjYcXMkPYwhKvjm+B+kZK4mV/G5RdLbGr+QxUcwejxK1tTUwQCWOJ /UsnM0E8oCmxfpc+RFhRYufvuVBH8Em8+9rDClIiIcAr0dEmBFGiInHp9UsmmFV3n/xnhbA9 JP4efMM+gVFxFpLXZiF5ZxaSd2YhLF7AyLKKUSy1oDg3PbXYsMAUObY3MYJToZblDsbpbz/o HWJk4mA8xCjBwawkwrtTTihRiDclsbIqtSg/vqg0J7X4EKMpMLAnMkuJJucDk3FeSbyhqZGx sbGFiaGZqaGhkjjvt9ivCUIC6YklqdmpqQWpRTB9TBycUg1MNrnCJx+XZ7Yr5NYtahX5tm/W 9ln7Irjf1jxhnS1hp7vt7dFfcWYed+8dkyxR2D9D+97etGUS+774v/t8ac3/N89/ZAuk159V WbN94hpWfQYFjosv97/8aLNl6QsXNcFXLEXHHaNmX1V/d9OoxWjnVt+VP9gUJmT+ztp38Oqe hXtPHWTb6jszbP6kzTkPA7jCtDj8nV537XrrzLjR6k8Dz/rNfy713PnE47Pc/mHVj6nNvbv8 j+5mYmidJHj67dyo85w6qsZ+9/ZO/LOrT+Hr0k9Oe+7ffrGm5JfiYq3F0+YXCVgvdX5zSJG1 +PPUOrHK/15LQwqUs+Rdf4SH21ls+DS39oBZzRo1g5OFB6c6Li5WYinOSDTUYi4qTgQAUnR6 HQ4EAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsWy7bCSvG7cPNFEg63tihbftmxjtJg6aTO7 xdu9newOzB6zGy6yeLw6sIrd4+ydHYwBzFFcNimpOZllqUX6dglcGYefL2Is+GhTcXH1L6YG xp9GXYycHBICJhKXHj9j6WLk4hAS2MEo8WNXNwtEQkri89OpbF2MHEC2sMThw8UQNW8ZJdY/ PsoGUiMs4CRx8MJiZhBbRMBPomX2UkaQemYBRYmV95Qh6ncxStx4sZYdpIZNQEdi+7fjTCA2 r4CdxOLtE8HiLAKqEms/XGMFsUUFIiU+L3jFClEjKHFy5hOwezgFLCVW77rNCGIzC6hL/Jl3 iRnCFpe49WQ+E4QtL7H97RzmCYxCs5C0z0LSMgtJyywkLQsYWVYxSqYWFOem5xYbFhjlpZbr FSfmFpfmpesl5+duYgSHvpbWDsY9qz7oHWJk4mA8xCjBwawkwrtTTihRiDclsbIqtSg/vqg0 J7X4EKM0B4uSOO+FrpPxQgLpiSWp2ampBalFMFkmDk6pBqYqyRrnPEFjqfunXgrzsVjcP1jp 3LffijH1YJIOa1NO8u38nL/aM6bWdW7J0JubNXP76tD40G69d6pvvjEZNfM/esn6IvFMQGnv LZlZz7x32Gd280/b8nnBCz3FqcxTUhxnheeGT34Yzvr2T+nLuFXX1029/ZQrPOLFtxX3kmNY d5Z2Flv3JAbn/WF0Yon4sen0+ocbF6lI1wn/NpnnbdEY3NCZ2tDg477r/JRnc6QmKPyqkdn1 96quwR/jB5vn/j0vLLTnsoHmWWPjyTdkujZ8FLbQv/f2xrYCLZekq1++OZ9u6Tc3ry2ep3U1 4/R3NfOemHUXfHf2GUd2qIh8OflFq+iyo6OdwYL8jlmcCUosxRmJhlrMRcWJAN4/3HXsAgAA X-CMS-MailID: 20210812221910epcas1p41c5bea201540a598fe6c09028e0b3c8b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210808182353epcas1p11236b8ec269df8735fcc5c015def5b50 References: <20210808182031.3747270-1-sjg@chromium.org> <20210808182031.3747270-18-sjg@chromium.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 8/9/21 3:20 AM, Simon Glass wrote: > Add a proper Kconfig option for SPL so we can remove the hack in some of > the board config files. > > This involves adding CONFIG_SPL_DM_PMIC to some of the configs as well > as updateing the Makefile rule for PMIC_RK8XX to exclude SPL. > > Signed-off-by: Simon Glass Removed Lukasz's email address. Reviewed-by: Jaehoon Chung Best Regars, Jaehoon Chung > --- > > configs/imx8mm-cl-iot-gate_defconfig | 1 + > configs/imx8mm_beacon_defconfig | 1 + > configs/imx8mm_evk_defconfig | 1 + > configs/imx8mm_venice_defconfig | 1 + > configs/imx8mn_evk_defconfig | 1 + > configs/verdin-imx8mm_defconfig | 1 + > drivers/power/pmic/Kconfig | 13 +++++++++++++ > drivers/power/pmic/Makefile | 4 ++-- > include/configs/imx8mp_evk.h | 1 - > include/configs/imx8mq_evk.h | 5 ----- > include/configs/imx8mq_phanbell.h | 5 ----- > include/configs/pico-imx8mq.h | 5 ----- > 12 files changed, 21 insertions(+), 18 deletions(-) > > diff --git a/configs/imx8mm-cl-iot-gate_defconfig b/configs/imx8mm-cl-iot-gate_defconfig > index 58eb2d49c9d..41efb0f2454 100644 > --- a/configs/imx8mm-cl-iot-gate_defconfig > +++ b/configs/imx8mm-cl-iot-gate_defconfig > @@ -102,6 +102,7 @@ CONFIG_PINCTRL_IMX8M=y > CONFIG_POWER_DOMAIN=y > CONFIG_IMX8M_POWER_DOMAIN=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_DM_PMIC_BD71837=y > CONFIG_SPL_DM_PMIC_BD71837=y > CONFIG_DM_REGULATOR=y > diff --git a/configs/imx8mm_beacon_defconfig b/configs/imx8mm_beacon_defconfig > index a3f1515f4eb..0d99d04edcb 100644 > --- a/configs/imx8mm_beacon_defconfig > +++ b/configs/imx8mm_beacon_defconfig > @@ -97,6 +97,7 @@ CONFIG_PINCTRL=y > CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8M=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_DM_PMIC_BD71837=y > CONFIG_SPL_DM_PMIC_BD71837=y > CONFIG_DM_REGULATOR=y > diff --git a/configs/imx8mm_evk_defconfig b/configs/imx8mm_evk_defconfig > index e0c0c66f2db..bfd2c7aa6c1 100644 > --- a/configs/imx8mm_evk_defconfig > +++ b/configs/imx8mm_evk_defconfig > @@ -74,6 +74,7 @@ CONFIG_PINCTRL=y > CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8M=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_SPL_DM_PMIC_PCA9450=y > CONFIG_DM_REGULATOR=y > CONFIG_DM_REGULATOR_FIXED=y > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig > index 1a98a8eb6f5..3e09a4a6639 100644 > --- a/configs/imx8mm_venice_defconfig > +++ b/configs/imx8mm_venice_defconfig > @@ -99,6 +99,7 @@ CONFIG_PINCTRL=y > CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8M=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_DM_PMIC_BD71837=y > CONFIG_SPL_DM_PMIC_BD71837=y > CONFIG_DM_PMIC_MP5416=y > diff --git a/configs/imx8mn_evk_defconfig b/configs/imx8mn_evk_defconfig > index 4da37bd0227..ccbd8753b32 100644 > --- a/configs/imx8mn_evk_defconfig > +++ b/configs/imx8mn_evk_defconfig > @@ -75,6 +75,7 @@ CONFIG_PINCTRL=y > CONFIG_SPL_PINCTRL=y > CONFIG_PINCTRL_IMX8M=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_SPL_DM_PMIC_PCA9450=y > CONFIG_DM_REGULATOR=y > CONFIG_DM_REGULATOR_FIXED=y > diff --git a/configs/verdin-imx8mm_defconfig b/configs/verdin-imx8mm_defconfig > index 341d802d611..2d7e9bebeb7 100644 > --- a/configs/verdin-imx8mm_defconfig > +++ b/configs/verdin-imx8mm_defconfig > @@ -91,6 +91,7 @@ CONFIG_PINCTRL_IMX8M=y > CONFIG_POWER_DOMAIN=y > CONFIG_IMX8M_POWER_DOMAIN=y > CONFIG_DM_PMIC=y > +CONFIG_SPL_DM_PMIC=y > CONFIG_SPL_DM_PMIC_PCA9450=y > CONFIG_DM_PMIC_PFUZE100=y > CONFIG_DM_REGULATOR=y > diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig > index fd6648b313e..cb2a6adf84e 100644 > --- a/drivers/power/pmic/Kconfig > +++ b/drivers/power/pmic/Kconfig > @@ -10,6 +10,19 @@ config DM_PMIC > - 'drivers/power/pmic/pmic-uclass.c' > - 'include/power/pmic.h' > > +config SPL_DM_PMIC > + bool "Enable Driver Model for PMIC drivers (UCLASS_PMIC) in SPL" > + depends on SPL_DM > + default y if DM_PMIC > + ---help--- > + This config enables the driver-model PMIC support in SPL. > + UCLASS_PMIC - designed to provide an I/O interface for PMIC devices. > + For the multi-function PMIC devices, this can be used as parent I/O > + device for each IC's interface. Then, each children uses its parent > + for read/write. For detailed description, please refer to the files: > + - 'drivers/power/pmic/pmic-uclass.c' > + - 'include/power/pmic.h' > + > config PMIC_CHILDREN > bool "Allow child devices for PMICs" > depends on DM_PMIC > diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile > index 5d1a97e5f6f..5250eac12f2 100644 > --- a/drivers/power/pmic/Makefile > +++ b/drivers/power/pmic/Makefile > @@ -3,7 +3,7 @@ > # Copyright (C) 2012 Samsung Electronics > # Lukasz Majewski > > -obj-$(CONFIG_DM_PMIC) += pmic-uclass.o > +obj-$(CONFIG_$(SPL_TPL_)DM_PMIC) += pmic-uclass.o > obj-$(CONFIG_DM_PMIC_FAN53555) += fan53555.o > obj-$(CONFIG_$(SPL_)DM_PMIC_DA9063) += da9063.o > obj-$(CONFIG_DM_PMIC_MAX77686) += max77686.o > @@ -20,7 +20,7 @@ obj-$(CONFIG_PMIC_ACT8846) += act8846.o > obj-$(CONFIG_PMIC_AS3722) += as3722.o as3722_gpio.o > obj-$(CONFIG_PMIC_MAX8997) += max8997.o > obj-$(CONFIG_PMIC_PM8916) += pm8916.o > -obj-$(CONFIG_PMIC_RK8XX) += rk8xx.o > +obj-$(CONFIG_$(SPL_TPL_)PMIC_RK8XX) += rk8xx.o > obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o > obj-$(CONFIG_PMIC_TPS65090) += tps65090.o > obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o > diff --git a/include/configs/imx8mp_evk.h b/include/configs/imx8mp_evk.h > index a6569d5566e..29c74a5c63c 100644 > --- a/include/configs/imx8mp_evk.h > +++ b/include/configs/imx8mp_evk.h > @@ -30,7 +30,6 @@ > #define CONFIG_SPL_ABORT_ON_RAW_IMAGE > > #undef CONFIG_DM_MMC > -#undef CONFIG_DM_PMIC > #undef CONFIG_DM_PMIC_PFUZE100 > > #define CONFIG_POWER > diff --git a/include/configs/imx8mq_evk.h b/include/configs/imx8mq_evk.h > index 1008b393217..a0d061fef79 100644 > --- a/include/configs/imx8mq_evk.h > +++ b/include/configs/imx8mq_evk.h > @@ -41,7 +41,6 @@ > #define CONFIG_SPL_ABORT_ON_RAW_IMAGE > > #undef CONFIG_DM_MMC > -#undef CONFIG_DM_PMIC > #undef CONFIG_DM_PMIC_PFUZE100 > > #define CONFIG_SYS_I2C_LEGACY > @@ -144,8 +143,4 @@ > > #define CONFIG_OF_SYSTEM_SETUP > > -#ifndef CONFIG_SPL_BUILD > -#define CONFIG_DM_PMIC > -#endif > - > #endif > diff --git a/include/configs/imx8mq_phanbell.h b/include/configs/imx8mq_phanbell.h > index cf62d21e930..64b4d3162e7 100644 > --- a/include/configs/imx8mq_phanbell.h > +++ b/include/configs/imx8mq_phanbell.h > @@ -38,7 +38,6 @@ > #define CONFIG_SPL_ABORT_ON_RAW_IMAGE > > #undef CONFIG_DM_MMC > -#undef CONFIG_DM_PMIC > #undef CONFIG_DM_PMIC_PFUZE100 > > #define CONFIG_SYS_I2C_LEGACY > @@ -189,8 +188,4 @@ > > #define CONFIG_OF_SYSTEM_SETUP > > -#ifndef CONFIG_SPL_BUILD > -#define CONFIG_DM_PMIC > -#endif > - > #endif > diff --git a/include/configs/pico-imx8mq.h b/include/configs/pico-imx8mq.h > index 66fbea8f90e..f1af4db527d 100644 > --- a/include/configs/pico-imx8mq.h > +++ b/include/configs/pico-imx8mq.h > @@ -38,7 +38,6 @@ > #define CONFIG_SPL_ABORT_ON_RAW_IMAGE > > #undef CONFIG_DM_MMC > -#undef CONFIG_DM_PMIC > > #define CONFIG_SYS_I2C_LEGACY > #define CONFIG_SYS_I2C_MXC_I2C1 /* enable I2C bus 1 */ > @@ -168,10 +167,6 @@ > > #define CONFIG_OF_SYSTEM_SETUP > > -#ifndef CONFIG_SPL_BUILD > -#define CONFIG_DM_PMIC > -#endif > - > #define CONFIG_SYS_BOOTM_LEN SZ_128M > > #endif >