From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47EFAC2B9F4 for ; Mon, 14 Jun 2021 17:29:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589826023E for ; Mon, 14 Jun 2021 17:29:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589826023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A8EC480F03; Mon, 14 Jun 2021 19:29:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="iAs7oooG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C82D580F03; Mon, 14 Jun 2021 19:29:06 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 70FF3800AA for ; Mon, 14 Jun 2021 19:29:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623691741; bh=mEoWNf75zUkmUqQkJK8ec9Uqcm2tSLkOhjwRUEaT7Y0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iAs7oooGakfNZvPVDpc2NMYFg6vuNX3K/YkGyRcZT1j2pqnGm7saakYOywZeIiPEN D6tXDiSMzzSRznm4MuWqJ3YFBVyajao2uHBel5qP9ORg3NtcGgO4ga36T6colVQ0/D FE/2UZqupuVV83UjvRkn/KP9IZ3PhSPaEhEn2jiM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([62.143.247.63]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQe5k-1le3KN1VvK-00Ng2V; Mon, 14 Jun 2021 19:29:01 +0200 Subject: Re: [PATCH v2 1/3] tools: docker: Install a readable kernel for libguestfs-tools To: Alper Nebi Yasak , u-boot@lists.denx.de Cc: AKASHI Takahiro , Bin Meng , Tom Rini , Simon Glass , Daniel Schwierzeck , Marek Vasut References: <20210613140731.16254-1-alpernebiyasak@gmail.com> <20210613140731.16254-2-alpernebiyasak@gmail.com> From: Heinrich Schuchardt Message-ID: Date: Mon, 14 Jun 2021 19:29:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210613140731.16254-2-alpernebiyasak@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:T47ojCxtsFxpeINHR6+Y/8JIP5Z2rAU/hcTuKZAEWat7Z90iMRC nJYlMtFCQZMsrJNlb1UhKOTPKZ7rmOofqfGmPec7JmHzher11wQdQaVEROv11o1cNSbE8mk LB3EtdlU3+r1mRdDLBeQKM1/lJMvGfwePzSHT2AsUIEXjSZsqyPz7f3mxIAlPBKIcolDI0a +jr4pzMo5KtWIMPh+ZGlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:nLZJbjFYHzg=:TFThC+ERFeUK6DmAzp2IN6 Zfi5qwZhJOzYbDkq0XsoyxZm7YDIVtIYKF1Lis6me7nS64TmhjuCCd3GaMVXqGFZae0UC8akJ UrpgLD3fE+PBXW6bY350SpbcTV4mr8dMiSPSXBsieB7r2jxXMoXQYxqsQLTZQBVRJZNirD/r2 4yqgYLLnaBN8jOqpzL95KPObFs+WZ+Yi7SgCMkeDFg/MFgyXPYfa77Dd4W400NpwJeyJLqm4K P0xf9Sn+EtMt6Q0AzWYVLfccvjyEjrZbER3B72ccGL4322gIYdtrBnL8UXClrp29yc4TNIUjl 1r+OXVtS59DdTbTGNEXBfY9637Ix4grrf0RRoGTTuT0wf4ByZCKpgydSS5jBuEpyFEVhTDeiu TmDZXsd/OjmD7UDM+taFGSMOPHyuvLNYocIuviRoD8WDmo9FR3UQZvoAOR77ACPqTBnbCpN/l /5qZ22+ulaljfxM/81yBNBebdVJ8rOgEVe1bn+k4z/vMVraGwAsLBZrydlXsX6YRN9ue0mosr c/fGN1ArXuaj3568qPKpKpL0FQI97pV2n2Sv/EnmOPFhl8qVRqBi7YcJHxnC0LgMyxbuPOgbF Ca/TjEJ2xAroU5et9o7xOhXHyIGsjZ8dljDVr4oXBzNyOcttVSVcKQUpKo5q4S2GsbMRvkGs3 kFeiuuMXmXFVQZCmpGRt7OuxDbPxXqpz8WG+0MGQGlPwLWZXQBY0B7za6wQ1wOSLZwL/Vc9wd ds8uCUW2QVazpxh92DUuNKBb3mkLdPUD8zdNNiic6xOEQ5zfudTGiomi3o8nQt9T9OuwVwiD0 WKmzq6tzWTyv92CvnQL3T1e2/qgKQn9/SVwBFLX2aSghM5dZl0JuwlkbRtgVaSnGQDgALnfPo dzI3wopM8k/86NRhjWWIDIaC4eZiQMYjv9963TwVvpeIDIBOMkgpdRk+SkXIaJLd/8Myt+C1m ccZoItrQ8AvyzMUy9shY/79UhgWEwJBi4eD2sgcSmCqQDmKdGx7Tllc+dkKFZ/s0dK8Us0bnp TdZ2NLdGfSM0MZcPl4RtW7zY+zEqcqbBUpVVwGQyRFhicXWTyJcaB/7S1rNoD+KqcLZ72iXGw um6l27IsDVz/RaQ8MJdeVAgkDmWU2o908vk X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 6/13/21 4:07 PM, Alper Nebi Yasak wrote: > The filesystem and EFI (capsule and secure boot) test setups try to use > guestmount and virt-make-fs respectively to prepare disk images to run > tests on. However, these libguestfs tools need a kernel image and fail > with the following message (revealed in debug/trace mode) if it can't > find one: > > supermin: failed to find a suitable kernel (host_cpu=3Dx86_64). > > I looked for kernels in /boot and modules in /lib/modules. > > If this is a Xen guest, and you only have Xen domU kernels > installed, try installing a fullvirt kernel (only for > supermin use, you shouldn't boot the Xen guest with it). > > This failure then causes these tests to be skipped in CIs. Install a > kernel package in the Docker containers so the CIs can run these > tests with libguestfs tools again (assuming the container is run with > necessary host devices and privileges). As this kernel would be only > used for virtualization, we can use the kernel package specialized for > that. On Ubuntu systems kernel images are not readable by non-root > users, so explicitly add read permissions with chmod as well. > > Signed-off-by: Alper Nebi Yasak > Acked-by: Heinrich Schuchardt > --- > > Changes in v2: > - Add tag "Acked-by: Heinrich Schuchardt " > > tools/docker/Dockerfile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile > index d2f0074ee8a6..563b16639e54 100644 > --- a/tools/docker/Dockerfile > +++ b/tools/docker/Dockerfile > @@ -71,6 +71,7 @@ RUN apt-get update && apt-get install -y \ > libssl-dev \ > libudev-dev \ > libusb-1.0-0-dev \ > + linux-image-kvm \ > lzma-alone \ > lzop \ > mount \ > @@ -99,6 +100,9 @@ RUN apt-get update && apt-get install -y \ > zip \ > && rm -rf /var/lib/apt/lists/* > > +# Make kernels readable for libguestfs tools to work correctly > +RUN chmod +r /boot/vmlinu* /lib/modules/*/vmlinu* || true /lib/modules/4.15.0-1092-kvm# find . -name 'vm*' does not find any file. We don't need '|| true' if you do not refer to non-existent files. Best regards Heinrich > + > # Manually install libmpfr4 for the toolchains > RUN wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3= .1.4-1_amd64.deb && dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.= 4-1_amd64.deb > >