From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
sbabic@denx.de, festevam@gmail.com, trini@konsulko.com,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)
Date: Fri, 10 Jun 2022 19:47:16 +0300 [thread overview]
Message-ID: <caeef0b5-e4cb-6024-3da9-fcd18f0aa1f3@gmail.com> (raw)
In-Reply-To: <d0087be7-ecf4-a615-f828-9e0b3e5eebd3@gmail.com>
On 04/06/2022 14:50, Alper Nebi Yasak wrote:
> On 03/06/2022 10:17, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> There is case that CONFIG_BINMAN is defined, but
>> CONFIG_SPL_BINMAN_SYMBOLS is not defined. In that case, there will be
>> build failure. So use CONFIG_SPL_BINMAN_SYMBOLS to guard the macros, and
>> define CONFIG_SPL_BINMAN_SYMBOLS in binman syms test.
>>
>> Tested-by: Tim Harvey <tharvey@gateworks.com> #imx8m[m,n,p]-venice
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> include/binman_sym.h | 2 +-
>> tools/binman/test/Makefile | 2 +-
>> tools/binman/test/generated/autoconf.h | 3 +++
>> tools/binman/test/u_boot_binman_syms.c | 2 +-
>> tools/binman/test/u_boot_binman_syms_size.c | 2 +-
>> 5 files changed, 7 insertions(+), 4 deletions(-)
>> create mode 100644 tools/binman/test/generated/autoconf.h
>
> Reviewed-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Looks like I have misunderstood things here a bit. CONFIG_BINMAN enables
you to declare and use symbols. CONFIG_SPL/TPL_BINMAN_SYMBOLS declares
certain symbols ('u_boot_any'). The name is a bit misleading, as if it
enables support for using symbols, and that confused me.
I have sent a patch [1] that fixes the build error mentioned here, which
should be used instead of this patch. Please:
- Rebase on top of that series [1]
- Maybe drop config changes in 1/8 and 2/8 (they're now unnecessary)
- Disable CONFIG_SPL/TPL/VPL_BINMAN_SYMBOLS for i.MX8M boards
- Change the if statement to if (IS_ENABLED(CONFIG_BINMAN)) in patch 5/8
- Drop this patch 7/8
Sorry for the confusion.
[1] spl: binman: Fix use of undeclared u_boot_any symbols
https://lore.kernel.org/u-boot/20220610105806.27177-2-alpernebiyasak@gmail.com/
next prev parent reply other threads:[~2022-06-10 16:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 7:17 [PATCH 0/8] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-06-03 6:37 ` Peng Fan
2022-06-03 7:17 ` [PATCH 1/8] spl: Kconfig: not select SPL_RAW_IMAGE_SUPPORT for i.MX8M Peng Fan (OSS)
2022-06-03 12:19 ` Tom Rini
2022-06-04 11:49 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE Peng Fan (OSS)
2022-06-04 11:49 ` Alper Nebi Yasak
2022-06-06 14:07 ` Marek Vasut
2022-06-07 17:26 ` Alper Nebi Yasak
2022-06-07 18:11 ` Marek Vasut
2022-06-07 20:54 ` Alper Nebi Yasak
2022-06-07 22:54 ` Marek Vasut
2022-06-10 15:51 ` Alper Nebi Yasak
2022-06-11 10:09 ` Marek Vasut
2022-06-03 7:17 ` [PATCH 3/8] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 4/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 5/8] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 6/8] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
2022-06-10 16:47 ` Alper Nebi Yasak [this message]
2022-06-11 10:32 ` Peng Fan (OSS)
2022-06-11 12:44 ` Alper Nebi Yasak
2022-06-13 2:34 ` Peng Fan (OSS)
2022-06-14 21:20 ` Alper Nebi Yasak
2022-06-14 23:25 ` Peng Fan
2022-06-18 12:24 ` Alper Nebi Yasak
2022-06-13 2:31 ` Peng Fan (OSS)
2022-06-14 21:01 ` Alper Nebi Yasak
2022-06-03 7:17 ` [PATCH 8/8] imx: imx8mm-icore: migrate to use BINMAN Peng Fan (OSS)
2022-06-04 11:50 ` Alper Nebi Yasak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caeef0b5-e4cb-6024-3da9-fcd18f0aa1f3@gmail.com \
--to=alpernebiyasak@gmail.com \
--cc=festevam@gmail.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).