From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE42AECAAD1 for ; Wed, 31 Aug 2022 08:14:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDC61842E4; Wed, 31 Aug 2022 10:14:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="cPmNz6o4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 02B3D84882; Wed, 31 Aug 2022 10:14:43 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 768F384228 for ; Wed, 31 Aug 2022 10:14:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtjVicPHJ8oWZfmlGH/6yrm5dFWzuwTrz9ptMzc9S6gptgHY4DfBxZRLtE6wvw3MIUkhjtlgVCCcDdG2FKMzj5QLrJZqSV63zQP6YcntdD81LPeFsllPHQLRzflbCbviCljrKP1fttJiEARLay7aODTRL3dk4hscCuhhYHiAYrihumYeNmP9THUSgWtZz2Chk0gyMsKVWpU8RRTxh510uuIZ2nyKdyUrpV84K06o2hj8yhWnZe6sDikrifizVI0/kZ7tP48kAWt/pR4Po9Ksw+EhkoA58GV1zspOBCY2dcZZujfyD3+DHQgdvuFLjAZ+UFP/AagMSzgXzSS9cHskIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3g04NqR2Gye6sKwRJfn4yXAs8zs3e1kbf7B07HPWaR4=; b=DYZ0yCSC/Ggx/yW+4JAENvb7U+37C+Dg8NRlZZtw4wa9Td60YPxQi8mjLdh9PKPcUdbaqkEbuJUMxrKtzqilgfxwiDh8tvHG9SI2RG5NkNaZOCeqalPTTmVaUDGrWTmFrJhzCSNs5a2Q7/VbKFhz4Lp6izO0bTU9W+JFCV3d+f8cO4B+UgZNNACBNpUEyAnSBAzb3ZlyE6lREM2G9v61oQyfGQKjMrPpRbnNRmfWEnrR4ts5gdutTS41ofoksnenPf4Af0ptmZafUWqKf/iagGGK32MfvdtAHg5glJrCaBs8hMLTGuRoUCQGG2zdvtf8HZBX2gtE+tlGQpQb5cPHhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3g04NqR2Gye6sKwRJfn4yXAs8zs3e1kbf7B07HPWaR4=; b=cPmNz6o466e6m3GzfZwlGo4sOtYE9HRNKhmF4f3ZO+eXInaYpBs/HkicEG2n9Kjgw1gEoP11LQPprlWODoqt/9W+Ej8wrpf7CzY7MmMrEH76gto5axC/mfCneNVGZ8DaHIvm3rCVHu8ICWix3kQyieBtYHWH1WSNA3wQsNu6P5s= Received: from MW4PR03CA0085.namprd03.prod.outlook.com (2603:10b6:303:b6::30) by SA0PR12MB4589.namprd12.prod.outlook.com (2603:10b6:806:92::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 31 Aug 2022 08:14:37 +0000 Received: from CO1NAM11FT116.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::9f) by MW4PR03CA0085.outlook.office365.com (2603:10b6:303:b6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15 via Frontend Transport; Wed, 31 Aug 2022 08:14:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT116.mail.protection.outlook.com (10.13.174.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Wed, 31 Aug 2022 08:14:37 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 31 Aug 2022 03:14:35 -0500 Message-ID: Date: Wed, 31 Aug 2022 10:14:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] net: gem: Check rate before setting it up Content-Language: en-US From: Michal Simek To: , CC: Joe Hershberger , Ramon Fried References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2373087-fda7-408d-4012-08da8b28d8a7 X-MS-TrafficTypeDiagnostic: SA0PR12MB4589:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mia95GHn1kTnZl3UK7YLpNBCylJGLTud21tjtgVLn8ovvS3c5NQwjkAvLhSpC1nhP3U6qW4tPajAv9O0prxUt1jthM7vWusxibqFAeesCs8VnDQA4zwC7/SdjQKRNvOu14k9v8rfv3aDvCnf/fHIONMzN+I0acfMWo2zmuJokkNfMRoF4qfcfhqh4R8wQKFFqrOBBqHZUhUU6vC0k8IXrqFKTfkkBxP01CJ4JCVmw6cdP3K0Mw9qFpViPTIpbS/4WvRoRWghLTgRrj1hTRB3+5fsyv1K8AxJkAIGkqs3sVwTByJTVOcoNp9lo7u73wV9QRukapdkYvyn0F8PD7tBgGSOVk6bNWpA4cjm16nmOfhzwen1zI+RT/tXEKBGZpXm5hbQ91leBQjVAUSUiwWGXhWiPiZ0aW9x4cU9gWwJL8S5DP4LwrhlJUwSa2yB7+oqjwsx/IdgY+RV24UDE7hthDm0Dj1MLiemXDyzDsEHeasap2/CO5OOz2EWWblh3E0fZjmid6DAaxISgeCTxxmC4RneKlQclBVaw8pjznrhJd5vbBemiDZbS7q9h5EdCIxzcYxZmT/Giq9MYsSUmMpW8amzrz93fVDZiC+Ivv7uiK16tIHC3Hh7aUnwB1IqXpnekdCQYXEHiZ6JnaykYVVmZJDonlnBNpmVzZqnK9MIUVoJs4sfUiuGOrD0jRVPlKS/t8YyWdpSRewjF+wvL2/r1WSu8cNjoi/64NhDopaI1ESKd7aY6z+pWo3GA/N1GTIRnz0Bi/TWDMtCyEAQHNpMcyvQ9S2i8+xeAIYeZK0xcI+MVO9BFfmIpYvrm2u684GQawM++IoCcoerDWe7++LUxw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(46966006)(36840700001)(40470700004)(81166007)(110136005)(86362001)(8936002)(82310400005)(31696002)(40480700001)(316002)(4326008)(8676002)(70586007)(70206006)(16576012)(54906003)(356005)(36860700001)(426003)(83380400001)(47076005)(26005)(336012)(16526019)(186003)(82740400003)(478600001)(40460700003)(53546011)(41300700001)(2616005)(36756003)(5660300002)(44832011)(6666004)(31686004)(2906002)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 08:14:37.4263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2373087-fda7-408d-4012-08da8b28d8a7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT116.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4589 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/26/22 10:30, Michal Simek wrote: > On QEMU setting rate for fixed clock is failing. That's why check a rate > first if the rate is the same there is no need to ask for the change. > > Signed-off-by: Michal Simek > --- > > drivers/net/zynq_gem.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index 4e8dd4badd6b..61a6c83e335d 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -500,10 +500,13 @@ static int zynq_gem_init(struct udevice *dev) > } > #endif > > - ret = clk_set_rate(&priv->tx_clk, clk_rate); > - if (IS_ERR_VALUE(ret)) { > - dev_err(dev, "failed to set tx clock rate\n"); > - return ret; > + ret = clk_get_rate(&priv->tx_clk); > + if (ret != clk_rate) { > + ret = clk_set_rate(&priv->tx_clk, clk_rate); > + if (IS_ERR_VALUE(ret)) { > + dev_err(dev, "failed to set tx clock rate %ld\n", clk_rate); > + return ret; > + } > } > > ret = clk_enable(&priv->tx_clk); Applied. M