From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF35C433F5 for ; Fri, 1 Oct 2021 06:29:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFC3A61425 for ; Fri, 1 Oct 2021 06:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFC3A61425 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 19F6B8320D; Fri, 1 Oct 2021 08:29:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633069780; bh=wTLaoWminKvn6Ui/0yNVKWw8o3hgy7xUw9YEC07qU00=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fiXLUMHVdFrvwZaz28HY6se4/A9timwRP/VdhvssSc0nki6WoJ4uCDYtvVGiUBKB2 DPWMZvYnKAb+yHkKm9gAoxL8a73t1DwizzlQXNjwC8N8UNGRbk0xApQWy9hVd67B2U tHvYkcQAaOxdY1N8NhHL49bUgnh3+NMpe/oDcz2Z5FWwOk+ZreAzWpYR49g0IJhRcg cnhcInK83Y2w7q9k9/ZGugxt915WS36ewmr1T6wVvg8ONVH+jhxFTtWuACpFyslAaH 36jlRd35ThNFgNn32rC7Gz8X5hQa7jpfxJXpMlVKr+/l9xnlkz9qGpNCeTrrS2Q4eY 82WjvMrCUhOSQ== Received: by phobos.denx.de (Postfix, from userid 109) id D847D832C6; Fri, 1 Oct 2021 08:29:37 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0DD248320D for ; Fri, 1 Oct 2021 08:29:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4HLKvy6tB9zQjcJ; Fri, 1 Oct 2021 08:29:34 +0200 (CEST) Subject: Re: [PATCH u-boot-marvell v3 31/39] tools: kwboot: Fix initializing tty device To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, pali@kernel.org, Chris Packham , Baruch Siach , Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20210924210716.29752-1-kabel@kernel.org> <20210924210716.29752-32-kabel@kernel.org> From: Stefan Roese Message-ID: Date: Fri, 1 Oct 2021 08:29:31 +0200 MIME-Version: 1.0 In-Reply-To: <20210924210716.29752-32-kabel@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B2D2F182D X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 24.09.21 23:07, Marek Behún wrote: > From: Pali Rohár > > Retrieve current terminal settings via tcgetattr(), set to raw mode with > cfmakeraw(), enable receiver via CREAD and ignore modem control lines > via CLOCAL. > > Signed-off-by: Pali Rohár > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwboot.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tools/kwboot.c b/tools/kwboot.c > index d8b950787b..fc83161d70 100644 > --- a/tools/kwboot.c > +++ b/tools/kwboot.c > @@ -648,11 +648,12 @@ kwboot_open_tty(const char *path, int baudrate) > if (fd < 0) > goto out; > > - memset(&tio, 0, sizeof(tio)); > - > - tio.c_iflag = 0; > - tio.c_cflag = CREAD|CLOCAL|CS8; > + rc = tcgetattr(fd, &tio); > + if (rc) > + goto out; > > + cfmakeraw(&tio); > + tio.c_cflag |= CREAD|CLOCAL; > tio.c_cc[VMIN] = 1; > tio.c_cc[VTIME] = 10; > > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de