u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Tero Kristo <kristo@kernel.org>
To: Sean Anderson <seanga2@gmail.com>, u-boot@lists.denx.de
Cc: Lukasz Majewski <lukma@denx.de>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 2/2] clk: cdce9xxx: Add maintainer
Date: Thu, 16 Dec 2021 16:07:22 +0200	[thread overview]
Message-ID: <e19f3ff4-57bd-86cd-01f7-0babc1bdd3a8@kernel.org> (raw)
In-Reply-To: <0ad1a095-2043-d2a1-f0db-190ddbfe5517@gmail.com>

On 16/12/2021 15:57, Sean Anderson wrote:
> 
> On 12/16/21 8:17 AM, Tero Kristo wrote:
>> On 15/12/2021 18:47, Sean Anderson wrote:
>>> This adds an entry in MAINTAINERS for the cdce9xx driver, since it 
>>> was not
>>> added when the driver was submitted. This will help future submitters
>>> figure out who to CC.
>>>
>>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>>> ---
>>> Tero, if you don't want to maintain this I'll resubmit this patch 
>>> with the
>>> orphaned status. Alternatively, perhaps Tom wants to maintain this 
>>> driver since
>>> it is used exclusively by boards he maintains.
>>
>> Well, I am not actively maintaining this, as I am not employed by TI 
>> anymore. :)
>>
>> That said, I don't see how much work there is needed for this driver 
>> anyways, it is very simple, and it can be considered "completed". 
>> That's the reason I didn't initially put any maintainer on it. Marking 
>> it "orphaned" would be a bit too harsh status for it imho, as it is 
>> still used by TI platforms, and it gets actively tested by them.
> 
> Well, the issue that I would like to resolve is that in order to CC you
> I had to look up who did the initial commit, and even then the email was
> wrong (since it had your TI email). So for the benefit of future
> hackers, I would like to record your current email. I suppose your
> Reviewed-By on the first patch will do.

Yes, I understand your point, however adding a maintainer entry for 
every tiny driver is a bit of an overkill. And well, it would also need 
an ack from the subsystem maintainer itself, whether he/she wants to 
share the workload on it or not.

U-boot contains a script called get_maintainer, that can be used to 
fetch the valid maintainer entry for a file. In this case, it reports 
Lukasz, which, imho, is just fine. cdce9xxx is not going to face many 
changes, and if any, those are just generic framework changes/fixes 
which can be handled just fine by the subsystem maintainers.

-Tero

  reply	other threads:[~2021-12-16 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 16:47 [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request Sean Anderson
2021-12-15 16:47 ` [PATCH v2 2/2] clk: cdce9xxx: Add maintainer Sean Anderson
2021-12-16 13:17   ` Tero Kristo
2021-12-16 13:57     ` Sean Anderson
2021-12-16 14:07       ` Tero Kristo [this message]
2021-12-16 14:29         ` Sean Anderson
2021-12-16 13:06 ` [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request Tero Kristo
2022-01-15 20:40 ` (subset) " Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e19f3ff4-57bd-86cd-01f7-0babc1bdd3a8@kernel.org \
    --to=kristo@kernel.org \
    --cc=lukma@denx.de \
    --cc=seanga2@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).