From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FC8C433F5 for ; Mon, 27 Sep 2021 12:01:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D29160FF2 for ; Mon, 27 Sep 2021 12:01:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D29160FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 81B4783223; Mon, 27 Sep 2021 14:01:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="MRH3bC68"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CDBA883238; Mon, 27 Sep 2021 14:01:44 +0200 (CEST) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0444E8320D for ; Mon, 27 Sep 2021 14:01:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mbrugger@suse.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1632744100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ptOvtjg6mIHDMn/qE7PmQPKr23XnBw2nqj+Gn7MJtE=; b=MRH3bC68ER7stMJiLA9MWuZ4tmVarQmzMQ9MUP8p5obOZiI0+A8BxMUB56nAU0WrVSr99O inRLx6sUeY6pFPmg+0vgJ+o5iub/SVL8DE1PKEB9Hox13q128RAVtgZfvpxSw0qr7ySw8U yeDlMJogiSFgtD8s6EcF2AMBe0ug2yk= Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-Rrwo9NXcPjiGs4DEtg1rAQ-1; Mon, 27 Sep 2021 14:01:38 +0200 X-MC-Unique: Rrwo9NXcPjiGs4DEtg1rAQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyM/K83iPmLADh8ThajzIOzmze2GVoA+SELmZOb/K8OMLxxGNabHfxfm+NYdPsx9Vg+WKXo37KyulrdNqHBlb7o05udLum6V2ti9S8idkfeMxRgEK+lt4Xqn8VVpfdf1rXl6JNMuM5WyQWEEfDXpSdzpQKszEwP5QqVAxf4IpjZxgGQD0JHC7QfDgrJsyIZffpQ4etFUZp9IlIwBCHT5yMMQWh3rq/baivjbkM1XGskjSA6qEQUzG5ARwPjzuovf4lbij9pxmlanE5hK4OTYE0mgZ9RySBNY4nBUCehHDL7FX+d6DvVKZsznYfZtBKdhUwfE8qdN9T9l/G2d+4l28A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8ptOvtjg6mIHDMn/qE7PmQPKr23XnBw2nqj+Gn7MJtE=; b=TQZ7vLKcaZAvyacoZuTBB8PRnuHIMUUT2836cSUPB8GbJhc9FKEWE512PAbHD9IPJpaX+bmbOYX6CX/HOcMmYSRsL58LZWD1I2fsdMc+o7lOisTFkki9u0s49EvbcQvH4wzH0wYlUIxKy5Zx5I/Sla4SGGSDP06Z9t+xaoW1nV9kAHapQv9pBkQa1138hUog4VqOoOo5foo/+BHDX1Hg95oU/vc0XoVkpT5V0niKOaFP1ZZxqYsDUWfSvuG6kDaTtxFo1vR2kFNFs/WiMyjnmtFmpFogT+LVV8zJ8/KMDr27mHEeiPr9Nl4x9Y7loJmn3WW2XMfWvW37oOGuk1HULw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: foundries.io; dkim=none (message not signed) header.d=none;foundries.io; dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) by AM7PR04MB6998.eurprd04.prod.outlook.com (2603:10a6:20b:10a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Mon, 27 Sep 2021 12:01:37 +0000 Received: from AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::e9ae:619b:1fe9:46ce]) by AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::e9ae:619b:1fe9:46ce%6]) with mapi id 15.20.4500.019; Mon, 27 Sep 2021 12:01:37 +0000 Message-ID: Date: Mon, 27 Sep 2021 14:01:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH] board: rpi: always set fdt_addr if provided by firmware Content-Language: en-US To: Oleksandr Suvorov , u-boot@lists.denx.de Cc: Ricardo Salveti , "Ivan T. Ivanov" , Marek Szyprowski , Nicolas Saenz Julienne , Peter Robinson References: <20210925102255.21620-1-oleksandr.suvorov@foundries.io> From: Matthias Brugger In-Reply-To: <20210925102255.21620-1-oleksandr.suvorov@foundries.io> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::17) To AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.177] (206.204.146.29) by PR0P264CA0173.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20 via Frontend Transport; Mon, 27 Sep 2021 12:01:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22a33070-eb85-4213-a014-08d981ae8eb9 X-MS-TrafficTypeDiagnostic: AM7PR04MB6998: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pE7fV8EjrVznVQq5haI8MqyiwlVCHhKlRt7yu2jouh7ePi6E2TzwvmuKUhV/Shfi6He0cq7wuBJhny1Wd1yNM+hyjxQdmQMXu8fXs+y7ONpFVlKq/vlyQWZVxslKeLaheH/OjIuEpAMWCx+wtR9+R6gaN7wU6vced4yOIgS3gojTuhXVPB61lBQVk0V93LiYWLOJi6DRj1NJqzYnzEeiWLv7qm6QstloNDuvpE+SNJ01wy9DDEuQK3n6CAyC4gcdkihdn4jv4x4Tyf0G3SP/SkhRcI6LCgZkipYY8DrQWa5DhaIclkM9ib6UlpYoeZHpohM+W6R1EOIMsIR3/jgy8wG8eGr4ux4LmJGL1dCaZH55f37Zaq+/Qqx9ndu+2eNmfUkKG7511IT+nYc7hpc/30nwwdOIi5v+tTYxChvhqp48AnsnImZHK89iIgSnz0kMLGJfP3syms+9GFR7nAfxomdHadX7yLrlqBcnqbwKl0dg5vNAxRlSAgH3MmUX+84+8MrEo6Vi3oXv5fzy0Enk1f6M27zIcNscmIUvvQdSkMBPU0AVZnn7/8gBYM8UjEpkGqaBov6Xoh0yg2noQYSyL9cY1hKCKVqLnZnqw8oKf06yorgaqqVFHn3EBgIVqL/j6dxF5Ngfi3WE39Yvepn7pJ2LwNg6QKn3ygsFCIoBXWmn4zOsGWDKZLNOF2aivipJ7F9qnSZV9IofK/moo+iLCpfzCoe5I+J8mlO06PxuBWox48zt4PaJmznYCFBkgeHSkLtNMVf9jNjzbqCwcZonZfdpBfReQP2BpNXrXK7KsFYbDcm2exUhzePnK5mQ3b+3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5366.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(31696002)(53546011)(4326008)(54906003)(966005)(508600001)(16576012)(31686004)(36756003)(66556008)(956004)(86362001)(66946007)(2616005)(2906002)(66476007)(8936002)(5660300002)(316002)(83380400001)(8676002)(6486002)(38100700002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVBhdXc4aDd5Y3dMemFVN1BpNmRXN3JNYndaeE1wSWUzYko4NllzWGhXb0Va?= =?utf-8?B?VUdvYUM5M0hScGRCUE1yRHJmZ3FOUXhuSU82NkZmY3AvM2x4ZTRLUEtLV1Rt?= =?utf-8?B?cWpyZkJXcmdqdWQzUkYyd2dKdlFnQTNyVjNHR2MydlVOTGxzUVZVbkE5S0pU?= =?utf-8?B?UGl4eUVVVk5DUTR1ZVpsd0ZxOFMwRGtNVldwTFltUUtKL1MzMjU4YjhVOEJq?= =?utf-8?B?ZzhtZUIrYlRGUVM2aFpTKzRWU1UzUFhGWmU2QkdFeVpwUVJRTjZiaUJhNTJy?= =?utf-8?B?UlpsTCtrcTZNcmplM1dsT1ZnUkxKYy9uUWp5aU9xdkg4VmRGZERpb1crM1Q5?= =?utf-8?B?WTFXT3REK3V5eEc0Zmc3Uk1UZDlvOHJFcmN5Nlc1MmFWVXRTNzl3MTVENzJa?= =?utf-8?B?d2hTKzk5dXBTcWFNUjIrKzFkWEpOVlRHT0Q1MkVRaGltZElkSXJYNkFjTm44?= =?utf-8?B?RDV2SEUydFluaVJJMEQwLzN0WjBETHUyRlYvVXl2VXdKa0xDLzVPcnpIYmVO?= =?utf-8?B?VHh1T2ZQSTVqNFBGNkVsdWVHQ1ZjN2xvaEVIZzFZckx3RzZHWC94djZxaGt6?= =?utf-8?B?QVVTQTJCM2Z4VmxrY0lIU3JQRHNaWTA3b3g5YjlEcExtQTFqWmFCd3ZzTS8v?= =?utf-8?B?b2M4Sk5xL1JsREhoRHZUTk5TOHc4RjQzcG5ic2laSU9NdE81UVZTbVM0a2o1?= =?utf-8?B?Z1F6dXBEVDZEZzY5eGFPR2JFOWhiVTgveVJ6RUxjby9IdUNPVDdzbmJUMHJI?= =?utf-8?B?cFFuRWhNTVQ5K1NVRTRtd2UzczFRUlNYWE1FUVFYZzlNR0RlK0Vwa1dWNEV5?= =?utf-8?B?ZVkwc0VHc2praXNLSStBMkcvVFh2NWxFYnhGRWRDWGVQOWNuOGJBeGw5VndY?= =?utf-8?B?WXJielBta3NjNTFIMjJCYXFwbGdCY2tHRzZiT0JNRnZoSVkyby9kRmxldzdz?= =?utf-8?B?dk1IeWZEVHp5ZVdWN2xtSG1qdng0WGJ2NFh1Y1M3Q0M0c2ZXTFY4ZXpoSGFa?= =?utf-8?B?MEJNSmFadzdhQWhVaUZ2UzVsazVLcTZsbmN2V0NrZzJ0RE0vZlEvZ3NSWG42?= =?utf-8?B?SFNwRWgzeE0zb3hSbWNiUmlBdDcrWWROSzl2cTk3eVBrNUNnT1crL1JNUUdw?= =?utf-8?B?N0FwTS9yVmpjQXEvSlVOd2k4QTlJRXZqNE9DOEltNDE2Q0FSaTAwTnZwR1Q5?= =?utf-8?B?MmRQYVB6RU9BWnZkM3lqdWJubWR4emliYUpTckNQUUxIRGliWHE0anBQK3NO?= =?utf-8?B?YjFIVG8xMkpKVXNWQmIveDh3RVcrZTZvL2IxSjM4ZDBMVWZ6ckZWaGtEY0ls?= =?utf-8?B?RzNNNlQ2L0JVS0Iza1k3UkdMVjNJaHZCMFVyR3dwZWs2OTJ2WUpXTUpvYzZJ?= =?utf-8?B?YVZQaWU5SzI3WndxcEx3dlBoM3JHdnBUdk1lak1Tek83bU42NHNGZTBnY1Bw?= =?utf-8?B?eXBLOG1QamIwVEQ3TWRGWHdwSzF3Mkh3d0s3ZXZlK2svbFZlVHFFMUVPY3FZ?= =?utf-8?B?TDc4a2tKUVkzajAwMUI2dGJUek16SURVcjJSY0dSL2dSb00xSUtwbWdocUUv?= =?utf-8?B?WWdQN29XMW1qbzV4WWVLOVJ6NEtNbm9DME5Ta2l2ZHZybUlLYjdwWHpESDJz?= =?utf-8?B?MHNSSG5hbkdONDhJSHlIRnpkcUttNU1DYUxFR0dHRDJ3a2N2RFM2SWFSWlJk?= =?utf-8?B?cTkwb1UyVERnbU5RZ0gwZDlMakIvQ2hSc1VjRFdDc0YyMkVkUWJDQU8zcDJy?= =?utf-8?Q?B40jIwXlAB5VFk3awcMFE4uKjrCa+eXa5GzHLPt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22a33070-eb85-4213-a014-08d981ae8eb9 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 12:01:37.0597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uhkAk/8EYlu/tyOXtxuaFpqMikWi19NblIIGppz8S6BWIhepjl+fjXagZ56X9TBAzU8s4P4UNjFybwS3Gyc3Dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6998 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Oleksandr, Thanks for your patch. There was the very same patch posted already, please follow-up in that thread for any comments from your side: https://patchwork.ozlabs.org/project/uboot/patch/20210512123945.25649-1-m.salvini@koansoftware.com/ Regards, Matthias On 25/09/2021 12:22, Oleksandr Suvorov wrote: > From: Ricardo Salveti > > Otherwise if the env gets saved with an incorrect or different > fdt_addr (by moving sdcard between different rpi versions), it won't > be able to boot with the correct address. > > This allows fdt_addr to always be in sync with what gets set by the > firmware. > > Signed-off-by: Ricardo Salveti > Signed-off-by: Oleksandr Suvorov > --- > > board/raspberrypi/rpi/rpi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > index 372b26b6f2..e12f8c0c31 100644 > --- a/board/raspberrypi/rpi/rpi.c > +++ b/board/raspberrypi/rpi/rpi.c > @@ -318,9 +318,6 @@ static void set_fdtfile(void) > */ > static void set_fdt_addr(void) > { > - if (env_get("fdt_addr")) > - return; > - > if (fdt_magic(fw_dtb_pointer) != FDT_MAGIC) > return; > >