From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E359DC433EF for ; Sat, 18 Dec 2021 13:50:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DA6F8329E; Sat, 18 Dec 2021 14:50:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639835416; bh=W+sABC1UOrRtMful8CxjCgdO6rzLTE6sy+ZkO2GjjUc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bT+Ua3xx7WACsSuH0a3Z/S15LsH7madLXzqyt6+uAMlwDySSAWrtsgJae7uXWenfR yQKdRtNzFKUfoTszaBB+xuhEq9jGzGLZL70jwe7V39+JklmauXFHN48R07kZt4oxbI PXdUPL7juK8FqxXrdewDDdq7cJEv0gV2Df5hxY+sLk0meVY08GfP/sXS+sfwGequ+K qsP4t9aGomoZrjlv2H9yVn269AI+syL4msKIGB0EeSA2Rs++dtB//ENmJqgpjeSgMU XOSE5kVu1hfARDFunyMMP6SRLJ3I5w8Nc8AJ7iqPVg7tEkKodChrZyD8PjixWj5Q+7 B453+gQ1JR54A== Received: by phobos.denx.de (Postfix, from userid 109) id 85E1783383; Sat, 18 Dec 2021 14:50:13 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7E451830AF for ; Sat, 18 Dec 2021 14:50:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4JGS0F0Y4TzQkGd; Sat, 18 Dec 2021 14:50:05 +0100 (CET) Message-ID: Date: Sat, 18 Dec 2021 14:50:00 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] arm: mvebu: Use printf for printing fatal errors Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de References: <20211217173114.4948-1-pali@kernel.org> From: Stefan Roese In-Reply-To: <20211217173114.4948-1-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/17/21 18:31, Pali Rohár wrote: > There is no point to hide/disable fatal errors via debug() macro. > Print fatal errors loudly. > > Signed-off-by: Pali Rohár Applied to u-boot-marvell/next Thanks, Stefan > --- > arch/arm/mach-mvebu/spl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c > index 29a8adc9d79c..609495097585 100644 > --- a/arch/arm/mach-mvebu/spl.c > +++ b/arch/arm/mach-mvebu/spl.c > @@ -313,7 +313,7 @@ void board_init_f(ulong dummy) > > ret = spl_init(); > if (ret) { > - debug("spl_init() failed: %d\n", ret); > + printf("spl_init() failed: %d\n", ret); > hang(); > } > > @@ -329,7 +329,7 @@ void board_init_f(ulong dummy) > /* Setup DDR */ > ret = ddr3_init(); > if (ret) { > - debug("ddr3_init() failed: %d\n", ret); > + printf("ddr3_init() failed: %d\n", ret); > hang(); > } > #endif > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de