From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEBA6C433F5 for ; Fri, 17 Dec 2021 17:40:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0FA0F83267; Fri, 17 Dec 2021 18:40:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="RU1YC1S/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C95483575; Fri, 17 Dec 2021 18:40:42 +0100 (CET) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9830F834E8 for ; Fri, 17 Dec 2021 18:40:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x433.google.com with SMTP id c4so5446754wrd.9 for ; Fri, 17 Dec 2021 09:40:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=87wcgj1wwhiS8621Aye0xioyBZPOX7F5nj3vDjZB0sw=; b=RU1YC1S/05qfRqX+vWjTgmu90daOVQakeNdSMsFbYvuz4BZfAPi5nqh8zI0qLHrJ6A VlS5PMkLHaFkoOCt7suAyik5DTNjqA5XxRC9eyWb5XPDemHtjbgrDIevyzM5bqcNTEps oTlPNiKoUXINI+7Bvr1bcyZUrDdgCSoSlnkEkgNdot/c4mVN+cN8iS4qhC+cCewmVdUF n1bY1Kb46pp+LqdEqJjoyv+hM4YGCzP8dEJgsUzxHROw57qoXcegeIb9wMt8f3ZrRjVl jwkrobAFq2trGxOkkN0O5NYu0hmhkdnpC6YGB00LXrfA6CAdzNMNg7twaJEjmdTRR9kd ZQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=87wcgj1wwhiS8621Aye0xioyBZPOX7F5nj3vDjZB0sw=; b=dFQnZ6sNFBvceqD7+hjlLQML57uN4bk1K0R8VTQUDJKqcvFuKNtv2VxOHF+T7f9dqM SEmRBjXlUc8M88sXnDMMUGLReVmH1d6+mQPHi0DP8KKCe9pSPST/xPb9xrim49BOi7UW xEoZHUFV93hc1OATOUZjBG2poqob086kl5uFXgWgdhX3EbWHEFlmotthmrAS/nnp0Nzv ruXg1W83eKR/XI8p3pndxkpujAEQ3kX1LqMZtWTBYnw04c/eU2IO9s4NPEfZbzbbxmTi jZr8JEBJuEWL/bzsJAyWUtAEsyDHPj0CNBcwMPYRdH5M2RqoOoh9SIjtpDjidTlkh00o aM2g== X-Gm-Message-State: AOAM533fNC/KxOYlTw7/Q2LDIlufTNWcmYvTeOx4a/PNy9GtmH5OqgNG WlfSnOZQUya/otRmwz1v4amd4A== X-Google-Smtp-Source: ABdhPJyVXGhcQ7YxDsm+0lFte9hMIALzDVjSMFhZfgk+VCcLY4znUirxOtbyf9cMcdXlEUxqeM0LHg== X-Received: by 2002:a5d:584c:: with SMTP id i12mr3325198wrf.95.1639762837803; Fri, 17 Dec 2021 09:40:37 -0800 (PST) Received: from ?IPv6:2001:861:44c0:66c0:ef8c:cd8b:375:9d34? ([2001:861:44c0:66c0:ef8c:cd8b:375:9d34]) by smtp.gmail.com with ESMTPSA id p19sm8908162wmq.4.2021.12.17.09.40.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 09:40:37 -0800 (PST) Subject: Re: [PATCH v5 25/29] image: Remove #ifdefs from select_ramdisk() To: Tom Rini , Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Joe Hershberger , Marek Vasut , u-boot-amlogic@groups.io References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-19-sjg@chromium.org> <20211009014130.GL7964@bill-the-cat> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Fri, 17 Dec 2021 18:40:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211009014130.GL7964@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 09/10/2021 03:41, Tom Rini wrote: > On Sat, Sep 25, 2021 at 07:43:38PM -0600, Simon Glass wrote: > >> Use boolean variables to deal with the strange #ifdef logic of this >> function, so we can remove the #ifdefs. >> >> Signed-off-by: Simon Glass > > Applied to u-boot/master, thanks! > This commit causes an abort on Libretech-CC when trying to load an initrd (using libretech-cc_defconfig & gcc-arm-9.2-2019.12): U-Boot 2021.10-00076-gf33a2c1bd0 (Dec 17 2021 - 18:21:08 +0100) libretech-cc Model: Libre Computer AML-S905X-CC SoC: Amlogic Meson GXL (S905X) Revision 21:d (84:2) DRAM: 2 GiB MMC: mmc@72000: 0, mmc@74000: 1 Loading Environment from nowhere... OK In: serial Out: serial Err: serial [BL31]: tee size: 0 [BL31]: tee size: 0 Net: eth0: ethernet@c9410000 Hit any key to stop autoboot: 0 (ROM USB boot) ## Executing script at 08000000 Moving Image from 0x8080000 to 0x8200000, end=a6c0000 "Synchronous Abort" handler, esr 0x96000210 elr: 000000000101bd44 lr : 000000000101bf3c (reloc) elr: 000000007df70d44 lr : 000000007df70f3c x0 : 0000000000000000 x1 : 000000007dfcd6fc x2 : 0000000000000003 x3 : 0000000000000000 x4 : 000000007bf74b20 x5 : 0000000000000030 x6 : 0000000000000000 x7 : 0000000000000002 x8 : 000000007bf441c0 x9 : 0000000000000000 x10: 000000007fffffff x11: 0000000000000000 x12: 000000000a6c0000 x13: 000000000a6bffff x14: 000000007bf49210 x15: 0000000000000020 x16: 000000007df853bc x17: 0000000000000000 x18: 000000007bf52dd0 x19: 000000007dff4e98 x20: 000000007dff4f88 x21: 000000007dff4f90 x22: 0000000000000016 x23: 000000007bf74b20 x24: 0000000000000000 x25: 000000007bf74b48 x26: 0000000000000000 x27: 0000000000000000 x28: 000000007bf74b70 x29: 000000007bf481f0 Code: a9017fff 97fffff5 a8c27bfd d65f03c0 (b9400002) Resetting CPU ... Abort is probably in genimg_get_format() Reverting on master fixes the issue. Neil