From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Patrick DELAUNAY <patrick.delaunay@foss.st.com>, <u-boot@lists.denx.de>
Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
Vikas Manocha <vikas.manocha@st.com>
Subject: Re: [PATCH v2 2/7] configs: stm32f769-disco: Fix SPL boot
Date: Mon, 26 Sep 2022 17:56:23 +0200 [thread overview]
Message-ID: <f28636f0-5ce9-c70f-4fc8-a23abd5029cf@foss.st.com> (raw)
In-Reply-To: <c0c00ac0-f58e-436e-8cf1-be98213bf2d7@foss.st.com>
On 9/26/22 14:57, Patrick DELAUNAY wrote:
> Hi,
>
> On 9/20/22 18:04, Patrice Chotard wrote:
>> Commit 'b4b9a00ed593 ("Convert CONFIG_SYS_SPL_ARGS_ADDR to Kconfig")'
>> replaces CONFIG_SYS_FDT_BASE by CONFIG_SYS_SPL_ARGS_ADDR.
>> As CONFIG_SYS_SPL_ARGS_ADDR enables additional code when enable, it
>> increases SPL size over the initial 0x8000 limit.
>> Increase the SPL size to 0x9000 to fix SPL boot.
>> Set SPL_SIZE_LIMIT to 0x9000 to avoid similar issue in the future.
>>
>> Fixes 'b4b9a00ed593 ("Convert CONFIG_SYS_SPL_ARGS_ADDR to Kconfig")'
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>> (no changes since v1)
>>
>> configs/stm32f769-disco_spl_defconfig | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/stm32f769-disco_spl_defconfig b/configs/stm32f769-disco_spl_defconfig
>> index 19d2c24abb..b56d88f9f6 100644
>> --- a/configs/stm32f769-disco_spl_defconfig
>> +++ b/configs/stm32f769-disco_spl_defconfig
>> @@ -1,6 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_STM32=y
>> -CONFIG_SYS_TEXT_BASE=0x08008000
>> +CONFIG_SYS_TEXT_BASE=0x08009000
>> CONFIG_SYS_MALLOC_LEN=0x100000
>> CONFIG_SYS_MALLOC_F_LEN=0xE00
>> CONFIG_SPL_GPIO=y
>> @@ -13,10 +13,11 @@ CONFIG_SPL_TEXT_BASE=0x8000000
>> CONFIG_SYS_PROMPT="U-Boot > "
>> CONFIG_SPL_SERIAL=y
>> CONFIG_SPL_DRIVERS_MISC=y
>> +CONFIG_SPL_SIZE_LIMIT=0x9000
>> CONFIG_STM32F7=y
>> CONFIG_TARGET_STM32F746_DISCO=y
>> CONFIG_SPL=y
>> -CONFIG_SYS_LOAD_ADDR=0x8008000
>> +CONFIG_SYS_LOAD_ADDR=0x8009000
>> CONFIG_BUILD_TARGET="u-boot-with-spl.bin"
>> CONFIG_DISTRO_DEFAULTS=y
>> CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>> @@ -28,7 +29,7 @@ CONFIG_AUTOBOOT_STOP_STR=" "
>> CONFIG_USE_BOOTARGS=y
>> CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk consoleblank=0 ignore_loglevel"
>> # CONFIG_DISPLAY_CPUINFO is not set
>> -CONFIG_SPL_PAD_TO=0x8000
>> +CONFIG_SPL_PAD_TO=0x9000
>> CONFIG_SPL_NO_BSS_LIMIT=y
>> CONFIG_SPL_BOARD_INIT=y
>> CONFIG_SPL_SYS_MALLOC_SIMPLE=y
>
>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>
> Thanks
> Patrick
>
Applied to u-boot-stm32/next
Thanks
next prev parent reply other threads:[~2022-09-26 15:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 16:04 [PATCH v2 0/7] SPL fixes for STM32F7 MCUs Patrice Chotard
2022-09-20 16:04 ` [PATCH v2 1/7] configs: stm32f746-disco: Fix SPL boot Patrice Chotard
2022-09-26 12:50 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 16:04 ` [PATCH v2 2/7] configs: stm32f769-disco: " Patrice Chotard
2022-09-26 12:57 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD [this message]
2022-09-20 16:04 ` [PATCH v2 3/7] configs: stm32746g-eval: " Patrice Chotard
2022-09-26 12:57 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 16:04 ` [PATCH v2 4/7] configs: stm32f746-disco: Fix CONFIG_SYS_SPL_ARGS_ADDR Patrice Chotard
2022-09-26 12:58 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 16:04 ` [PATCH v2 5/7] configs: stm32746g-eval: " Patrice Chotard
2022-09-26 12:58 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 16:04 ` [PATCH v2 6/7] config: stm32f769-disco: Fix internal flash size Patrice Chotard
2022-09-26 13:05 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 16:04 ` [PATCH v2 7/7] configs: stm32f746-disco: Remove CONFIG_SYS_UBOOT_START flag Patrice Chotard
2022-09-26 13:02 ` Patrick DELAUNAY
2022-09-26 15:56 ` Patrice CHOTARD
2022-09-20 21:28 ` [PATCH v2 0/7] SPL fixes for STM32F7 MCUs Waldemar Brodkorb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f28636f0-5ce9-c70f-4fc8-a23abd5029cf@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
--cc=vikas.manocha@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).