Re: [PATCH v4 0/7] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script

From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: Simon Glass <sjg@chromium.org>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Cc: "Roger Quadros" <rogerq@ti.com>,
	"Alper Nebi Yasak" <alpernebiyasak@gmail.com>,
	"Peter Geis" <pgwipeout@gmail.com>,
	"Philippe Reynes" <philippe.reynes@softathome.com>,
	"Ivan Mikhaylov" <ivan.mikhaylov@siemens.com>,
	"Tom Rini" <trini@konsulko.com>, "huang lin" <hl@rock-chips.com>,
	"Jeffy Chen" <jeffy.chen@rock-chips.com>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	"Adam Ford" <aford173@gmail.com>,
	"Alifer Moraes" <alifer.wsdm@gmail.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Andreas Geisreiter" <ageisreiter@dh-electronics.de>,
	"Andrew F. Davis" <afd@ti.com>, "Angus Ainslie" <angus@akkea.ca>,
	"Ariel D'Alessandro" <ariel.dalessandro@collabora.com>,
	"Aswath Govindraju" <a-govindraju@ti.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Chee Hong Ang" <chee.hong.ang@intel.com>,
	"Chee Tien Fong" <tien.fong.chee@intel.com>,
	"Chia-Wei, Wang" <chiawei_wang@aspeedtech.com>,
	"Chin-Liang See" <clsee@altera.com>,
	"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Frieder Schrempf" <frieder.schrempf@kontron.de>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Ilko Iliev" <iliev@ronetix.at>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Le Jin" <le.jin@siemens.com>,
	"Ley Foon Tan" <ley.foon.tan@intel.com>,
	"Luca Ceresoli" <luca@lucaceresoli.net>,
	"Lukasz Majewski" <lukma@denx.de>,
	"Manoj Sai" <abbaraju.manojsai@amarulasolutions.com>,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Marco Franchi" <marcofrk@gmail.com>,
	"Marek Behún" <kabel@kernel.org>, "Marek Vasut" <marex@denx.de>,
	"Matteo Lisi" <matteo.lisi@engicam.com>,
	"Michael Trimarchi" <michael@amarulasolutions.com>,
	"Michael Walle" <michael@walle.cc>,
	"Michal Simek" <michal.simek@amd.com>,
	"Mingkai Hu" <mingkai.hu@nxp.com>,
	"Olaf Mandel" <o.mandel@menlosystems.com>,
	"Oliver Graute" <oliver.graute@kococonnector.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Paweł Anikiel" <pan@semihalf.com>, "Peng Fan" <peng.fan@nxp.com>,
	"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
	"Rajesh Bhagat" <rajesh.bhagat@nxp.com>,
	"Siew Chin Lim" <elly.siew.chin.lim@intel.com>,
	"Stefan Herbrechtsmeier" <stefan.herbrechtsmeier@weidmueller.com>,
	"Teresa Remmet" <t.remmet@phytec.de>,
	"Tim Harvey" <tharvey@gateworks.com>,
	"Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>,
	kernel@puri.sm, u-boot@dh-electronics.com,
	uboot-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v4 0/7] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script
Date: Wed, 7 Dec 2022 11:19:46 +0100	[thread overview]
Message-ID: <f9bb49c1-df40-a4e8-9250-65aebfb826c4@theobroma-systems.com> (raw)
In-Reply-To: <CAPnjgZ0U=pwxYiPNJddn9Zs_UXrChuvoc7wDVJ_XyU2Z52pB_Q@mail.gmail.com>

Hi Simon,

On 12/7/22 02:08, Simon Glass wrote:
> Hi Kevar,
> 
> On Mon, 7 Nov 2022 at 11:40, Simon Glass <sjg@chromium.org> wrote:
>>
>> At present rockchip 64-bit boards make use of a FIT-generator script
>> written in Python. The script supports splitting an ELF file into several
>> 'loadable' nodes in the FIT. Binman does not current support this feature.
>>
>> This series adds binman support for ELF splitting. This works by adding a
>> new 'fit,operation' property to the FIT subnodes, allowing this new way of
>> generating nodes.
>>
>> Some other fixes and improvements are needed along the way.
>>
>> A new, common binman description is added for 64-bit boards which includes
>> the required u-boot.itb file.
>>
>> The existing script is removed, so that only a few zynq boards are now
>> using a SPL_FIT_GENERATOR script:
>>
>>     avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0
>>     xilinx_zynqmp_virt
>>
>> Migration of those is hopefully in progress.
>>
>> Note however that tools/k3_fit_atf.sh remains, used by a few boards that
>> enable CONFIG_TI_SECURE_DEVICE so this series is copied there too:
>>
>>      am335x_hs_evm
>>      am335x_hs_evm_uart
>>      am43xx_hs_evm
>>      am57xx_hs_evm
>>      am57xx_hs_evm_usb
>>      am65x_hs_evm_a53
>>      am65x_hs_evm_r5
>>      dra7xx_hs_evm
>>      dra7xx_hs_evm_usb
>>      j721e_hs_evm_a72
>>      j721e_hs_evm_r5
>>      k2e_hs_evm
>>      k2g_hs_evm
>>      k2hk_hs_evm
>>      k2l_hs_evm
>>
>> Ivan Mikhaylov has sent a patch to help with these, but I need to take a
>> look at the testing side. In any case they should really be using binman
>> for the image generation.
>>
>> Changes in v4:
>> - Add new patch to disable USE_SPL_FIT_GENERATOR by default
>>
>> Changes in v3:
>> - Add an offset to the FIT description
>> - Add support for writing sections in binman
>> - Rebase to master
>>
>> Changes in v2:
>> - Rename op-tee to tee-os
>> - Drop use of .itb2
>> - Drop patches previously applied
>> - Add various suggestions from Alper Nebi Yasak
>> - Add patches to refactor binman's FIT support
>>
>> Simon Glass (7):
>>    binman: Allow writing section contents to a file
>>    rockchip: evb-rk3288: Drop raw-image support
>>    rockchip: Include binman script in 64-bit boards
>>    rockchip: Support building the all output files in binman
>>    rockchip: Convert all boards to use binman
>>    rockchip: Drop the FIT generator script
>>    treewide: Disable USE_SPL_FIT_GENERATOR by default
>>
> 
> Can this one please be applied in time for the release?
> 

You still have review/questions left unanswered/unaddressed:
https://lore.kernel.org/u-boot/a29f8d62-c7be-60e7-8a79-b52f589a93e7@linaro.org/
https://lore.kernel.org/u-boot/67717a66-13d5-a72c-a34c-fac191a238ad@theobroma-systems.com/
https://lore.kernel.org/u-boot/67717a66-13d5-a72c-a34c-fac191a238ad@theobroma-systems.com/

Cheers,
Quentin