util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] mount: Do not call mnt_pretty_path() on net file systems.
Date: Tue, 19 Feb 2019 16:50:26 +0100	[thread overview]
Message-ID: <05bb1dd3-016d-9166-3e73-29bbc307907c@suse.cz> (raw)
In-Reply-To: <20190206105847.gumbcel24gvc5zmn@ws.net.home>

Dne 06. 02. 19 v 11:58 Karel Zak napsal(a):
> On Wed, Feb 06, 2019 at 12:07:54AM +0100, Stanislav Brabec wrote:
>>  sys-utils/mount.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks!
> 
> Please, send also updates for the mnt_fstype_is_pseudofs().
> 

I started to inspect file systems available in SUSE, and I found that there is an another category of file systems: File systems that have a source (so they are not pseudo file systems), but information provided by the kernel is not sufficient to check whether a particular source is already mounted.

Some of them are completely undetectable (both source and FS type provide generic information only), some are detectable by source, but not by FS type, some are detectable by FS type, but source match cannot be used.

For these file systems, mount(8) cannot guarantee that the correct volume is mounted. Only some guesses are possible.

Maybe it should warn about it, or it should refuse such file systems in the fstab.


Examples of undetectable FUSE file systems:

xdg-document-portal is completely undetectable; it can be ran once per UID
/dev/fuse on /run/user/10027/doc type fuse (rw,nosuid,nodev,relatime,user_id=10027,group_id=100)
376 536 0:65 / /run/user/10027/doc rw,nosuid,nodev,relatime - fuse /dev/fuse rw,user_id=10027,group_id=100

curlftpfs undetectable by type, detectable by source
curlftpfs#ftp://ftp.suse.com/ on /home/sbrabec/T type fuse (rw,nosuid,nodev,relatime,user_id=10027,group_id=100)
544 510 0:47 / /sys/fs/fuse/connections rw,relatime master:282 - fusectl fusectl rw

encfs:
can be detected by type, source cannot be detected
encfs on /local/Encrypted type fuse.encfs (rw,nosuid,nodev,relatime,user_id=10027,group_id=100,default_permissions)
397 540 0:84 / /local/Encrypted rw,nosuid,nodev,relatime - fuse.encfs encfs rw,user_id=10027,group_id=100,default_permissions

gvfs:
can be detected by type, source cannot be detected
gvfsd-fuse on /run/user/10027/gvfs type fuse.gvfsd-fuse (rw,nosuid,nodev,relatime,user_id=10027,group_id=100)
562 536 0:48 / /run/user/10027/gvfs rw,nosuid,nodev,relatime master:291 - fuse.gvfsd-fuse gvfsd-fuse rw,user_id=10027,group_id=100

archivemount:
can be detected by type, source cannot be detected
archivemount on /home/sbrabec/T type fuse.archivemount (rw,nosuid,nodev,relatime,user_id=10027,group_id=100)
376 539 0:65 / /home/sbrabec/T rw,nosuid,nodev,relatime - fuse.archivemount archivemount rw,user_id=10027,group_id=100


-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Křižíkova 148/34 (Corso IIa)                    tel: +420 284 084 060
186 00 Praha 8-Karlín                          fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

  reply	other threads:[~2019-02-19 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 22:57 [PATCH] mount: Do not call mnt_pretty_path() on net file systems Stanislav Brabec
2019-02-05 23:07 ` Stanislav Brabec
2019-02-06 10:58   ` Karel Zak
2019-02-19 15:50     ` Stanislav Brabec [this message]
2019-02-22 10:26       ` Karel Zak
2019-02-22 18:39         ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05bb1dd3-016d-9166-3e73-29bbc307907c@suse.cz \
    --to=sbrabec@suse.cz \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).