util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Stanislav Brabec <sbrabec@suse.cz>, Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH v2] agetty: don't put the VC into canonical mode
Date: Fri, 19 Oct 2018 15:48:40 +0200	[thread overview]
Message-ID: <0d9d07b6b3f45e069fefa4e9e008822a3aa7a135.camel@v3.sk> (raw)
In-Reply-To: <cc6f95bb-6dc6-cb34-fb7e-505da29e61f1@suse.cz>

On Fri, 2018-10-19 at 15:08 +0200, Stanislav Brabec wrote:
> Dne 19. 10. 18 v 8:09 Lubomir Rintel napsal(a):
> > On Tue, 2018-10-16 at 09:40 +0200, Karel Zak wrote:
> > > On Tue, Oct 16, 2018 at 08:41:49AM +0200, Lubomir Rintel wrote:
> > > > Seems like zero lflags do the job just fine on a Linux VT. Reset it
> > > > to
> > > > canonical mode before running login.
> > > 
> > > What about Del/Backspace keys when user is typing login name? :-)
> > 
> > They seem to work the same as they used to?
> > 
> > From Stanislav's message I notice that there's supposed to be some
> > problem with them -- I'm not seeing that. Either the patch does
> > something different or I'm not looking at the right thing.
> > 
> > (I haven't looked at Stanislav's patch -- but I surely intend to give
> > it a try.)
> I am writing about non-canonical mode.

Yes, so am I.

> It was partially used in past.
> 
> Now agetty uses canonical mode. It handles Backspace by itself, but it
> makes impossible to implement "stop reloads when at least one character
> is entered". So we will have to switch to a non-canonical mode.

I've submitted a patch that does that, and my understanding is that so
did you (I didn't yet take a look -- sorry. I definitely intend to).

I just remarked that I haven't noticed a problem with character erase.
I have no idea why.

Lubo


  reply	other threads:[~2018-10-19 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  6:41 [PATCH v2] agetty: don't put the VC into canonical mode Lubomir Rintel
2018-10-16  7:40 ` Karel Zak
2018-10-18 19:25   ` Stanislav Brabec
2018-10-19  7:53     ` Karel Zak
2018-10-19  6:09   ` Lubomir Rintel
2018-10-19 13:08     ` Stanislav Brabec
2018-10-19 13:48       ` Lubomir Rintel [this message]
2018-10-19 20:08         ` Stanislav Brabec
2018-10-22  9:23           ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d9d07b6b3f45e069fefa4e9e008822a3aa7a135.camel@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=kzak@redhat.com \
    --cc=sbrabec@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).