From: Wang Shilong <wangshilong1991@gmail.com>
To: util-linux@vger.kernel.org
Cc: Wang Shilong <wshilong@ddn.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: [PATCH v2] fstrim: document kernel return minlen explicitly
Date: Tue, 23 Apr 2019 23:58:28 +0900 [thread overview]
Message-ID: <1556031508-18850-1-git-send-email-wshilong1991@gmail.com> (raw)
From: Wang Shilong <wshilong@ddn.com>
Filesystem will modify @minlen according to its
block size etc, and will return actual unit
to userspace, document it into manpage.
Cc: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Wang Shilong <wshilong@ddn.com>
---
v1->v2:
better explain as darrick suggestion..
---
sys-utils/fstrim.8 | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/sys-utils/fstrim.8 b/sys-utils/fstrim.8
index f7e7aa9ef..c6ecca706 100644
--- a/sys-utils/fstrim.8
+++ b/sys-utils/fstrim.8
@@ -76,10 +76,11 @@ the end of the filesystem.
.IP "\fB\-m, \-\-minimum\fP \fIminimum-size\fP"
Minimum contiguous free range to discard, in bytes. (This value is internally
rounded up to a multiple of the filesystem block size.) Free ranges smaller
-than this will be ignored. By increasing this value, the fstrim operation
-will complete more quickly for filesystems with badly fragmented freespace,
-although not all blocks will be discarded. The default value is zero,
-discarding every free block.
+than this will be ignored and fstrim will adjust the minimum if it's smaller than
+the device's minimum, and report that (fstrim_range.minlen) back to userspace.
+By increasing this value, the fstrim operation will complete more quickly for
+filesystems with badly fragmented freespace, although not all blocks will be
+discarded. The default value is zero, discarding every free block.
.IP "\fB\-v, \-\-verbose\fP"
Verbose execution. With this option
.B fstrim
--
2.21.0
next reply other threads:[~2019-04-23 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:58 Wang Shilong [this message]
2019-04-23 19:27 ` [PATCH v2] fstrim: document kernel return minlen explicitly Darrick J. Wong
2019-04-24 9:34 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556031508-18850-1-git-send-email-wshilong1991@gmail.com \
--to=wangshilong1991@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=util-linux@vger.kernel.org \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).