util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: ready for v2.32 ?
Date: Sat, 10 Feb 2018 19:13:44 +0100	[thread overview]
Message-ID: <20180210181344.dtskxnhpla4btvrr@var.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <20180207094731.cvuyp3txmcom3u3u@ws.net.home>

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hello,

Here is a small build fix for the case where USE_PTY is not defined.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 410 bytes --]

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index afd75a1f1..9c6267f25 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -1417,8 +1417,10 @@ int su_main(int argc, char **argv, int mode)
 		setsid();
 	}
 
+#ifdef USE_PTY
 	if (su->pty)
 		pty_init_slave(su);
+#endif
 
 	/* Set environment after pam_open_session, which may put KRB5CCNAME
 	   into the pam_env, etc.  */

  reply	other threads:[~2018-02-10 18:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07  9:47 ready for v2.32 ? Karel Zak
2018-02-10 18:13 ` Samuel Thibault [this message]
2018-02-12 11:10   ` Karel Zak
2018-02-26 20:02 ` Ruediger Meier
2018-02-25 23:55 Thomas Deutschmann
2018-02-26 21:16 Ruediger Meier
2018-02-26 22:20 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180210181344.dtskxnhpla4btvrr@var.youpi.perso.aquilenet.fr \
    --to=samuel.thibault@ens-lyon.org \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).