util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: ready for v2.32 ?
@ 2018-02-26 21:16 Ruediger Meier
  2018-02-26 22:20 ` Karel Zak
  0 siblings, 1 reply; 10+ messages in thread
From: Ruediger Meier @ 2018-02-26 21:16 UTC (permalink / raw)
  To: util-linux

There is one test failure on big endian (ppc/ppc64)

[...]
  blkid: superblocks probing: [37] mpool               ... FAILED 
(blkid/low-probe-mpool)
[...]
---------------------------------------------------------------------
  1 tests of 199 FAILED
---------------------------------------------------------------------

--- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool       
2018-02-26 20:14:24.265703542 +0000
+++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool 
2018-02-26 
20:38:14.300022547 +0000
@@ -1,6 +0,0 @@
-ID_FS_LABEL=mp1
-ID_FS_LABEL_ENC=mp1
-ID_FS_TYPE=mpool
-ID_FS_USAGE=filesystem
-ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
-ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ready for v2.32 ?
  2018-02-26 21:16 ready for v2.32 ? Ruediger Meier
@ 2018-02-26 22:20 ` Karel Zak
  2018-02-26 22:44   ` [EXT] " John Groves (jgroves)
  0 siblings, 1 reply; 10+ messages in thread
From: Karel Zak @ 2018-02-26 22:20 UTC (permalink / raw)
  To: Ruediger Meier, John Groves; +Cc: util-linux

On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
> 
> [...]
>   blkid: superblocks probing: [37] mpool               ... FAILED 
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
>   1 tests of 199 FAILED
> ---------------------------------------------------------------------

I guess we have to use le32_to_cpu() osd->osb_cksum1. 

John, is mpool little endian, big endian, or both?

    Karel

> 
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool       
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool 
> 2018-02-26 
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXT] Re: ready for v2.32 ?
  2018-02-26 22:20 ` Karel Zak
@ 2018-02-26 22:44   ` John Groves (jgroves)
  2018-02-26 22:50     ` Karel Zak
  0 siblings, 1 reply; 10+ messages in thread
From: John Groves (jgroves) @ 2018-02-26 22:44 UTC (permalink / raw)
  To: Karel Zak, Ruediger Meier; +Cc: util-linux

________________________________________
From: Karel Zak <kzak@redhat.com>
Sent: Monday, February 26, 2018 4:20 PM
To: Ruediger Meier; John Groves (jgroves)
Cc: util-linux@vger.kernel.org
Subject: [EXT] Re: ready for v2.32 ?

On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
>
> [...]
>   blkid: superblocks probing: [37] mpool               ... FAILED
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
>   1 tests of 199 FAILED
> ---------------------------------------------------------------------

I guess we have to use le32_to_cpu() osd->osb_cksum1.

John, is mpool little endian, big endian, or both?

    Karel

>
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool
> 2018-02-26
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Doh! Mpool stores its metadata as little endian, and rigorously uses le32_to_cpu and the like to move on-media structures to & from memory.

le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.

Thanks!
John

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXT] Re: ready for v2.32 ?
  2018-02-26 22:44   ` [EXT] " John Groves (jgroves)
@ 2018-02-26 22:50     ` Karel Zak
  2018-02-26 23:01       ` Ruediger Meier
  0 siblings, 1 reply; 10+ messages in thread
From: Karel Zak @ 2018-02-26 22:50 UTC (permalink / raw)
  To: John Groves (jgroves); +Cc: Ruediger Meier, util-linux

On Mon, Feb 26, 2018 at 10:44:12PM +0000, John Groves (jgroves) wrote:
> Doh! Mpool stores its metadata as little endian, and rigorously uses
> le32_to_cpu and the like to move on-media structures to & from
> memory.
> 
> le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.

Fixed. Thanks for quick reply!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXT] Re: ready for v2.32 ?
  2018-02-26 22:50     ` Karel Zak
@ 2018-02-26 23:01       ` Ruediger Meier
  0 siblings, 0 replies; 10+ messages in thread
From: Ruediger Meier @ 2018-02-26 23:01 UTC (permalink / raw)
  To: Karel Zak; +Cc: John Groves (jgroves), util-linux

On Monday 26 February 2018, Karel Zak wrote:
> On Mon, Feb 26, 2018 at 10:44:12PM +0000, John Groves (jgroves) wrote:
> > Doh! Mpool stores its metadata as little endian, and rigorously
> > uses le32_to_cpu and the like to move on-media structures to & from
> > memory.
> >
> > le32_to_cpu(osd->osb_cksum1) would be the correct way to handle it.
>
> Fixed. Thanks for quick reply!

Always nice to see when it was worth to ask for adding a test case :)

cu,
Rudi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ready for v2.32 ?
  2018-02-07  9:47 Karel Zak
  2018-02-10 18:13 ` Samuel Thibault
@ 2018-02-26 20:02 ` Ruediger Meier
  1 sibling, 0 replies; 10+ messages in thread
From: Ruediger Meier @ 2018-02-26 20:02 UTC (permalink / raw)
  To: Karel Zak; +Cc: util-linux

On Wednesday 07 February 2018, Karel Zak wrote:

>  The regression tests improvements (for example faketime for cal(1))
>  we can merge during -rc1.

I think the faketime tests can wait. I will do this later one day when I 
feel really boring. Could be that we have to check carefully for the 
case that faketime(1) is available (and works) but ul is built against 
an exotic libc which does not work with the installed faketime.

BTW as we have talked about some months ago I still check the build 
for -m32 and different compilers with -Werror on travis from time to 
time. Still not automated because the repo dependencies are broken 
sometimes. But if it runs it runs :)

See here on top of v2.32-rc1-31-g79bd13842

# clang 3.9...5, gcc 4.8..7, xcode 6.4...9
https://travis-ci.org/rudimeier/util-linux/builds/346431564
# -m32 with clang and gcc
https://travis-ci.org/rudimeier/util-linux/builds/346431659

cu,
Rudi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ready for v2.32 ?
@ 2018-02-25 23:55 Thomas Deutschmann
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Deutschmann @ 2018-02-25 23:55 UTC (permalink / raw)
  To: util-linux

Hi,

util-linux v2.32 looks ready for us, passed all tests on Gentoo Linux
(tested against commit 2e20500a449955a69ea0b8381453079e8b57e9d3).


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ready for v2.32 ?
  2018-02-10 18:13 ` Samuel Thibault
@ 2018-02-12 11:10   ` Karel Zak
  0 siblings, 0 replies; 10+ messages in thread
From: Karel Zak @ 2018-02-12 11:10 UTC (permalink / raw)
  To: Samuel Thibault, util-linux

On Sat, Feb 10, 2018 at 07:13:44PM +0100, Samuel Thibault wrote:
> Here is a small build fix for the case where USE_PTY is not defined.

Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: ready for v2.32 ?
  2018-02-07  9:47 Karel Zak
@ 2018-02-10 18:13 ` Samuel Thibault
  2018-02-12 11:10   ` Karel Zak
  2018-02-26 20:02 ` Ruediger Meier
  1 sibling, 1 reply; 10+ messages in thread
From: Samuel Thibault @ 2018-02-10 18:13 UTC (permalink / raw)
  To: Karel Zak; +Cc: util-linux

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hello,

Here is a small build fix for the case where USE_PTY is not defined.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 410 bytes --]

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index afd75a1f1..9c6267f25 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -1417,8 +1417,10 @@ int su_main(int argc, char **argv, int mode)
 		setsid();
 	}
 
+#ifdef USE_PTY
 	if (su->pty)
 		pty_init_slave(su);
+#endif
 
 	/* Set environment after pam_open_session, which may put KRB5CCNAME
 	   into the pam_env, etc.  */

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* ready for v2.32 ?
@ 2018-02-07  9:47 Karel Zak
  2018-02-10 18:13 ` Samuel Thibault
  2018-02-26 20:02 ` Ruediger Meier
  0 siblings, 2 replies; 10+ messages in thread
From: Karel Zak @ 2018-02-07  9:47 UTC (permalink / raw)
  To: util-linux


 Hi,

 I'd like to release v2.32-rc1 on Friday (or Monday). Do you see any
 unwanted or missing patches in the master branch?

 For now the last missing thing is William's "calendar system header"
 option and switch for cal(1), but I think we can postpone this
 until v2.33. We have enough changes for cal(1) in v2.32 ;-)

 The regression tests improvements (for example faketime for cal(1))
 we can merge during -rc1.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-02-26 23:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 21:16 ready for v2.32 ? Ruediger Meier
2018-02-26 22:20 ` Karel Zak
2018-02-26 22:44   ` [EXT] " John Groves (jgroves)
2018-02-26 22:50     ` Karel Zak
2018-02-26 23:01       ` Ruediger Meier
  -- strict thread matches above, loose matches on Subject: below --
2018-02-25 23:55 Thomas Deutschmann
2018-02-07  9:47 Karel Zak
2018-02-10 18:13 ` Samuel Thibault
2018-02-12 11:10   ` Karel Zak
2018-02-26 20:02 ` Ruediger Meier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).