From: Karel Zak <kzak@redhat.com>
To: Carlos Santos <casantos@datacom.com.br>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] build-sys: make fdisk, sfdisk, cfdisk optional (enabled by default)
Date: Thu, 29 Nov 2018 11:37:38 +0100 [thread overview]
Message-ID: <20181129103738.n3xqiemqlv5iibvm@ws.net.home> (raw)
In-Reply-To: <20181122150549.32675-1-casantos@datacom.com.br>
On Thu, Nov 22, 2018 at 01:05:49PM -0200, Carlos Santos wrote:
> configure.ac | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Applied with a small change, thanks.
> +AC_ARG_ENABLE([fdisk],
renamed to --disable-fdisks
> + AS_HELP_STRING([--disable-fdisk], [do not build fdisk(8), sfdisk(8) and cfdisk(8)]),
> + [], [UL_DEFAULT_ENABLE([fdisk], [check])]
> +)
It seems better to initialize $enable_fdisk, $enable_sfdisk and
$enable_cfdisk to keep UL_BUILD_INIT() and UL_REQUIRES_* usable.
Karel
> +UL_BUILD_INIT([fdisk])
> UL_REQUIRES_HAVE([fdisk], [openat], [openat functions])
> UL_REQUIRES_BUILD([fdisk], [libfdisk])
> UL_REQUIRES_BUILD([fdisk], [libsmartcols])
> AM_CONDITIONAL([BUILD_FDISK], [test "x$build_fdisk" = xyes])
>
>
> -UL_BUILD_INIT([sfdisk], [check])
> +UL_BUILD_INIT([sfdisk])
> UL_REQUIRES_HAVE([sfdisk], [openat], [openat functions])
> UL_REQUIRES_BUILD([sfdisk], [libfdisk])
> UL_REQUIRES_BUILD([sfdisk], [libsmartcols])
> -AM_CONDITIONAL([BUILD_SFDISK], [test "x$build_sfdisk" = xyes])
> +AM_CONDITIONAL([BUILD_SFDISK], [test "x$build_fdisk" = xyes])
>
>
> -UL_BUILD_INIT([cfdisk], [check])
> +UL_BUILD_INIT([cfdisk])
> UL_REQUIRES_BUILD([cfdisk], [libfdisk])
> UL_REQUIRES_BUILD([cfdisk], [libsmartcols])
> UL_REQUIRES_HAVE([cfdisk], [open_memstream], [open_memstream function])
> UL_REQUIRES_HAVE([cfdisk], [ncursesw,slang,ncurses], [ncursesw, ncurses or slang library])
> -AM_CONDITIONAL([BUILD_CFDISK], [test "x$build_cfdisk" = xyes])
> +AM_CONDITIONAL([BUILD_CFDISK], [test "x$build_fdisk" = xyes])
>
>
> AC_ARG_ENABLE([mount],
> --
> 2.14.5
>
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2018-11-29 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 15:05 [PATCH] build-sys: make fdisk, sfdisk, cfdisk optional (enabled by default) Carlos Santos
2018-11-29 10:37 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129103738.n3xqiemqlv5iibvm@ws.net.home \
--to=kzak@redhat.com \
--cc=casantos@datacom.com.br \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).