Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] fstrim: document kernel return minlen explicitly
@ 2019-04-23 14:58 Wang Shilong
  2019-04-23 19:27 ` Darrick J. Wong
  2019-04-24  9:34 ` Karel Zak
  0 siblings, 2 replies; 3+ messages in thread
From: Wang Shilong @ 2019-04-23 14:58 UTC (permalink / raw)
  To: util-linux; +Cc: Wang Shilong, Darrick J. Wong

From: Wang Shilong <wshilong@ddn.com>

Filesystem will modify @minlen according to its
block size etc, and will return actual unit
to userspace, document it into manpage.

Cc: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Wang Shilong <wshilong@ddn.com>
---
v1->v2:
better explain as darrick suggestion..
---
 sys-utils/fstrim.8 | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/sys-utils/fstrim.8 b/sys-utils/fstrim.8
index f7e7aa9ef..c6ecca706 100644
--- a/sys-utils/fstrim.8
+++ b/sys-utils/fstrim.8
@@ -76,10 +76,11 @@ the end of the filesystem.
 .IP "\fB\-m, \-\-minimum\fP \fIminimum-size\fP"
 Minimum contiguous free range to discard, in bytes. (This value is internally
 rounded up to a multiple of the filesystem block size.)  Free ranges smaller
-than this will be ignored.  By increasing this value, the fstrim operation
-will complete more quickly for filesystems with badly fragmented freespace,
-although not all blocks will be discarded.  The default value is zero,
-discarding every free block.
+than this will be ignored and fstrim will adjust the minimum if it's smaller than
+the device's minimum, and report that (fstrim_range.minlen) back to userspace.
+By increasing this value, the fstrim operation will complete more quickly for
+filesystems with badly fragmented freespace, although not all blocks will be
+discarded.  The default value is zero, discarding every free block.
 .IP "\fB\-v, \-\-verbose\fP"
 Verbose execution.  With this option
 .B fstrim
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] fstrim: document kernel return minlen explicitly
  2019-04-23 14:58 [PATCH v2] fstrim: document kernel return minlen explicitly Wang Shilong
@ 2019-04-23 19:27 ` Darrick J. Wong
  2019-04-24  9:34 ` Karel Zak
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-04-23 19:27 UTC (permalink / raw)
  To: Wang Shilong; +Cc: util-linux, Wang Shilong

On Tue, Apr 23, 2019 at 11:58:28PM +0900, Wang Shilong wrote:
> From: Wang Shilong <wshilong@ddn.com>
> 
> Filesystem will modify @minlen according to its
> block size etc, and will return actual unit
> to userspace, document it into manpage.
> 
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> Signed-off-by: Wang Shilong <wshilong@ddn.com>

Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> v1->v2:
> better explain as darrick suggestion..
> ---
>  sys-utils/fstrim.8 | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/sys-utils/fstrim.8 b/sys-utils/fstrim.8
> index f7e7aa9ef..c6ecca706 100644
> --- a/sys-utils/fstrim.8
> +++ b/sys-utils/fstrim.8
> @@ -76,10 +76,11 @@ the end of the filesystem.
>  .IP "\fB\-m, \-\-minimum\fP \fIminimum-size\fP"
>  Minimum contiguous free range to discard, in bytes. (This value is internally
>  rounded up to a multiple of the filesystem block size.)  Free ranges smaller
> -than this will be ignored.  By increasing this value, the fstrim operation
> -will complete more quickly for filesystems with badly fragmented freespace,
> -although not all blocks will be discarded.  The default value is zero,
> -discarding every free block.
> +than this will be ignored and fstrim will adjust the minimum if it's smaller than
> +the device's minimum, and report that (fstrim_range.minlen) back to userspace.
> +By increasing this value, the fstrim operation will complete more quickly for
> +filesystems with badly fragmented freespace, although not all blocks will be
> +discarded.  The default value is zero, discarding every free block.
>  .IP "\fB\-v, \-\-verbose\fP"
>  Verbose execution.  With this option
>  .B fstrim
> -- 
> 2.21.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] fstrim: document kernel return minlen explicitly
  2019-04-23 14:58 [PATCH v2] fstrim: document kernel return minlen explicitly Wang Shilong
  2019-04-23 19:27 ` Darrick J. Wong
@ 2019-04-24  9:34 ` Karel Zak
  1 sibling, 0 replies; 3+ messages in thread
From: Karel Zak @ 2019-04-24  9:34 UTC (permalink / raw)
  To: Wang Shilong; +Cc: util-linux, Wang Shilong, Darrick J. Wong

On Tue, Apr 23, 2019 at 11:58:28PM +0900, Wang Shilong wrote:
>  sys-utils/fstrim.8 | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 14:58 [PATCH v2] fstrim: document kernel return minlen explicitly Wang Shilong
2019-04-23 19:27 ` Darrick J. Wong
2019-04-24  9:34 ` Karel Zak

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org util-linux@archiver.kernel.org
	public-inbox-index util-linux


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/ public-inbox