From: Nikolay Borisov <nborisov@suse.com>
To: kzak@redhat.com
Cc: util-linux@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 1/2] libblkid: Don't check BLKID_PROBE_INTERVAL in blkid_verify
Date: Mon, 13 May 2019 15:32:41 +0300 [thread overview]
Message-ID: <20190513123242.23673-1-nborisov@suse.com> (raw)
That constant is set to 200 seconds and is already check in probe_all().
It essentially controls how often blkid_probe_all can do a full cache
revalidation. Since blkid_verify is called from within probe_all() iff at least
BLKID_PROBE_INTERVAL seconds have elapsed it makes no sense to check this value
in blkid_verify.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
libblkid/src/verify.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libblkid/src/verify.c b/libblkid/src/verify.c
index 7f44f5497c8e..49fc11d228b8 100644
--- a/libblkid/src/verify.c
+++ b/libblkid/src/verify.c
@@ -96,8 +96,7 @@ blkid_dev blkid_verify(blkid_cache cache, blkid_dev dev)
st.st_mtime <= dev->bid_time &&
#endif
(diff < BLKID_PROBE_MIN ||
- (dev->bid_flags & BLKID_BID_FL_VERIFIED &&
- diff < BLKID_PROBE_INTERVAL)))
+ dev->bid_flags & BLKID_BID_FL_VERIFIED)) {
return dev;
#ifndef HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC
--
2.7.4
next reply other threads:[~2019-05-13 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 12:32 Nikolay Borisov [this message]
2019-05-13 12:32 ` [PATCH 2/2] libblkid: Set BLKID_BID_FL_VERIFIED in case revalidation is not needed Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513123242.23673-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).