From: Karel Zak <kzak@redhat.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH V2 2/2] libblkid: Set BLKID_BID_FL_VERIFIED in case revalidation is not needed
Date: Tue, 14 May 2019 13:39:51 +0200 [thread overview]
Message-ID: <20190514113951.q64zh2gngtj4oudb@ws.net.home> (raw)
In-Reply-To: <7901c2a7-f8c8-9e39-efb1-62ecd7fe74e2@suse.com>
On Mon, May 13, 2019 at 05:21:33PM +0300, Nikolay Borisov wrote:
> > (diff < BLKID_PROBE_MIN ||
> > - dev->bid_flags & BLKID_BID_FL_VERIFIED))
> > + dev->bid_flags & BLKID_BID_FL_VERIFIED)) {
> > + dev->bid_flags |= BLKID_BID_FL_VERIFIED;
>
> Actually I think this patch is wrong because the check for
> dev->bid_flags & BLKID_BID_FL_VERIFIED should also be removed. E.g.
Merged (both patches) and BLKID_BID_FL_VERIFIED removed. Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2019-05-14 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 12:44 [PATCH V2 1/2] libblkid: Don't check BLKID_PROBE_INTERVAL in blkid_verify Nikolay Borisov
2019-05-13 12:44 ` [PATCH V2 2/2] libblkid: Set BLKID_BID_FL_VERIFIED in case revalidation is not needed Nikolay Borisov
2019-05-13 14:21 ` Nikolay Borisov
2019-05-13 15:34 ` Karel Zak
2019-05-14 11:39 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514113951.q64zh2gngtj4oudb@ws.net.home \
--to=kzak@redhat.com \
--cc=nborisov@suse.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).