Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/3] fstrim: Fix fstrim_all() comment
@ 2019-06-10 19:59 Stanislav Brabec
  2019-06-11  9:24 ` Karel Zak
  0 siblings, 1 reply; 2+ messages in thread
From: Stanislav Brabec @ 2019-06-10 19:59 UTC (permalink / raw)
  To: util-linux

"convert LABEL=" does not happens in mnt_fs_get_source(), but later in
mnt_resolve_spec(). To make this more clean, move the comment before this
chunk of code.

Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
---
 sys-utils/fstrim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-utils/fstrim.c b/sys-utils/fstrim.c
index cae38cdff..ff029015e 100644
--- a/sys-utils/fstrim.c
+++ b/sys-utils/fstrim.c
@@ -290,8 +290,8 @@ static int fstrim_all(struct fstrim_control *ctl)
 		if (!tgt || mnt_fs_is_pseudofs(fs) || mnt_fs_is_netfs(fs))
 			continue;
 
+		/* convert LABEL= (etc.) from fstab to paths */
 		if (!src && cache) {
-			/* convert LABEL= (etc.) from fstab to paths */
 			const char *spec = mnt_fs_get_source(fs);
 
 			if (!spec)
-- 
2.21.0

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                         e-mail: sbrabec@suse.com
Křižíkova 148/34 (Corso IIa)                    tel: +420 284 084 060
186 00 Praha 8-Karlín                          fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/3] fstrim: Fix fstrim_all() comment
  2019-06-10 19:59 [PATCH 1/3] fstrim: Fix fstrim_all() comment Stanislav Brabec
@ 2019-06-11  9:24 ` Karel Zak
  0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2019-06-11  9:24 UTC (permalink / raw)
  To: Stanislav Brabec; +Cc: util-linux

On Mon, Jun 10, 2019 at 09:59:21PM +0200, Stanislav Brabec wrote:
>  sys-utils/fstrim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All three patches applied. I did some small additional change to the
code and to the man page.

Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-10 19:59 [PATCH 1/3] fstrim: Fix fstrim_all() comment Stanislav Brabec
2019-06-11  9:24 ` Karel Zak

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git