Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Carlos Santos <unixmania@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH v2] hwclock: define cmos_interface only if necessary
Date: Mon, 15 Jul 2019 15:39:20 +0200
Message-ID: <20190715133920.4pimvh6efigl5njy@ws.net.home> (raw)
In-Reply-To: <CAJ4jsafyxwqqScQ-Hi9vGhEbM2WExonm77ysohZDrVtNQoB+NA@mail.gmail.com>

On Wed, Jul 03, 2019 at 01:37:31PM -0300, Carlos Santos wrote:
> On Mon, Jun 24, 2019 at 4:41 AM Karel Zak <kzak@redhat.com> wrote:
> >
> > On Sun, Jun 23, 2019 at 07:30:52PM -0300, unixmania@gmail.com wrote:
> > > Make the static declaration of the cmos_interface struct and related
> > > functions conditional to i386/x86_64, preventing several "defined but
> > > not used" compiler warnings.
> >
> > I think we have to be more aggressive :-) It would be better to:
> >
> > ./configure.ac:
> >  * add --disable-hwclock-cmos
> >  * add USE_HWCLOCK_CMOS (enabled by default for i386/x86_64)
> 
> I don't know much about autoconf. How can I test the target
> architecture in config.ac.
> 
> >  * add define(USE_HWCLOCK_CMOS)
> >
> > sys-utils/Makemodule.am:
> >  * compile hwclock-cmos.c only "if USE_HWCLOCK_CMOS"
> >
> > hwclock:
> >  * remove all unnecessary #ifdefs from hwclock-cmos.c
> >  * add #ifdef USE_HWCLOCK_CMOS to hwclock.c:determine_clock_access_method()
> >
> >
> > Note that we already use the same for RTC (which is linux only).
> >
> > The result will be more readable hwclock-cmos.c and only optional cmos
> > code compilation.
> 
> I just sent a third version of the patch comprising all these changes
> except for the i386/x86_64 test.

I have applied the patch and extended the ./confiugure stuff.

https://github.com/karelzak/util-linux/commit/c7eca69d6d89262c71b6d412f6b3a469fad07d7d
https://github.com/karelzak/util-linux/commit/b1062292066e0568adbbdbb104b7afdcc5dac25f

Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-23 22:30 unixmania
2019-06-24  7:41 ` Karel Zak
2019-06-27 13:59   ` Carlos Santos
2019-07-03 16:37   ` Carlos Santos
2019-07-15 13:39     ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715133920.4pimvh6efigl5njy@ws.net.home \
    --to=kzak@redhat.com \
    --cc=unixmania@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git