From: Karel Zak <kzak@redhat.com> To: Patrick Steinhardt <ps@pks.im> Cc: util-linux@vger.kernel.org Subject: Re: [PATCH] tests: use env and support both unbuffer/stdbuf Date: Tue, 27 Aug 2019 14:46:21 +0200 Message-ID: <20190827124621.4vs4y2my2nrpc34v@10.255.255.10> (raw) In-Reply-To: <219cbcaeb173a07e97dbac8e1b653904369d91e0.1566907983.git.ps@pks.im> On Tue, Aug 27, 2019 at 02:26:08PM +0200, Patrick Steinhardt wrote: > Triggered by commit f612c4c67 (tests: fix --unbuffered mode with > ASAN, 2019-08-27), which says: > > Well, this patch sucks. It would be nice to have things in > the way how it has been original expected by Patrick's patch, > but ... > > So this commit here effectively reverts it and instead tries to > improve the shortcomings of the original patch. First, it uses > env(1) to set ASAN_OPTIONS instead of directly adding it to the > args array to fix execution of "${args[@]}" "$@". BTW, it's strange that ${args[@]} is interpreted in another way than when we write "FOO=bar command" directly to the script. Sounds like bash disadvantage. > Second, it now supports both unbuffer(1) and stdbuf(1). The > latter uses LD_PRELOAD tricks, which doesn't play nicely with > ASAN, so it will not be used if ASAN has been requested. It's > still valuable to have support for both, as many more systems > will have stdbuf(1) from coreutils installed but not unbuffer(1) > from expect. > > --- > > I wouldn't have minded, but as you state that your own patch > sucks I thought my initial approach might be preferable and thus > deemed it worthwhile to try and fix my original shortcomings. OK, I'll try to play with it tomorrow :-) Thanks. Karel -- Karel Zak <kzak@redhat.com> http://karelzak.blogspot.com
next prev parent reply index Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 10:16 [PATCH 0/6] Test suite fixes for musl libc Patrick Steinhardt 2019-08-23 10:16 ` [PATCH 1/6] tests: remove reliance on buffer behaviour of stderr/stdout streams Patrick Steinhardt 2019-08-23 10:16 ` [PATCH 2/6] tests: colcrt: fix reliance on EILSEQ in POSIX locale Patrick Steinhardt 2019-08-23 10:17 ` [PATCH 3/6] tests: column: use actually invalid multibytes to test encoding Patrick Steinhardt 2019-08-23 10:17 ` [PATCH 4/6] tests: col: avoid hardcoding of errno string Patrick Steinhardt 2019-08-23 10:17 ` [PATCH 5/6] tests: fdisk: " Patrick Steinhardt 2019-08-23 10:17 ` [PATCH 6/6] tests: libfdisk: remove reliance on buffer behaviour of standard streams Patrick Steinhardt 2019-08-23 12:15 ` Karel Zak 2019-08-23 13:32 ` [PATCH v2 0/6] Test suite fixes for musl libc Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 1/6] tests: remove reliance on buffer behaviour of stderr/stdout streams Patrick Steinhardt 2019-08-27 11:17 ` Karel Zak 2019-08-27 11:49 ` Patrick Steinhardt 2019-08-27 12:32 ` Karel Zak 2019-08-27 11:55 ` Patrick Steinhardt 2019-08-27 12:31 ` Karel Zak 2019-08-27 12:26 ` [PATCH] tests: use env and support both unbuffer/stdbuf Patrick Steinhardt 2019-08-27 12:46 ` Karel Zak [this message] 2019-08-28 10:51 ` Karel Zak 2019-08-30 19:08 ` Karel Zak 2019-08-31 7:41 ` Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 2/6] tests: libfdisk: remove reliance on buffer behaviour of standard streams Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 3/6] tests: colcrt: fix reliance on EILSEQ in POSIX locale Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 4/6] tests: column: use actually invalid multibytes to test encoding Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 5/6] tests: col: avoid hardcoding of errno string Patrick Steinhardt 2019-08-23 13:32 ` [PATCH v2 6/6] tests: fdisk: " Patrick Steinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190827124621.4vs4y2my2nrpc34v@10.255.255.10 \ --to=kzak@redhat.com \ --cc=ps@pks.im \ --cc=util-linux@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Util-Linux Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \ util-linux@vger.kernel.org public-inbox-index util-linux Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux AGPL code for this site: git clone https://public-inbox.org/public-inbox.git