From: "Michal Suchánek" <msuchanek@suse.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] blkid: open device in nonblock mode.
Date: Wed, 6 Nov 2019 10:45:17 +0100 [thread overview]
Message-ID: <20191106094517.GW1384@kitsune.suse.cz> (raw)
In-Reply-To: <20191106084833.nx3agnj36brw7i42@10.255.255.10>
On Wed, Nov 06, 2019 at 09:48:33AM +0100, Karel Zak wrote:
> On Wed, Nov 06, 2019 at 09:02:56AM +0100, Michal Suchánek wrote:
> > > If some random program using libblkid closes the tray I don't care that
> > > much. However, many system scripts use blkid, probably to find a device
>
> One of the random programs is udev:
>
> src/udev/udev-builtin-blkid.c:
>
> fd = open(devnode, O_RDONLY|O_CLOEXEC);
Yes, I have this on my radar. It does not seem to be used in the distro
build of systemd I use but should be addressed as well.
Thanks
Michal
next prev parent reply other threads:[~2019-11-06 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:23 [PATCH] blkid: open device in nonblock mode Michal Suchanek
2019-11-05 11:41 ` Karel Zak
2019-11-05 17:13 ` Michal Suchánek
2019-11-06 8:02 ` Michal Suchánek
2019-11-06 8:48 ` Karel Zak
2019-11-06 9:45 ` Michal Suchánek [this message]
2019-11-12 8:27 ` Anatoly Pugachev
2019-11-12 8:58 ` Karel Zak
2019-11-06 9:00 ` Karel Zak
2020-01-07 16:04 ` Karel Zak
2020-01-07 16:19 ` Michal Suchánek
2020-01-08 8:25 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106094517.GW1384@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).