From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18368C2D0DB for ; Mon, 27 Jan 2020 13:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4BBB214DB for ; Mon, 27 Jan 2020 13:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RW0SFj5W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbgA0NkP (ORCPT ); Mon, 27 Jan 2020 08:40:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:21527 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725828AbgA0NkP (ORCPT ); Mon, 27 Jan 2020 08:40:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580132414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hRzU4rc1FwB7m/7o3RZtWs511MEQMTUpBcQEgceXWn0=; b=RW0SFj5Ww9iXjVmTr2LxmF2OopR8x3rgoJTsaQFJc5f5UsKVlEn6QyzG/6W9CRYGODEWr9 oNwDA+U1LNLaKzTH92ntY4+w7uEUpGPFxD2JrgG65EyJeMfWtCWNm97x5UjIT+cWo4BVIj OZZhA1voBtIqQtKjR2Lx8o/hEOtVkmk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-WfMawMkjOzeIV9lc6twrhw-1; Mon, 27 Jan 2020 08:40:10 -0500 X-MC-Unique: WfMawMkjOzeIV9lc6twrhw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C06910120A8; Mon, 27 Jan 2020 13:40:09 +0000 (UTC) Received: from ws.net.home (ovpn-204-202.brq.redhat.com [10.40.204.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 796135DF2B; Mon, 27 Jan 2020 13:40:08 +0000 (UTC) Date: Mon, 27 Jan 2020 14:40:05 +0100 From: Karel Zak To: Carlos Santos Cc: util-linux@vger.kernel.org Subject: Re: [ANNOUNCE] util-linux v2.35 Message-ID: <20200127134005.qymawlxsf34p4oma@ws.net.home> References: <20200121105711.zzeeolydlivqnik7@ws.net.home> <20200127133435.tcnhf23yhi3laphp@ws.net.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127133435.tcnhf23yhi3laphp@ws.net.home> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: util-linux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: util-linux@vger.kernel.org On Mon, Jan 27, 2020 at 02:34:38PM +0100, Karel Zak wrote: > On Fri, Jan 24, 2020 at 04:16:47PM -0300, Carlos Santos wrote: > > I noticed that it comes due to sys-utils/hwclock-parse-date.y, which > > was taken from gnulib. Would it be possible to take the file from an > > previous version of gnulib that was still under GPLv2? > > I have checked it again and all history of the file in git is with v3, > and import old version also means import many bugs.... > > Maybe the best would be to use our lib/timeutils.c:parse_timestamp(). > It does not provide support for so many date-time formats, but the > basic format like "2012-09-22 16:34:22" (and subsets) is supported. > > IMHO it's better to introduce a small backward compatibility issue than > rely on hwclock-parse-date.y or execute date(1) like old versions. or we can use #ifdef to keep it backwardly compatible for normal distros where v3 is not problem and lib/timeutils.c:parse_timestamp() with v2 for the rest ... at least for v2.35.1. Karel -- Karel Zak http://karelzak.blogspot.com