Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: util-linux@vger.kernel.org, Benno Schulenberg <bensberg@justemail.net>
Subject: Re: [PATCH] libblkid: Add support for zonefs
Date: Mon, 23 Mar 2020 11:33:05 +0100
Message-ID: <20200323103305.uhlc3d7i4famwq5p@ws.net.home> (raw)
In-Reply-To: <20200320045543.2053382-1-damien.lemoal@wdc.com>

On Fri, Mar 20, 2020 at 01:55:43PM +0900, Damien Le Moal wrote:
>  libblkid/src/Makemodule.am             |  1 +
>  libblkid/src/superblocks/superblocks.c |  3 +-
>  libblkid/src/superblocks/superblocks.h |  1 +
>  libblkid/src/superblocks/zonefs.c      | 87 ++++++++++++++++++++++++++
>  4 files changed, 91 insertions(+), 1 deletion(-)
>  create mode 100644 libblkid/src/superblocks/zonefs.c

Applied (with a small change), thanks.

> +struct zonefs_super {
> +
> +	/* Magic number */
> +	__le32		s_magic;

We use standard integer types rather than this kernel-ism ;-) Fixed.

It would be nice to have a test image for zonefs, something small what
we can add to tests/ts/blkid/images-fs/ ;-)


    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  4:55 Damien Le Moal
2020-03-23 10:33 ` Karel Zak [this message]
2020-03-23 10:38   ` Damien Le Moal
2020-04-01  4:44   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323103305.uhlc3d7i4famwq5p@ws.net.home \
    --to=kzak@redhat.com \
    --cc=bensberg@justemail.net \
    --cc=damien.lemoal@wdc.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git