util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: nsenter(1): fix further details in PID namespace section
@ 2020-04-23  8:37 Stephen Kitt
  2020-04-23 10:41 ` Michael Kerrisk (man-pages)
  2020-04-27  9:32 ` Karel Zak
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Kitt @ 2020-04-23  8:37 UTC (permalink / raw)
  To: util-linux; +Cc: Michael Kerrisk, Stephen Kitt

The "Further details" sentence in the PID namespace section got merged
with the surrounding text; this patch moves it to the end, to match
the other namespace sections, and adds the missing clone(2) reference.

Fixes: 894efece9eb89 ("Provide better cross references for namespace concepts")
Signed-off-by: Stephen Kitt <steve@sk2.org>
---
 sys-utils/nsenter.1 | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/sys-utils/nsenter.1 b/sys-utils/nsenter.1
index 9cce839c0..c51d9b04a 100644
--- a/sys-utils/nsenter.1
+++ b/sys-utils/nsenter.1
@@ -61,17 +61,18 @@ flag in
 .B PID namespace
 Children will have a set of PID to process mappings separate from the
 .B nsenter
-process
+process.
+.B nsenter
+will fork by default if changing the PID namespace, so that the new program
+and its children share the same PID namespace and are visible to each other.
+If \fB\-\-no\-fork\fP is used, the new program will be exec'ed without forking.
 For further details, see
 .BR pid_namespaces (7)
 and
 the discussion of the
 .B CLONE_NEWPID
 flag in
-.B nsenter
-will fork by default if changing the PID namespace, so that the new program
-and its children share the same PID namespace and are visible to each other.
-If \fB\-\-no\-fork\fP is used, the new program will be exec'ed without forking.
+.BR clone (2).
 .TP
 .B user namespace
 The process will have a distinct set of UIDs, GIDs and capabilities.
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: nsenter(1): fix further details in PID namespace section
  2020-04-23  8:37 [PATCH] docs: nsenter(1): fix further details in PID namespace section Stephen Kitt
@ 2020-04-23 10:41 ` Michael Kerrisk (man-pages)
  2020-04-27  9:32 ` Karel Zak
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-04-23 10:41 UTC (permalink / raw)
  To: Stephen Kitt; +Cc: util-linux

Looks good to me.

Reviewed-by: Michael Kerrisk <mtk.manpages@gmail.com>

On Thu, 23 Apr 2020 at 10:38, Stephen Kitt <steve@sk2.org> wrote:
>
> The "Further details" sentence in the PID namespace section got merged
> with the surrounding text; this patch moves it to the end, to match
> the other namespace sections, and adds the missing clone(2) reference.
>
> Fixes: 894efece9eb89 ("Provide better cross references for namespace concepts")
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
>  sys-utils/nsenter.1 | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/sys-utils/nsenter.1 b/sys-utils/nsenter.1
> index 9cce839c0..c51d9b04a 100644
> --- a/sys-utils/nsenter.1
> +++ b/sys-utils/nsenter.1
> @@ -61,17 +61,18 @@ flag in
>  .B PID namespace
>  Children will have a set of PID to process mappings separate from the
>  .B nsenter
> -process
> +process.
> +.B nsenter
> +will fork by default if changing the PID namespace, so that the new program
> +and its children share the same PID namespace and are visible to each other.
> +If \fB\-\-no\-fork\fP is used, the new program will be exec'ed without forking.
>  For further details, see
>  .BR pid_namespaces (7)
>  and
>  the discussion of the
>  .B CLONE_NEWPID
>  flag in
> -.B nsenter
> -will fork by default if changing the PID namespace, so that the new program
> -and its children share the same PID namespace and are visible to each other.
> -If \fB\-\-no\-fork\fP is used, the new program will be exec'ed without forking.
> +.BR clone (2).
>  .TP
>  .B user namespace
>  The process will have a distinct set of UIDs, GIDs and capabilities.
> --
> 2.20.1
>


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: nsenter(1): fix further details in PID namespace section
  2020-04-23  8:37 [PATCH] docs: nsenter(1): fix further details in PID namespace section Stephen Kitt
  2020-04-23 10:41 ` Michael Kerrisk (man-pages)
@ 2020-04-27  9:32 ` Karel Zak
  1 sibling, 0 replies; 3+ messages in thread
From: Karel Zak @ 2020-04-27  9:32 UTC (permalink / raw)
  To: Stephen Kitt; +Cc: util-linux, Michael Kerrisk

On Thu, Apr 23, 2020 at 10:37:02AM +0200, Stephen Kitt wrote:
>  sys-utils/nsenter.1 | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Applied, thanks.


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-27  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23  8:37 [PATCH] docs: nsenter(1): fix further details in PID namespace section Stephen Kitt
2020-04-23 10:41 ` Michael Kerrisk (man-pages)
2020-04-27  9:32 ` Karel Zak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).