Util-Linux Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH RFC] blkzone: add capacity field to zone report
@ 2020-06-26 12:12 Shin'ichiro Kawasaki
  2020-06-29 11:11 ` Karel Zak
  0 siblings, 1 reply; 4+ messages in thread
From: Shin'ichiro Kawasaki @ 2020-06-26 12:12 UTC (permalink / raw)
  To: Karel Zak, util-linux; +Cc: Hans Holmberg, Damien Le Moal, Shinichiro Kawasaki

NVMe ZNS specification defines zone capacity. To support it in the
report zone interface, Linux kernel side patch review is ongoing. [1]
Expose it in report zone by blkzone command.

[1] https://www.spinics.net/lists/linux-block/msg55494.html

Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 configure.ac        |  4 ++++
 sys-utils/blkzone.8 |  1 +
 sys-utils/blkzone.c | 20 ++++++++++++++++++--
 3 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index e31dc3767..f3e9f5d0d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -322,6 +322,10 @@ AC_CHECK_HEADERS([security/pam_misc.h],
 
 AC_CHECK_HEADERS([linux/blkzoned.h])
 
+AC_CHECK_DECLS([BLK_ZONE_REP_CAPACITY], [], [], [
+	#include <linux/blkzoned.h>
+])
+
 AC_CHECK_HEADERS([security/openpam.h], [], [], [
 #ifdef HAVE_SECURITY_PAM_APPL_H
 #include <security/pam_appl.h>
diff --git a/sys-utils/blkzone.8 b/sys-utils/blkzone.8
index 64ad23bb3..043bc96e2 100644
--- a/sys-utils/blkzone.8
+++ b/sys-utils/blkzone.8
@@ -29,6 +29,7 @@ tab(:);
 l l.
 start:Zone start sector
 len:Zone length in number of sectors
+cap:Zone capacity in number of sectors
 wptr:Zone write pointer position
 reset:Reset write pointer recommended
 non-seq:Non-sequential write resources active
diff --git a/sys-utils/blkzone.c b/sys-utils/blkzone.c
index 11e90fb0e..0f62ca395 100644
--- a/sys-utils/blkzone.c
+++ b/sys-utils/blkzone.c
@@ -24,6 +24,7 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <stdint.h>
+#include <stdbool.h>
 #include <fcntl.h>
 #include <limits.h>
 #include <getopt.h>
@@ -189,6 +190,14 @@ done:
 	return rc == 0 ? sz : 0;
 }
 
+#if HAVE_DECL_BLK_ZONE_REP_CAPACITY
+#define has_zone_capacity(zi)	((zi)->flags & BLK_ZONE_REP_CAPACITY)
+#define zone_capacity(z)	(z)->capacity
+#else
+#define has_zone_capacity(zi)	(false)
+#define zone_capacity(z)	(z)->len
+#endif
+
 /*
  * blkzone report
  */
@@ -262,15 +271,22 @@ static int blkzone_report(struct blkzone_control *ctl)
 			uint64_t wp = entry->wp;
 			uint8_t cond = entry->cond;
 			uint64_t len = entry->len;
+			uint64_t cap;
 
 			if (!len) {
 				nr_zones = 0;
 				break;
 			}
 
-			printf(_("  start: 0x%09"PRIx64", len 0x%06"PRIx64", wptr 0x%06"PRIx64
+			if (has_zone_capacity(zi))
+				cap = zone_capacity(entry);
+			else
+				cap = entry->len;
+
+			printf(_("  start: 0x%09"PRIx64", len 0x%06"PRIx64
+				", cap 0x%06"PRIx64", wptr 0x%06"PRIx64
 				" reset:%u non-seq:%u, zcond:%2u(%s) [type: %u(%s)]\n"),
-				start, len, (type == 0x1) ? 0 : wp - start,
+				start, len, cap, (type == 0x1) ? 0 : wp - start,
 				entry->reset, entry->non_seq,
 				cond, condition_str[cond & (ARRAY_SIZE(condition_str) - 1)],
 				type, type_text[type]);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFC] blkzone: add capacity field to zone report
  2020-06-26 12:12 [PATCH RFC] blkzone: add capacity field to zone report Shin'ichiro Kawasaki
@ 2020-06-29 11:11 ` Karel Zak
  2020-07-01 11:32   ` Shinichiro Kawasaki
  0 siblings, 1 reply; 4+ messages in thread
From: Karel Zak @ 2020-06-29 11:11 UTC (permalink / raw)
  To: Shin'ichiro Kawasaki; +Cc: util-linux, Hans Holmberg, Damien Le Moal

On Fri, Jun 26, 2020 at 09:12:25PM +0900, Shin'ichiro Kawasaki wrote:
>  configure.ac        |  4 ++++
>  sys-utils/blkzone.8 |  1 +
>  sys-utils/blkzone.c | 20 ++++++++++++++++++--
>  3 files changed, 23 insertions(+), 2 deletions(-)

 Applied to the "next" branch (for v2.36 is too late). Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFC] blkzone: add capacity field to zone report
  2020-06-29 11:11 ` Karel Zak
@ 2020-07-01 11:32   ` Shinichiro Kawasaki
  2020-07-01 11:58     ` Karel Zak
  0 siblings, 1 reply; 4+ messages in thread
From: Shinichiro Kawasaki @ 2020-07-01 11:32 UTC (permalink / raw)
  To: Karel Zak; +Cc: util-linux, Hans Holmberg, Damien Le Moal

On Jun 29, 2020 / 13:11, Karel Zak wrote:
> On Fri, Jun 26, 2020 at 09:12:25PM +0900, Shin'ichiro Kawasaki wrote:
> >  configure.ac        |  4 ++++
> >  sys-utils/blkzone.8 |  1 +
> >  sys-utils/blkzone.c | 20 ++++++++++++++++++--
> >  3 files changed, 23 insertions(+), 2 deletions(-)
> 
>  Applied to the "next" branch (for v2.36 is too late). Thanks!

Hi Karel, thank you for picking it up.

The kernel side patch was applied to nvme-5.9. With this status, the commit
message of the blkzone RFC patch is rather weird. I will revise the commit
message and resend. Could you replace the patch in the next branch?

-- 
Best Regards,
Shin'ichiro Kawasaki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH RFC] blkzone: add capacity field to zone report
  2020-07-01 11:32   ` Shinichiro Kawasaki
@ 2020-07-01 11:58     ` Karel Zak
  0 siblings, 0 replies; 4+ messages in thread
From: Karel Zak @ 2020-07-01 11:58 UTC (permalink / raw)
  To: Shinichiro Kawasaki; +Cc: util-linux, Hans Holmberg, Damien Le Moal

On Wed, Jul 01, 2020 at 11:32:45AM +0000, Shinichiro Kawasaki wrote:
> On Jun 29, 2020 / 13:11, Karel Zak wrote:
> > On Fri, Jun 26, 2020 at 09:12:25PM +0900, Shin'ichiro Kawasaki wrote:
> > >  configure.ac        |  4 ++++
> > >  sys-utils/blkzone.8 |  1 +
> > >  sys-utils/blkzone.c | 20 ++++++++++++++++++--
> > >  3 files changed, 23 insertions(+), 2 deletions(-)
> > 
> >  Applied to the "next" branch (for v2.36 is too late). Thanks!
> 
> Hi Karel, thank you for picking it up.
> 
> The kernel side patch was applied to nvme-5.9. With this status, the commit
> message of the blkzone RFC patch is rather weird. I will revise the commit
> message and resend. Could you replace the patch in the next branch?

Sure, no problem to replace it.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 12:12 [PATCH RFC] blkzone: add capacity field to zone report Shin'ichiro Kawasaki
2020-06-29 11:11 ` Karel Zak
2020-07-01 11:32   ` Shinichiro Kawasaki
2020-07-01 11:58     ` Karel Zak

Util-Linux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/util-linux/0 util-linux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 util-linux util-linux/ https://lore.kernel.org/util-linux \
		util-linux@vger.kernel.org
	public-inbox-index util-linux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.util-linux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git