* [PATCH] col: fix --help short option in usage() output
@ 2020-10-14 20:22 Sami Kerola
2020-10-16 9:18 ` Karel Zak
0 siblings, 1 reply; 2+ messages in thread
From: Sami Kerola @ 2020-10-14 20:22 UTC (permalink / raw)
To: util-linux; +Cc: Sami Kerola
The col(1) is using unusual -H as --help short option. The -h is used for
--tabs (horizontal tab?) in this implementation.
Fixes: 62dee0176a0c8e687d9ff0cb87342a0f8b893aaa
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
text-utils/col.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/text-utils/col.c b/text-utils/col.c
index e35e581cd..6963eb68f 100644
--- a/text-utils/col.c
+++ b/text-utils/col.c
@@ -181,7 +181,8 @@ static void __attribute__((__noreturn__)) usage(void)
" -x, --spaces convert tabs to spaces\n"
" -l, --lines NUM buffer at least NUM lines\n"
));
- printf(USAGE_HELP_OPTIONS(24));
+ printf( " -H, --help %s\n", USAGE_OPTSTR_HELP);
+ printf( " -v, --version %s\n", USAGE_OPTSTR_VERSION);
printf(USAGE_MAN_TAIL("col(1)"));
exit(EXIT_SUCCESS);
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] col: fix --help short option in usage() output
2020-10-14 20:22 [PATCH] col: fix --help short option in usage() output Sami Kerola
@ 2020-10-16 9:18 ` Karel Zak
0 siblings, 0 replies; 2+ messages in thread
From: Karel Zak @ 2020-10-16 9:18 UTC (permalink / raw)
To: Sami Kerola; +Cc: util-linux
On Wed, Oct 14, 2020 at 09:22:45PM +0100, Sami Kerola wrote:
> The col(1) is using unusual -H as --help short option. The -h is used for
> --tabs (horizontal tab?) in this implementation.
Good catch. Applied, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-16 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 20:22 [PATCH] col: fix --help short option in usage() output Sami Kerola
2020-10-16 9:18 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).