util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: Sami Kerola <kerolasa@iki.fi>
Subject: [PATCH] colrm: fix argument parsing
Date: Mon, 19 Oct 2020 21:57:04 +0100	[thread overview]
Message-ID: <20201019205704.6762-1-kerolasa@iki.fi> (raw)

Short options had all sortss of characters listed, that were clearly copied
from col(1) command getopt_long() invocation.  Luckily both -V and -h were
part of the short options, but lets get rid of the unnecessary ones.

Fixes: 1647d032a7bfcba36d3dabe627b858b372210d05
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 text-utils/colrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/text-utils/colrm.c b/text-utils/colrm.c
index f9dfd5938..7df5a7450 100644
--- a/text-utils/colrm.c
+++ b/text-utils/colrm.c
@@ -169,7 +169,7 @@ int main(int argc, char **argv)
 	close_stdout_atexit();
 
 	while ((opt =
-		getopt_long(argc, argv, "bfhl:pxVH", longopts,
+		getopt_long(argc, argv, "Vh", longopts,
 			    NULL)) != -1)
 		switch (opt) {
 		case 'V':
-- 
2.28.0


                 reply	other threads:[~2020-10-19 20:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019205704.6762-1-kerolasa@iki.fi \
    --to=kerolasa@iki.fi \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).