util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: Karel Zak <kzak@redhat.com>,
	Jeffrey Bastian <jbastian@redhat.com>,
	Jeremy Linton <jeremy.linton@arm.com>
Cc: util-linux@vger.kernel.org, m.mizuma@jp.fujitsu.com
Subject: Re: [PATCH v4 2/2] lscpu-arm: Remove hard corded model name of Cortex family and X-Gene
Date: Tue, 10 Nov 2020 13:50:15 -0500	[thread overview]
Message-ID: <20201110185015.dk6xhlzdqrurlh7h@gabell> (raw)
In-Reply-To: <20201110083712.kfisfq4yv5yadx4w@ws.net.home>

On Tue, Nov 10, 2020 at 09:37:12AM +0100, Karel Zak wrote:
> On Mon, Nov 09, 2020 at 11:19:08PM -0600, Jeremy Linton wrote:
> > I don't agree with this, I think the hard coded table should be the first
> > authority on the manufacture/part number lists. That is because SMBIOS isn't
> > available on a fairly large number of arm systems, and on systems where it
> > does exist, it suffers from the same kinds of problems that exist on many
> > !arm machines. Its not particularly a reliable source of information.
> > 
> > So, maybe if you have a situation where the SMBIOS information is more
> > correct than the hardcoded tables, maybe its a good idea to create a new
> > line?
> > 
> > 
> > Aka:
> > 
> > Vendor Id: ARM
> > Model Name: Cortex-A57
> > BIOS Name: JoeSmithsCore
> 
> I like this idea. 

Yeah, it's s great idea!
SMBIOS Type4 also has Vendor Id (Processor Manufacturer),
so the following is better?

 Vendor Id: ARM
 Model Name: Cortex-A57
 BIOS Vendor Id: Foobar
 BIOS Model Name: JoeSmithsCore

Jeff, does the above idea work for your case? X-Gene(eMAG) will be:

 Vendor Id: APM
 Model Name: X-Gene
 BIOS Vendor Id: Ampere(TM)
 BIOS Model Name: eMAG 

Thanks,
Masa

> 
> Note that for majority of our users know, use and expect names like
> Cortex-A57, but I have doubts about "JoeSmithsCore" :-)
> 
> > In the vast majority of cases I imagine the strings should match. The
> > problematic cases are LTS os's running on newer hardware. For that i'm
> > somewhat of the opinion the Model Name should remain "unknown" rather than
> > being silently updated. That is to avoid cases where the output from newer
> > lscpu's changes during an upgrade.
> > 
> > PS, Having this hardcoded table isn't optimal, but for now I think we are
> > stuck with it. Hopefully at some point we can work out a reliable way to
> > source the info. In the meantime, it looks like I need to submit some table
> > updates, since there are some newer arm models...
> 
> Yes.
> 
>     Karel
> 
> -- 
>  Karel Zak  <kzak@redhat.com>
>  http://karelzak.blogspot.com
> 

  reply	other threads:[~2020-11-10 18:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  5:19 [PATCH v4 2/2] lscpu-arm: Remove hard corded model name of Cortex family and X-Gene Jeremy Linton
2020-11-10  8:37 ` Karel Zak
2020-11-10 18:50   ` Masayoshi Mizuma [this message]
2020-11-10 20:50     ` Jeffrey Bastian
2020-11-11  8:42       ` Karel Zak
  -- strict thread matches above, loose matches on Subject: below --
2020-11-09  3:04 [PATCH v4 1/2] lscpu-arm: Set the order to search the model name Masayoshi Mizuma
2020-11-09  3:04 ` [PATCH v4 2/2] lscpu-arm: Remove hard corded model name of Cortex family and X-Gene Masayoshi Mizuma
2020-11-09 16:23   ` Karel Zak
2020-11-09 18:51     ` Masayoshi Mizuma
2020-11-10  8:04       ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110185015.dk6xhlzdqrurlh7h@gabell \
    --to=msys.mizuma@gmail.com \
    --cc=jbastian@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=kzak@redhat.com \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).