util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org, jbastian@redhat.com,
	jeremy.linton@arm.com, Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Subject: Re: [PATCH v5] lscpu-arm: Add "BIOS Vendor ID" and "BIOS Model name" to show the SMBIOS information.
Date: Fri, 13 Nov 2020 11:47:05 -0500	[thread overview]
Message-ID: <20201113164705.oyzgzeczxle3vwc5@gabell> (raw)
In-Reply-To: <20201113095906.tjd5iee4xb6cd72d@ws.net.home>

On Fri, Nov 13, 2020 at 10:59:06AM +0100, Karel Zak wrote:
> On Tue, Nov 10, 2020 at 08:24:00PM -0500, Masayoshi Mizuma wrote:
> >  sys-utils/lscpu-arm.c | 22 ++++++++--------------
> >  sys-utils/lscpu.c     |  4 ++++
> >  sys-utils/lscpu.h     |  2 ++
> >  3 files changed, 14 insertions(+), 14 deletions(-)
> 
> Ported to the new lscpu and merged. Thanks (and extra thanks for
> your patience :-).

Thank you so much!

> 
> I see one issue with the stuff from BIOS. It seems it reads the
> information always from the same place. How does it work if I have two
> different CPUs? I guess it always return the same model name, but what
> if I have Cortex-A53 and Cortex-A72 on the same board?

The first entry, /sys/firmware/dmi/entries/4-0/raw, is only used,
so lscpu will show the same information of the SMBIOS type4 from
the entry even if the system has two diffrent cpu models, like
Cortex-A53 and Cortex-A72.
I'm not familiar with the heterogenous SoC, probably each
CPU model has own SMBIOS type4, right? for example, /sys/firmware/dmi/entries/4-0/raw
is for Cortex-A53 and /sys/firmware/dmi/entries/4-1/raw is for Cortex-A72.

> 
> Maybe we should disable reading from BIOS on systems with more than
> one CPU type.

I agree with you.

Thanks,
Masa

  reply	other threads:[~2020-11-13 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  1:24 [PATCH v5] lscpu-arm: Add "BIOS Vendor ID" and "BIOS Model name" to show the SMBIOS information Masayoshi Mizuma
2020-11-11  8:43 ` Karel Zak
2020-11-13  9:59 ` Karel Zak
2020-11-13 16:47   ` Masayoshi Mizuma [this message]
2020-11-13 18:21     ` Jeffrey Bastian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113164705.oyzgzeczxle3vwc5@gabell \
    --to=msys.mizuma@gmail.com \
    --cc=jbastian@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=kzak@redhat.com \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).