From: Karel Zak <kzak@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
util-linux@vger.kernel.org
Subject: Re: Fix building util-linux on non-linux
Date: Wed, 18 Nov 2020 10:34:45 +0100 [thread overview]
Message-ID: <20201118093445.addb4cfshmx6wt3a@ws.net.home> (raw)
In-Reply-To: <20201117202017.afatx2kpuxp5kf7u@function>
On Tue, Nov 17, 2020 at 09:20:17PM +0100, Samuel Thibault wrote:
> Hello,
>
> The attached patch fixes building on non-linux
>
> Samuel
> diff --git a/login-utils/Makemodule.am b/login-utils/Makemodule.am
> index 4f52cea3c..8bc3ee37e 100644
> --- a/login-utils/Makemodule.am
> +++ b/login-utils/Makemodule.am
> @@ -31,8 +31,10 @@ dist_man_MANS += login-utils/sulogin.8
> sulogin_SOURCES = \
> login-utils/sulogin.c \
> login-utils/sulogin-consoles.c \
> - login-utils/sulogin-consoles.h \
> - lib/plymouth-ctrl.c
> + login-utils/sulogin-consoles.h
> +if USE_PLYMOUTH_SUPPORT
> +sulogin_SOURCES += lib/plymouth-ctrl.c
> +endif
> sulogin_LDADD = $(LDADD) libcommon.la
Yep, stupid bug. Fixed by https://github.com/karelzak/util-linux/pull/1190.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2020-11-18 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 20:20 Fix building util-linux on non-linux Samuel Thibault
2020-11-18 9:34 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118093445.addb4cfshmx6wt3a@ws.net.home \
--to=kzak@redhat.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).