From: Karel Zak <kzak@redhat.com>
To: Chris Hofstaedtler <zeha@debian.org>
Cc: util-linux@vger.kernel.org
Subject: Re: fsck silently exits when fstype-specific fsck is not found
Date: Tue, 5 Jan 2021 13:07:59 +0100 [thread overview]
Message-ID: <20210105120759.iz2lkufewlpqld6f@ws.net.home> (raw)
In-Reply-To: <20201229191814.ltehybec7ql67xm5@zeha.at>
On Tue, Dec 29, 2020 at 08:18:14PM +0100, Chris Hofstaedtler wrote:
> Hi,
>
> I just noticed that fsck, when given a single device name, silently
> exits when it cannot find an appropriate fsck.%s program.
>
> Example:
> (/dev/sda1 is an EFI System Partition, so type=vfat)
> # fsck -V /dev/sda1
> fsck from util-linux 2.36.1
> # echo $?
> 0
>
> Note that it also does not warn about fsck.vfat not being found or
> anything really.
>
> This appears because fsck.c has a "really_wanted" list of fstypes;
> anything not in there gets the mentioned behaviour.
>
> I find this to be very surprising. What are the reasons for this?
I guess to avoid unnecessary warnings on systems with filesystems
where fsck is not (or wasn't) implemented like btrfs or xfs.
> I could try changing this code path, but I'm not sure if this is
> expected in the first place?
Maybe we can introduce some another list of filesystems where fsck is
optional and recommended, but it's no error when not available -- it
means print warning, but do not exit with an error.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2021-01-05 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 19:18 fsck silently exits when fstype-specific fsck is not found Chris Hofstaedtler
2021-01-05 12:07 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105120759.iz2lkufewlpqld6f@ws.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=zeha@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).