[PATCH] rfkill: Set scols table name to make the json output valid

[PATCH] rfkill: Set scols table name to make the json output valid

[Nicolai Dagestad]

Signed-off-by: Nicolai Dagestad <nicolai@dagestad.fr>

---

Hi, I just noticed that the json input for rfkill is invalid.
The array member of the top-level object, should be named but it wasn't.
I am not familiar with the codease so I just followed what I saw in lscpu,
if another name would be prefered I can change it.

 sys-utils/rfkill.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys-utils/rfkill.c b/sys-utils/rfkill.c
index 0e740e122..41b933415 100644
--- a/sys-utils/rfkill.c
+++ b/sys-utils/rfkill.c
@@ -465,6 +465,7 @@ static void rfkill_list_init(struct control *ctrl)
 		err(EXIT_FAILURE, _("failed to allocate output table"));
 
 	scols_table_enable_json(ctrl->tb, ctrl->json);
+	scols_table_set_name(ctrl->tb, "rfkill");
 	scols_table_enable_noheadings(ctrl->tb, ctrl->no_headings);
 	scols_table_enable_raw(ctrl->tb, ctrl->raw);
 
-- 
2.31.1

Re: [PATCH] rfkill: Set scols table name to make the json output valid

[Karel Zak]

On Sun, Jun 06, 2021 at 06:28:35PM +0200, Nicolai Dagestad wrote:
> Hi, I just noticed that the json input for rfkill is invalid.
> The array member of the top-level object, should be named but it wasn't.

I have also improve libsmartcols to not use unnamed array for the
top-level object. It seems better to use emptry string ("") than
nothing.

> I am not familiar with the codease so I just followed what I saw in lscpu,
> if another name would be prefered I can change it.

Changed to "rfkilldevices".

>  sys-utils/rfkill.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks!

 karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com