* [PATCH] Skip lsns/ioctl_ns test if unshare fails
@ 2021-08-20 10:30 Chris Hofstaedtler
2021-08-20 10:57 ` Chris Hofstaedtler
2021-08-31 13:21 ` Karel Zak
0 siblings, 2 replies; 3+ messages in thread
From: Chris Hofstaedtler @ 2021-08-20 10:30 UTC (permalink / raw)
To: util-linux
Some parts of the Debian build infrastructure uses unshare to run the
package build, and that appears to cause a "nested" unshare in the
lsns/ioctl_ns test to fail. Unfortunately the tests then hang at this
point.
Try running unshare before the actual test, and skip the test if unshare
already fails.
---
tests/ts/lsns/ioctl_ns | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/ts/lsns/ioctl_ns b/tests/ts/lsns/ioctl_ns
index ef6360607..15dd1af74 100755
--- a/tests/ts/lsns/ioctl_ns
+++ b/tests/ts/lsns/ioctl_ns
@@ -34,6 +34,8 @@ ts_check_prog "mkfifo"
ts_check_prog "touch"
ts_check_prog "uniq"
+$TS_CMD_UNSHARE --user --pid --mount-proc true || ts_skip "Namespace support failure"
+
ts_cd "$TS_OUTDIR"
# The parent process receives namespaces ids via FIFO_DATA from bash
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip lsns/ioctl_ns test if unshare fails
2021-08-20 10:30 [PATCH] Skip lsns/ioctl_ns test if unshare fails Chris Hofstaedtler
@ 2021-08-20 10:57 ` Chris Hofstaedtler
2021-08-31 13:21 ` Karel Zak
1 sibling, 0 replies; 3+ messages in thread
From: Chris Hofstaedtler @ 2021-08-20 10:57 UTC (permalink / raw)
To: util-linux
Sorry, I missed to add my own signoff.
* Chris Hofstaedtler <zeha@debian.org> [210820 12:42]:
> Some parts of the Debian build infrastructure uses unshare to run the
> package build, and that appears to cause a "nested" unshare in the
> lsns/ioctl_ns test to fail. Unfortunately the tests then hang at this
> point.
>
> Try running unshare before the actual test, and skip the test if unshare
> already fails.
>
Signed-off-by: Chris Hofstaedtler <zeha@debian.org>
> ---
> tests/ts/lsns/ioctl_ns | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/ts/lsns/ioctl_ns b/tests/ts/lsns/ioctl_ns
> index ef6360607..15dd1af74 100755
> --- a/tests/ts/lsns/ioctl_ns
> +++ b/tests/ts/lsns/ioctl_ns
> @@ -34,6 +34,8 @@ ts_check_prog "mkfifo"
> ts_check_prog "touch"
> ts_check_prog "uniq"
>
> +$TS_CMD_UNSHARE --user --pid --mount-proc true || ts_skip "Namespace support failure"
> +
> ts_cd "$TS_OUTDIR"
>
> # The parent process receives namespaces ids via FIFO_DATA from bash
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Skip lsns/ioctl_ns test if unshare fails
2021-08-20 10:30 [PATCH] Skip lsns/ioctl_ns test if unshare fails Chris Hofstaedtler
2021-08-20 10:57 ` Chris Hofstaedtler
@ 2021-08-31 13:21 ` Karel Zak
1 sibling, 0 replies; 3+ messages in thread
From: Karel Zak @ 2021-08-31 13:21 UTC (permalink / raw)
To: Chris Hofstaedtler; +Cc: util-linux
On Fri, Aug 20, 2021 at 10:30:50AM +0000, Chris Hofstaedtler wrote:
> +$TS_CMD_UNSHARE --user --pid --mount-proc true || ts_skip "Namespace support failure"
The --pid requires --fork, fixed and committed:
https://github.com/karelzak/util-linux/commit/597ccb7bf564f65bb059bfe420224cab0fba46ac
Thanks
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-31 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 10:30 [PATCH] Skip lsns/ioctl_ns test if unshare fails Chris Hofstaedtler
2021-08-20 10:57 ` Chris Hofstaedtler
2021-08-31 13:21 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).