From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: util-linux@vger.kernel.org
Cc: jkosina@suse.cz, kzak@redhat.com, kurt@garloff.de,
vsementsov@virtuozzo.com, den@openvz.org, msuchanek@suse.de,
efremov@linux.com
Subject: [PATCH 0/2] libblkid: don't use O_NONBLOCK for floppy
Date: Thu, 9 Dec 2021 15:12:31 +0100 [thread overview]
Message-ID: <20211209141233.3774937-1-vsementsov@virtuozzo.com> (raw)
Good day everyone!
The commit "floppy: reintroduce O_NDELAY fix" was removed from kernel,
so we faced the bug described and discussed here:
https://bugzilla.suse.com/show_bug.cgi?id=1181018
Discussion in kernel list on reverting the commit:
https://www.spinics.net/lists/stable/msg493061.html
In short, I can quote Jiri Kosina's comment:
opening floppy device node with O_NONBLOCK is asking for all kinds
of trouble
So opening floppy with O_NONBLOCK in blkid leads to failure of blkid,
probable failure of mount and unpleasant error messages in dmesg (see
also patch 02 for details).
Vladimir Sementsov-Ogievskiy (2):
libblkid: introduce blkid_safe_open
libblkid: reopen floppy without O_NONBLOCK
libblkid/src/blkid.h.in | 2 ++
libblkid/src/evaluate.c | 2 +-
libblkid/src/libblkid.sym | 4 ++++
libblkid/src/probe.c | 44 ++++++++++++++++++++++++++++++++++++++-
libblkid/src/verify.c | 2 +-
misc-utils/blkid.c | 2 +-
misc-utils/wipefs.c | 2 +-
7 files changed, 53 insertions(+), 5 deletions(-)
--
2.31.1
next reply other threads:[~2021-12-09 14:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:12 Vladimir Sementsov-Ogievskiy [this message]
2021-12-09 14:12 ` [PATCH 1/2] libblkid: introduce blkid_safe_open Vladimir Sementsov-Ogievskiy
2021-12-09 14:12 ` [PATCH 2/2] libblkid: reopen floppy without O_NONBLOCK Vladimir Sementsov-Ogievskiy
2021-12-14 11:45 ` Michal Suchánek
2021-12-14 13:58 ` Vladimir Sementsov-Ogievskiy
2021-12-14 12:03 ` Karel Zak
2021-12-14 14:24 ` Vladimir Sementsov-Ogievskiy
2021-12-15 12:56 ` Karel Zak
2021-12-16 8:47 ` Vladimir Sementsov-Ogievskiy
2021-12-24 15:31 ` Vladimir Sementsov-Ogievskiy
2022-01-03 8:43 ` Karel Zak
2022-01-17 11:50 ` Karel Zak
2022-01-17 15:46 ` Vladimir Sementsov-Ogievskiy
2022-01-17 16:12 ` Karel Zak
2022-01-17 18:10 ` Vladimir Sementsov-Ogievskiy
2022-01-20 9:14 ` Karel Zak
2022-01-21 10:18 ` Karel Zak
2022-01-21 12:13 ` Vladimir Sementsov-Ogievskiy
2022-01-21 13:57 ` Karel Zak
2021-12-14 10:25 ` [PATCH 0/2] libblkid: don't use O_NONBLOCK for floppy Jiri Kosina
2021-12-14 10:29 ` Kurt Garloff
2021-12-14 11:46 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209141233.3774937-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=efremov@linux.com \
--cc=jkosina@suse.cz \
--cc=kurt@garloff.de \
--cc=kzak@redhat.com \
--cc=msuchanek@suse.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).