util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eb@emlix.com>
To: util-linux@vger.kernel.org
Subject: bashcompletiondir should not be set or tested when --disable-bash-completion is given
Date: Tue, 14 Jun 2022 10:52:02 +0200	[thread overview]
Message-ID: <2832693.e9J7NaK4W3@mobilepool36.emlix.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]

I tried building some util-linux libraries in a minimal chroot (no pkg-config). 
At the end it boils down to

./configure --disable-bash-completion <other stuff>

The result of this was:

checking for ECONF... no
./configure: line 37542: --exists: command not found
checking for a Python interpreter with version >= 2... none
[...]

        Bash completions:          ${datarootdir}/bash-completion/completions
        Systemd support:           no
[...]
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/sbin'
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/share/bash-completion/
completions'
 /bin/mkdir -p '/tmp/e2/root/opt/emlix/master/share/man/man1'

The problem with the "--exists" is this line (of course at a totally different 
line number in configure):

  if `$PKG_CONFIG --exists bash-completion`; then :

The PKG_CONFIG variable is empty and in contrast to most other places, the 
other notable exceptions being the checks for tinfow, tinfo, and 
libcryptsetup, the variable is not checked for being empty before usage. And 
at the end this should probably somehow depend on enable_bash_completion=yes 
to avoid creating an empty directory as well.

Regards,

Eike
-- 
Besuchen Sie uns auf der Embedded World 2022 in Nürnberg!
-> 21.-23.06.2022 - Halle 4, Stand 336

Rolf Eike Beer, emlix GmbH, https://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]

             reply	other threads:[~2022-06-14  8:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  8:52 Rolf Eike Beer [this message]
2022-06-14 13:58 ` bashcompletiondir should not be set or tested when --disable-bash-completion is given Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2832693.e9J7NaK4W3@mobilepool36.emlix.com \
    --to=eb@emlix.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).